Skip to content

Sync with Comcast upstream and republish @grafana/react-data-grid (auto-height, a11y, npm publishing) - #7

Open
fastfrwrd wants to merge 230 commits into
mainfrom
chore/sync-comcast-upstream
Open

Sync with Comcast upstream and republish @grafana/react-data-grid (auto-height, a11y, npm publishing)#7
fastfrwrd wants to merge 230 commits into
mainfrom
chore/sync-comcast-upstream

Conversation

@fastfrwrd

@fastfrwrd fastfrwrd commented Aug 6, 2026

Copy link
Copy Markdown

Brings our long-stale main current with Comcast/react-data-grid upstream (a88517cc8) and re-layers Grafana's changes on top, so we can publish a fresh @grafana/react-data-grid from main. #8 merges into this branch first, so merging this PR to main delivers everything below.

Why now

We were blocked from pulling upstream for over a year due to now-resolved tooling limits, and Grafana has moved off React 18 (which is why the old react-18 fork branch existed). This resets main to upstream and keeps only the non-React-18 value.

What's in here

Upstream sync — ~220 upstream commits, bringing the fork to a88517cc8. Ingested under the signed-commits fork-sync exemption (Freshservice #168922, per #platform-productivity-chat).

Auto-height (upstream PR Comcast#4040 re-layered) — dynamic row heights for non-virtualized rendering: rowHeight accepts a string (e.g. "auto") with discriminated-union typing, plus PageUp/PageDown paging. Includes test/browser/rowHeight.test.tsx and the DynamicHeightCells example. This is what Grafana's Table panel relies on.

Accessibilityaria-hidden on non-interactive utility elements (drag handle, drag image, measuring cells, scroll-to-position element). Upstream already covers the resize handle and removed the old focus-sink, so those hunks are dropped.

Publish @grafana/react-data-grid from main (rides upstream's npm/tsdown/Node-26 tooling):

  • Rename to @grafana/react-data-grid, publishConfig.access: public, version 7.0.0-beta.59, repo/homepage/bugs → Grafana fork.
  • ci.yml: version-gated auto-publish job (EndBug/version-check) → npm trusted publishing on push to main when the version changes, then tag + GitHub release.
  • Remove Comcast-only tooling that shouldn't run in the fork: publish.yml, update-screenshots.yml, and the gh-pages deploy step (hardcoded Comcast repo URL).
  • CODEOWNERS → dataviz-squad; README fork note.

CI hardening for Grafana org rulesets — pin all actions to full SHAs (zizmor unpinned-uses), explicit permissions, persist-credentials: false on the test checkout. package-lock.json root updated for the scope/version (no dependency changes).

Merge order

  1. Merge Republish as @grafana/react-data-grid from main: auto-height (#4040), a11y, npm publishing #8 into this branch (chore/sync-comcast-upstream) — a non-default branch, so it's not gated by the zizmor / required-PR rules. This lands the clean ci.yml + workflow deletions here.
  2. This PR's checks then go green; merge to main with a merge commit (not squash) so upstream history is preserved.
  3. Merging to main trips the version-gated publish job → publishes @grafana/react-data-grid@7.0.0-beta.59.

Publishing note

npm trusted-publisher config must point at this repo's ci.yml workflow (beta.57/.58 published from ci.yml on react-18; same workflow filename).

dependabot Bot and others added 30 commits June 23, 2025 13:46
Bumps [prettier](https://github.com/prettier/prettier) from 3.5.3 to 3.6.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.5.3...3.6.0)

---
updated-dependencies:
- dependency-name: prettier
  dependency-version: 3.6.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome) from 2.0.0 to 2.0.4.
- [Release notes](https://github.com/biomejs/biome/releases)
- [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md)
- [Commits](https://github.com/biomejs/biome/commits/@biomejs/biome@2.0.4/packages/@biomejs/biome)

---
updated-dependencies:
- dependency-name: "@biomejs/biome"
  dependency-version: 2.0.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add `aria-label`

* group radiop buttons

* Associate h1 with the main landmark

* Apply lighthouse suggestions

* Split nav

* Revert 1 change

* remove import
Bumps [prettier](https://github.com/prettier/prettier) from 3.6.0 to 3.6.2.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.6.0...3.6.2)

---
updated-dependencies:
- dependency-name: prettier
  dependency-version: 3.6.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome) from 2.0.4 to 2.0.6.
- [Release notes](https://github.com/biomejs/biome/releases)
- [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md)
- [Commits](https://github.com/biomejs/biome/commits/@biomejs/biome@2.0.6/packages/@biomejs/biome)

---
updated-dependencies:
- dependency-name: "@biomejs/biome"
  dependency-version: 2.0.6
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update dependencies

* Update remaning deps
* Update packages

* Use exact version

* update router
* Add an open to select color-scheme

* Add label

* Rename

* Simplify

* Update src/style/core.ts

Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>

* Add space

---------

Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
* Switch to `esbuild` minfier for CSS

* Add a note on rollowdown

* Add a `Theming` section

* Update README.md

Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>

---------

Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
* update deps

* ignore biome lint
Bumps [rolldown-plugin-dts](https://github.com/sxzz/rolldown-plugin-dts) from 0.14.3 to 0.15.1.
- [Release notes](https://github.com/sxzz/rolldown-plugin-dts/releases)
- [Commits](sxzz/rolldown-plugin-dts@v0.14.3...v0.15.1)

---
updated-dependencies:
- dependency-name: rolldown-plugin-dts
  dependency-version: 0.15.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aman Mahajan <amahajan@stratag.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update dependencies

* biome rule is fixed

* Update ignore list

* Add new rules

* Add new rules

* Update new deps

* Add more rules

* Add markdown rules
* Remove invalid rule

* Try `concurrency=2`

* Remove concurreny
Bumps [@faker-js/faker](https://github.com/faker-js/faker) from 9.9.0 to 10.0.0.
- [Release notes](https://github.com/faker-js/faker/releases)
- [Changelog](https://github.com/faker-js/faker/blob/next/CHANGELOG.md)
- [Commits](faker-js/faker@v9.9.0...v10.0.0)

---
updated-dependencies:
- dependency-name: "@faker-js/faker"
  dependency-version: 10.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aman Mahajan <amahajan@stratag.com>
* Add `rdg-resize-handle` classname

* Update tests

* Reuse helper
Bumps [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome) from 2.2.0 to 2.2.2.
- [Release notes](https://github.com/biomejs/biome/releases)
- [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md)
- [Commits](https://github.com/biomejs/biome/commits/@biomejs/biome@2.2.2/packages/@biomejs/biome)

---
updated-dependencies:
- dependency-name: "@biomejs/biome"
  dependency-version: 2.2.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add command methods and CSS variable types

* Remove extra fields
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4 to 5.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [rolldown-plugin-dts](https://github.com/sxzz/rolldown-plugin-dts) from 0.15.10 to 0.16.1.
- [Release notes](https://github.com/sxzz/rolldown-plugin-dts/releases)
- [Commits](sxzz/rolldown-plugin-dts@v0.15.10...v0.16.1)

---
updated-dependencies:
- dependency-name: rolldown-plugin-dts
  dependency-version: 0.16.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome) from 2.2.2 to 2.2.3.
- [Release notes](https://github.com/biomejs/biome/releases)
- [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md)
- [Commits](https://github.com/biomejs/biome/commits/@biomejs/biome@2.2.3/packages/@biomejs/biome)

---
updated-dependencies:
- dependency-name: "@biomejs/biome"
  dependency-version: 2.2.3
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome) from 2.2.3 to 2.2.4.
- [Release notes](https://github.com/biomejs/biome/releases)
- [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md)
- [Commits](https://github.com/biomejs/biome/commits/@biomejs/biome@2.2.4/packages/@biomejs/biome)

---
updated-dependencies:
- dependency-name: "@biomejs/biome"
  dependency-version: 2.2.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…mcast#3865)

* Optimize grid template rows generation with CSS repeat() function

* Add comprehensive tests for grid template rows optimization

* Add edge case tests for unique first and last row heights

* Remove redundant trim() and added some comments

* refactor: use map instead of forEach for row positions

---------

Co-authored-by: Aman Mahajan <amahajan@stratag.com>
* Run tests in FF

* Fix editor test, use istanbul for coverage

* Remove optimizeDeps

* revert 1 change

* Fix keyboard tests

* Revert

* Fix rowHeight tests

* Fix focus in FF

* headless

* ESLint

* Tweak focus logic

* Fix test

* Fix test in FF

* Revert firefox workaround

* try beta version

* Revert "try beta version"

This reverts commit a00f60e.

* Try pinning vitest

* Revert "Try pinning vitest"

This reverts commit faafac2.

* Revrt timeout

* try `maxWorkers`

* `maxWorkers: 4,`

* increate testTimeout

* try beta

* Fix grouping test

* Fix a few tests

* Format

* Use stable version

* -1

* -1

* -1

* -2

* tryl gridcell role

* biome

* Remove timeout

* Does this work?

* Set maxWorkers = 1

* revert a few changes

* Revert 1 more change

* one more

* Revert a few more changes

* Fix resizable test

* Add speciial case for firefox CI

* revert 1 change

* Fix test

* Revert accidental change

* tweak

* Use SHA

* remove `react-dnd` pattern

* Disable `fileParallelism`

* Check chrome explicitly

* Use strick check

* Add a comment

* Update test/browser/column/renderEditCell.test.tsx

Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>

* Update test/browser/column/renderEditCell.test.tsx

Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>

---------

Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
dependabot Bot and others added 22 commits July 16, 2026 19:24
Bumps [eslint](https://github.com/eslint/eslint) from 10.6.0 to 10.7.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v10.6.0...v10.7.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-version: 10.7.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint-plugin-sonarjs](https://github.com/SonarSource/SonarJS) from 4.1.0 to 4.2.0.
- [Release notes](https://github.com/SonarSource/SonarJS/releases)
- [Changelog](https://github.com/SonarSource/SonarJS/blob/master/docs/RELEASE.md)
- [Commits](https://github.com/SonarSource/SonarJS/commits)

---
updated-dependencies:
- dependency-name: eslint-plugin-sonarjs
  dependency-version: 4.2.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@eslint/markdown](https://github.com/eslint/markdown) from 8.0.2 to 8.0.3.
- [Release notes](https://github.com/eslint/markdown/releases)
- [Changelog](https://github.com/eslint/markdown/blob/main/CHANGELOG.md)
- [Commits](eslint/markdown@v8.0.2...v8.0.3)

---
updated-dependencies:
- dependency-name: "@eslint/markdown"
  dependency-version: 8.0.3
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@vitest/eslint-plugin](https://github.com/vitest-dev/eslint-plugin-vitest) from 1.6.20 to 1.6.23.
- [Release notes](https://github.com/vitest-dev/eslint-plugin-vitest/releases)
- [Commits](vitest-dev/eslint-plugin-vitest@v1.6.20...v1.6.23)

---
updated-dependencies:
- dependency-name: "@vitest/eslint-plugin"
  dependency-version: 1.6.23
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [oxfmt](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxfmt) from 0.58.0 to 0.59.0.
- [Release notes](https://github.com/oxc-project/oxc/releases)
- [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxfmt/CHANGELOG.md)
- [Commits](https://github.com/oxc-project/oxc/commits/oxfmt_v0.59.0/npm/oxfmt)

---
updated-dependencies:
- dependency-name: oxfmt
  dependency-version: 0.59.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 26.1.0 to 26.1.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 26.1.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 5.0.6 to 5.0.7.
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](juliangruber/brace-expansion@v5.0.6...v5.0.7)

---
updated-dependencies:
- dependency-name: brace-expansion
  dependency-version: 5.0.7
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…k-router group (Comcast#4115)

Bump @tanstack/router-plugin in the tanstack-router group

Bumps the tanstack-router group with 1 update: [@tanstack/router-plugin](https://github.com/TanStack/router/tree/HEAD/packages/router-plugin).


Updates `@tanstack/router-plugin` from 1.168.20 to 1.168.23
- [Release notes](https://github.com/TanStack/router/releases)
- [Changelog](https://github.com/TanStack/router/blob/main/packages/router-plugin/CHANGELOG.md)
- [Commits](https://github.com/TanStack/router/commits/@tanstack/router-plugin@1.168.23/packages/router-plugin)

---
updated-dependencies:
- dependency-name: "@tanstack/router-plugin"
  dependency-version: 1.168.23
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: tanstack-router
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/tree/HEAD/packages/plugin-react) from 6.0.3 to 6.0.4.
- [Release notes](https://github.com/vitejs/vite-plugin-react/releases)
- [Changelog](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite-plugin-react/commits/plugin-react@6.0.4/packages/plugin-react)

---
updated-dependencies:
- dependency-name: "@vitejs/plugin-react"
  dependency-version: 6.0.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) from 8.64.0 to 8.65.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.65.0/packages/typescript-eslint)

---
updated-dependencies:
- dependency-name: typescript-eslint
  dependency-version: 8.65.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@eslint-react/eslint-plugin](https://github.com/Rel1cx/eslint-react/tree/HEAD/plugins/eslint-plugin) from 5.16.1 to 5.18.0.
- [Release notes](https://github.com/Rel1cx/eslint-react/releases)
- [Changelog](https://github.com/Rel1cx/eslint-react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/Rel1cx/eslint-react/commits/v5.18.0/plugins/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@eslint-react/eslint-plugin"
  dependency-version: 5.17.3
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [oxfmt](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxfmt) from 0.59.0 to 0.61.0.
- [Release notes](https://github.com/oxc-project/oxc/releases)
- [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxfmt/CHANGELOG.md)
- [Commits](https://github.com/oxc-project/oxc/commits/oxfmt_v0.61.0/npm/oxfmt)

---
updated-dependencies:
- dependency-name: oxfmt
  dependency-version: 0.61.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* CI: check `routeTree.gen.ts`

* update routeTree.gen.ts

---------

Co-authored-by: Aman Mahajan <amahajan@stratag.com>
Co-authored-by: Aman Mahajan <amahajan@stratag.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 26.1.1 to 26.1.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 26.1.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Re-applies Grafana's aria-hidden additions (originally on the react-18
branch) onto the current upstream tree. Skips the ResizeHandle (upstream
now sets aria-hidden itself) and the removed focus-sink div; retargets the
former ScrollToCell element to its useScrollToPosition successor.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Signed commits report

5 of 230 commits between main and chore/sync-comcast-upstream could not be fully verified:

Commit Author Reason Message
1720c1ad Nicolas Stepien unsigned Publish 7.0.0-beta.57
12fb93e0 Nicolas Stepien unsigned Publish 7.0.0-beta.58
8a76e9e9 Nicolas Stepien unsigned prettier@3.7.4
17d564ba nstepien unsigned 7.0.0-beta.59
aec5523d Nicolas Stepien unsigned 7.0.0-beta.60

This repository requires all commits to be signed. See GitHub docs on commit signature verification.

@cla-assistant

cla-assistant Bot commented Aug 6, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ fastfrwrd
❌ nstepien
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment thread .github/workflows/ci.yml Fixed
Comment thread .github/workflows/publish.yml Fixed
Comment thread .github/workflows/publish.yml Fixed
Comment thread .github/workflows/publish.yml Fixed
Comment thread .github/workflows/publish.yml Fixed
Comment thread .github/workflows/publish.yml Fixed
Comment thread .github/workflows/publish.yml Fixed
Comment thread .github/workflows/update-screenshots.yml Fixed
Comment thread .github/workflows/update-screenshots.yml Fixed
Comment thread .github/workflows/update-screenshots.yml Fixed
fastfrwrd and others added 3 commits August 10, 2026 10:09
Rides upstream's npm/tsdown/Node-26 tooling and layers only the
Grafana publishing delta on top:

- Rename package to @grafana/react-data-grid, add publishConfig, and
  point homepage/bugs/repository at the Grafana fork.
- Add a version-gated publish job to ci.yml that auto-publishes to npm
  via trusted publishing on pushes to main when package.json version
  changes (EndBug/version-check), then tags and creates a release.
- Remove Comcast-specific tooling that should not run in the fork: the
  gh-pages deploy step (hardcoded Comcast repo URL), publish.yml, and
  update-screenshots.yml.
- Assign CODEOWNERS to dataviz-squad and note the fork in the README.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Grafana's zizmor ruleset (required on the default branch) rejects
upstream's workflows. This makes our end-state ci.yml compliant:

- Pin every action to a full commit SHA (unpinned-uses blanket policy):
  actions/checkout, actions/setup-node, actions/upload-artifact,
  codecov/codecov-action (EndBug/version-check was already pinned).
- Add an explicit top-level 'permissions: contents: read'; the publish
  job keeps its own contents:write + id-token:write.
- persist-credentials: false on the test checkout (it never pushes).

The other zizmor failures (code injection in publish.yml and
update-screenshots.yml) are already resolved by deleting those Comcast
workflows in this branch; the removed gh-pages step dropped another.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Republish as @grafana/react-data-grid from main: auto-height (Comcast#4040), a11y, npm publishing
@fastfrwrd fastfrwrd changed the title Sync main with Comcast upstream (a88517cc8) Sync with Comcast upstream and republish @grafana/react-data-grid (auto-height, a11y, npm publishing) Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants