FE-538: Entity sidebar (read-only) by lunelson · Pull Request #24 · hashintel/brunch

lunelson · 2026-04-03T18:24:01Z

feat: entity sidebar with TanStack Query (FE-538)

Read-only sidebar shows observer-extracted decisions and assumptions
in categorized tabs. TanStack Query manages entity state; cache
invalidated on chat stream completion (status transition). Entities
API endpoint at GET /api/projects/:id/entities.

149 tests (2 new), all pass.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

traceability: slice 6 done — I23 established, A21 partially validated

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

refactor: derive observer JSON schema from Zod via toJSONSchema

Eliminates 30 lines of hand-written JSON schema that duplicated
the Zod observerOutputSchema. Single source of truth.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

refactor: remove deprecated formatHistory, update tests to use buildInterviewerContext

Eliminates core.ts → context.ts import. Tests now directly assert
buildInterviewerContext output instead of comparing against a wrapper.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

refactor: remove unused queryClient export from main.tsx

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

refactor: remove createTranslator from sse-adapter

SDK stream → DomainEvent translation now lives in sdk.ts
(createStreamTranslator). The sse-adapter only handles
DomainEvent → AIEvent via createDomainAdapter.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

chore: update test coverage table after refactor

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

fix: invalidate router after stream to show TurnCard

Without this, the ask_question tool persists options to DB but the
route loader data is stale — TurnCard never appears.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

linear · 2026-04-03T18:24:06Z

FE-538 Entity sidebar (read-only)

React sidebar showing accumulated entities by type: scope items, requirements, decisions, assumptions. Updates live via data-entities SSE events. Read-only.

lunelson · 2026-04-03T18:24:30Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

augmentcode · 2026-04-07T15:34:14Z

🤖 Augment PR Summary

Summary: This PR adds a read-only “Entity Sidebar” to the interview workspace, backed by a new entities API and TanStack Query for client-side state.

Changes:

Introduced EntitySidebar UI with tabbed views for Decisions and Assumptions.
Added TanStack Query (@tanstack/react-query) and wrapped the app in QueryClientProvider.
Added GET /api/projects/:id/entities to return persisted decisions/assumptions for a project.
Updated InterviewWorkspace layout to include the sidebar and to refresh entities/route data when chat streaming completes.
Added API tests covering the new entities endpoint (empty project + invalid ID).
Refactored observer structured-output schema generation to derive JSON schema from Zod via toJSONSchema.
Removed deprecated formatHistory wrapper and cleaned up SSE adapter translator/test surface area.

Technical Notes: Entity updates are driven by React Query invalidation on chat status transition (streaming → ready), rather than in-band data-part syncing.

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 4 suggestions posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-04-07T15:34:15Z

+
+export function EntitySidebar({ projectId }: { projectId: number }) {
+  const [activeTab, setActiveTab] = useState<Tab>('Decisions');
+  const { data, isLoading } = useEntities(projectId);


src/client/components/EntitySidebar.tsx:31: useEntities failures aren’t surfaced, so a network/500 error will render the “No decisions/assumptions yet” empty state and silently mask the problem. Consider rendering an explicit error state using isError/error from React Query so users can distinguish “no entities” from “failed to load”.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode · 2026-04-07T15:34:16Z


+  // Get entities for a project
+  app.get('/api/projects/:id/entities', (req: Request, res: Response) => {
+    const id = Number(req.params.id);


src/server/app.ts:93: Number(req.params.id) will accept values like "1.5" and "-1" (not NaN), which can lead to confusing behavior when treated as a DB identifier. Consider validating that the project ID is a positive integer before querying.

Severity: low

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode · 2026-04-07T15:34:16Z

+      res.status(400).json({ error: 'Invalid project ID' });
+      return;
+    }
+    res.json(getEntitiesForProject(db, id));


src/server/app.ts:98: /api/projects/:id/entities returns {decisions: [], assumptions: []} even when the project doesn’t exist, whereas /api/projects/:id returns 404 for unknown projects. This can cause the UI to cache an “empty” entities response for a typo’d ID and hide a real not-found condition.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode · 2026-04-07T15:34:16Z

-          },
-          required: ['decisions', 'assumptions'],
-        },
+        schema: toJSONSchema(observerOutputSchema),


src/server/observer.ts:85: toJSONSchema(observerOutputSchema) may emit JSON Schema features (e.g., $ref/$defs or non-OpenAI/Anthropic-compatible keywords) depending on Zod’s generator defaults. Since this only fails at runtime when calling query, consider ensuring the generated schema is accepted by the Claude structured-output implementation (and ideally covered by a test/assertion).

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

lunelson · 2026-04-07T16:18:21Z

Merge activity

Apr 7, 4:18 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Apr 7, 4:20 PM UTC: Graphite rebased this pull request as part of a merge.
Apr 7, 4:20 PM UTC: @lunelson merged this pull request with Graphite.

Read-only sidebar shows observer-extracted decisions and assumptions in categorized tabs. TanStack Query manages entity state; cache invalidated on chat stream completion (status transition). Entities API endpoint at GET /api/projects/:id/entities. 149 tests (2 new), all pass. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Eliminates 30 lines of hand-written JSON schema that duplicated the Zod observerOutputSchema. Single source of truth. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…nterviewerContext Eliminates core.ts → context.ts import. Tests now directly assert buildInterviewerContext output instead of comparing against a wrapper. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

SDK stream → DomainEvent translation now lives in sdk.ts (createStreamTranslator). The sse-adapter only handles DomainEvent → AIEvent via createDomainAdapter. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Without this, the ask_question tool persists options to DB but the route loader data is stale — TurnCard never appears. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

This was referenced Apr 3, 2026

FE-537: Observer agent + entity persistence #23

Merged

FE-559: Migrate: @anthropic-ai/claude-agent-sdk query() -> @anthropic-ai/sdk client.messages.stream() #25

Merged

FE-564: Flexible turn-response model #27

Merged

lunelson changed the title ~~feat: entity sidebar with TanStack Query (FE-538)~~ FE-538: Entity sidebar (read-only) Apr 7, 2026

lunelson marked this pull request as ready for review April 7, 2026 15:30

augmentcode Bot reviewed Apr 7, 2026

View reviewed changes

lunelson mentioned this pull request Apr 7, 2026

FE-566: Generic knowledge layer schema and sidebar projection #28

Merged

lunelson changed the base branch from ln/fe-537-observer-agent to graphite-base/24 April 7, 2026 16:18

lunelson changed the base branch from graphite-base/24 to main April 7, 2026 16:18

lunelson and others added 6 commits April 7, 2026 16:19

traceability: slice 6 done — I23 established, A21 partially validated

f485d71

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

refactor: derive observer JSON schema from Zod via toJSONSchema

24fd5da

Eliminates 30 lines of hand-written JSON schema that duplicated the Zod observerOutputSchema. Single source of truth. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

refactor: remove unused queryClient export from main.tsx

4e81e89

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

refactor: remove createTranslator from sse-adapter

62c3d07

SDK stream → DomainEvent translation now lives in sdk.ts (createStreamTranslator). The sse-adapter only handles DomainEvent → AIEvent via createDomainAdapter. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

lunelson and others added 2 commits April 7, 2026 16:19

chore: update test coverage table after refactor

4a60145

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: invalidate router after stream to show TurnCard

b5d22c2

Without this, the ask_question tool persists options to DB but the route loader data is stale — TurnCard never appears. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

lunelson force-pushed the ln/fe-538-entity-sidebar branch from c52f35c to b5d22c2 Compare April 7, 2026 16:19

lunelson merged commit f9ce445 into main Apr 7, 2026
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FE-538: Entity sidebar (read-only)#24

FE-538: Entity sidebar (read-only)#24
lunelson merged 8 commits into
mainfrom
ln/fe-538-entity-sidebar

lunelson commented Apr 3, 2026

Uh oh!

linear Bot commented Apr 3, 2026

Uh oh!

lunelson commented Apr 3, 2026 •

edited

Loading

Uh oh!

augmentcode Bot commented Apr 7, 2026

Uh oh!

augmentcode Bot left a comment

Uh oh!

augmentcode Bot Apr 7, 2026

Uh oh!

augmentcode Bot Apr 7, 2026

Uh oh!

augmentcode Bot Apr 7, 2026

Uh oh!

augmentcode Bot Apr 7, 2026

Uh oh!

lunelson commented Apr 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

lunelson commented Apr 3, 2026

Uh oh!

linear Bot commented Apr 3, 2026

Uh oh!

lunelson commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

augmentcode Bot commented Apr 7, 2026

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

lunelson commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

lunelson commented Apr 3, 2026 •

edited

Loading

lunelson commented Apr 7, 2026 •

edited

Loading