FE-542: Criteria-review mode

[lunelson]

feat: criteria grounding in approved requirements and first criterion round-trip through observer persistence

Amp-Thread-ID: https://ampcode.com/threads/T-019d762a-383e-77bb-a53e-d9c8768dceaf
Co-authored-by: Amp amp@ampcode.com

docs: mark slice 10.1 done, add I97 criteria-review grounding invariant

Amp-Thread-ID: https://ampcode.com/threads/T-019d762a-383e-77bb-a53e-d9c8768dceaf
Co-authored-by: Amp amp@ampcode.com

feat: explicit criterion review state and minimal criteria closeability

Amp-Thread-ID: https://ampcode.com/threads/T-019d76c6-3181-71a8-9d32-1e546f5a0f17
Co-authored-by: Amp amp@ampcode.com

docs: traceability for slice 10.2 — criterion review state and closeability

Amp-Thread-ID: https://ampcode.com/threads/T-019d76c6-3181-71a8-9d32-1e546f5a0f17
Co-authored-by: Amp amp@ampcode.com

feat: criteria closure and completed workflow state verification

Amp-Thread-ID: https://ampcode.com/threads/T-019d76c6-3181-71a8-9d32-1e546f5a0f17
Co-authored-by: Amp amp@ampcode.com

docs: traceability for slice 10.3 — criteria closure and completed workflow state

Amp-Thread-ID: https://ampcode.com/threads/T-019d76c6-3181-71a8-9d32-1e546f5a0f17
Co-authored-by: Amp amp@ampcode.com

docs: add batch pre-scoping to ln-scope and temporary-document retirement to ln-build

Amp-Thread-ID: https://ampcode.com/threads/T-019d76c6-3181-71a8-9d32-1e546f5a0f17
Co-authored-by: Amp amp@ampcode.com

chore: retire memory/CARDS.md — all slice 10 cards built

Amp-Thread-ID: https://ampcode.com/threads/T-019d76c6-3181-71a8-9d32-1e546f5a0f17
Co-authored-by: Amp amp@ampcode.com

docs: refactor plan — unify review seam duplication

Amp-Thread-ID: https://ampcode.com/threads/T-019d76c6-3181-71a8-9d32-1e546f5a0f17
Co-authored-by: Amp amp@ampcode.com

refactor: rename review → requirementReview on structuredQuestionSchema

Amp-Thread-ID: https://ampcode.com/threads/T-019d7708-5385-70ab-bb6e-9d9d10a0632f
Co-authored-by: Amp amp@ampcode.com

refactor: extract shared getReviewStatusesOnActivePath, collapse ReviewStatus type

Amp-Thread-ID: https://ampcode.com/threads/T-019d7708-5385-70ab-bb6e-9d9d10a0632f
Co-authored-by: Amp amp@ampcode.com

refactor: extract shared getReviewFromTurn, remove per-kind extraction functions

Amp-Thread-ID: https://ampcode.com/threads/T-019d7708-5385-70ab-bb6e-9d9d10a0632f
Co-authored-by: Amp amp@ampcode.com

refactor: extract shared recordReviewFromTurnResponse, remove per-kind recording functions

Amp-Thread-ID: https://ampcode.com/threads/T-019d7708-5385-70ab-bb6e-9d9d10a0632f
Co-authored-by: Amp amp@ampcode.com

refactor: extract shared validateReviewOptionPosition in structuredQuestionSchema superRefine

Amp-Thread-ID: https://ampcode.com/threads/T-019d7708-5385-70ab-bb6e-9d9d10a0632f
Co-authored-by: Amp amp@ampcode.com

chore: retire completed review-seam refactor plan

Amp-Thread-ID: https://ampcode.com/threads/T-019d7708-5385-70ab-bb6e-9d9d10a0632f
Co-authored-by: Amp amp@ampcode.com

chore: ln-sync — update coverage counts, refresh parallelism notes after review-seam refactor

Amp-Thread-ID: https://ampcode.com/threads/T-019d7708-5385-70ab-bb6e-9d9d10a0632f
Co-authored-by: Amp amp@ampcode.com

[linear]

FE-542 Criteria-review mode

Synthesize verification conditions from approved requirements plus earlier criteria-like signals, then drive review turns until coverage is complete.

Acceptance

• Criteria-review presents synthesized criteria
• Explicit review state is recorded
• The phase closes only when approved requirements have sufficient verification coverage

[lunelson]

• FE-580: Collapse remaining shared transport and review-status type duplication #45
• FE-579: Greenfield/brownfield first-screen + exploration #44
• FE-545: Local-first storage; npx distribution #43
• FE-578: UI refinements; design adaptations & alignments #42
• FE-543: Expanded rich fixture scenarios + reviews + replannings #41
• FE-574: Knowledge workspace review surface + lifecycle API #39
• FE-573: Project dashboard workflow state #38
• FE-542: Criteria-review mode #37 👈 (View in Graphite)
• FE-568: Requirements-review mode #36
• FE-540: Design mode: commitment and exploration #35
• FE-572: Canonical knowledge model foundation + cutover seam #34
• FE-539: Explicit phase outcomes and scope closure #33
• FE-567: Phase-aware observer extraction #32
• FE-566: Generic knowledge layer schema and sidebar projection #28
• FE-564: Flexible turn-response model #27
• FE-559: Migrate: @anthropic-ai/claude-agent-sdk query() -> @anthropic-ai/sdk client.messages.stream() #25
• FE-538: Entity sidebar (read-only) #24
• FE-537: Observer agent + entity persistence #23
• FE-558: UI foundation: shadcn/ui + Tailwind 4 + AI Elements #22
• FE-557: Spike: observer extraction fidelity #21
• FE-556: Structured interview: client UI #20
• FE-555: Parts-based persistence + context builders #19
• FE-554: Structured interview: scope phase #17
• FE-553: Multi-project routing #16
• FE-541: Rich chat UI with tool calls and reasoning rendering #15
• FE-552: Drizzle ORM and core extraction #14
• FE-544: Turn tree schema and API #13
• FE-535: SQLite foundation and project persistence #11
• FE-534: Walking skeleton SDK to SSE to React #10
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[augmentcode]

🤖 Augment PR Summary

Summary: Adds end-to-end “criteria-review mode” after requirements close, including grounding criteria turns in approved requirements, persisting explicit criterion review state, and supporting final criteria closure.

Changes:

• Ground criteria interviewer context in the approved requirement inventory and add tests verifying the first criteria turn stays in criteria mode and can round-trip criterion persistence.
• Introduce criterion review metadata in the structured question schema and reuse the existing response seam to record approve/reject actions.
• Project per-criterion reviewStatus (approved/rejected/pending) from latest active-path actions and derive criteria closeability from full review coverage.
• Enable proposing and confirming criteria phase closure via the shared phase-close transport, and verify completed-workflow projection (no stale active phase).
• Refactor shared review utilities (extraction/validation/recording) to support both requirement and criterion review kinds.

Technical Notes: Criteria closeability is now computed from explicit criterion review coverage; interviewer context building and DB projection paths were expanded and covered with new integration tests.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

structuredQuestionSchema currently allows both requirementReview and criterionReview to be present on the same question, and /turns/:turnId/response will attempt to record both. Consider enforcing mutual exclusivity here to avoid unintended cross-kind review persistence if a malformed tool payload includes both fields.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[lunelson]

Merge activity

• Apr 12, 12:28 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Apr 12, 12:28 PM UTC: @lunelson merged this pull request with Graphite.