Skip to content

FE-580: Collapse remaining shared transport and review-status type duplication#45

Merged
lunelson merged 17 commits into
mainfrom
ln/fe-580-shared-type-cleanup
Apr 12, 2026
Merged

FE-580: Collapse remaining shared transport and review-status type duplication#45
lunelson merged 17 commits into
mainfrom
ln/fe-580-shared-type-cleanup

Conversation

@lunelson
Copy link
Copy Markdown
Contributor

refactor: collapse remaining shared transport and review-status types

chore: remove unused packages and add provider utils

chore: clear verification warnings

@linear
Copy link
Copy Markdown

linear Bot commented Apr 12, 2026

This was referenced Apr 12, 2026
Copy link
Copy Markdown
Contributor Author

lunelson commented Apr 12, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lunelson lunelson changed the title refactor: collapse remaining shared transport and review-status types FE-580: Collapse remaining shared transport and review-status type duplication Apr 12, 2026
@lunelson lunelson marked this pull request as ready for review April 12, 2026 16:52
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Apr 12, 2026

🤖 Augment PR Summary

Summary: This PR reduces duplication between shared transport types and review/workflow status types across the client and server.

Changes:

  • Introduces a Node bin wrapper (bin/brunch.js) so the published brunch command runs the TS CLI via tsx, and adds a basic --help mode.
  • Tightens the create-project API contract by making createProjectRequestSchema strict and rejecting client-supplied cwd (server-side + tests).
  • Unifies entity / workflow / review-related types by reusing schemas from src/shared/api-types.ts and adding runtime parsing (e.g. entitiesDataSchema on refresh).
  • Makes export loader data a discriminated union so markdown is required when ready: true, updating UI logic and tests accordingly.
  • Refines brownfield tooling: exploration tools/instructions are limited to the scope phase and remain read-only.
  • Improves launcher static serving with a dedicated mountStaticClient helper and adds runtime DB path normalization via resolveConfiguredDbPath.

Technical Notes: Several tests were updated/added to validate stricter schema parsing, read-only tool exposure, and SPA/static serving behavior.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/server/launcher.ts
}

app.use(express.static(distDir));
app.use((req, res, next) => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/server/launcher.ts:19 — This SPA fallback middleware will also serve index.html for requests like missing static assets (e.g. a bad chunk filename) and for non-GET methods, which can mask real 404s and lead to confusing runtime failures.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Copy link
Copy Markdown
Contributor Author

lunelson commented Apr 12, 2026

Merge activity

  • Apr 12, 5:03 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 12, 5:10 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 12, 5:11 PM UTC: @lunelson merged this pull request with Graphite.

@lunelson lunelson changed the base branch from ln/fe-579-codebase-exploration to graphite-base/45 April 12, 2026 17:08
@lunelson lunelson changed the base branch from graphite-base/45 to main April 12, 2026 17:09
@lunelson lunelson force-pushed the ln/fe-580-shared-type-cleanup branch from c3e23f0 to b200022 Compare April 12, 2026 17:10
@lunelson lunelson merged commit 10385ff into main Apr 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant