FE-580: Collapse remaining shared transport and review-status type duplication#45
Merged
Conversation
This was referenced Apr 12, 2026
Contributor
Author
🤖 Augment PR SummarySummary: This PR reduces duplication between shared transport types and review/workflow status types across the client and server. Changes:
Technical Notes: Several tests were updated/added to validate stricter schema parsing, read-only tool exposure, and SPA/static serving behavior. 🤖 Was this summary useful? React with 👍 or 👎 |
| } | ||
|
|
||
| app.use(express.static(distDir)); | ||
| app.use((req, res, next) => { |
There was a problem hiding this comment.
src/server/launcher.ts:19 — This SPA fallback middleware will also serve index.html for requests like missing static assets (e.g. a bad chunk filename) and for non-GET methods, which can mask real 404s and lead to confusing runtime failures.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Contributor
Author
c3e23f0 to
b200022
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

refactor: collapse remaining shared transport and review-status types
chore: remove unused packages and add provider utils
chore: clear verification warnings