FE-539: Explicit phase outcomes and scope closure by lunelson · Pull Request #33 · hashintel/brunch

lunelson · 2026-04-08T19:49:53Z

No description provided.

linear · 2026-04-08T19:49:56Z

FE-539 Explicit phase outcomes and scope closure

Replace pure is_resolution semantics with explicit phase outcomes and user-confirmed scope closure. Scope mode closes when framing sufficiency is reached, not just when the model feels done.

Acceptance

Scope mode proposes closure with a summary
User confirms
Explicit phase outcome persists
The project shows updated workflow state

FE-567 Phase-aware observer extraction

Teach the observer to bias extraction by interview mode: scope prefers framing and constraints, design prefers decisions and assumptions, and later modes surface requirements, criteria, and revisions.

Acceptance

Scope turns primarily yield framing and constraints
Design turns primarily yield decisions and assumptions
Observer results still stream in-band to the sidebar

lunelson · 2026-04-08T19:50:32Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

augmentcode · 2026-04-09T12:33:24Z

🤖 Augment PR Summary

Summary: This PR replaces implicit “resolution” semantics for scope with an explicit, persisted phase-outcome/readiness record and a user-confirmed closure flow.

Changes:

Adds a new phase_outcome table + migration to persist proposed/confirmed/superseded outcomes per project/phase.
Extends server DB utilities to create/confirm outcomes, reconcile/supersede them when the active path changes, and project a per-phase workflow state.
Updates GET /api/projects/:id to include projected workflow alongside turns.
Adds a new interviewer tool (propose_phase_closure) and shared Zod schemas for proposal output and data-phase-summary parts.
Updates POST /api/projects/:id/chat to accept typed data-confirmation user parts, confirm a proposed outcome, and emit a typed data-phase-summary when a proposal is created.
Updates the workspace controller/UI to show scope workflow status in the header, render a scope-closure confirmation card, and submit confirmations via typed chat parts.
Adds server and client tests covering proposal streaming, confirmation persistence, workflow projection, and supersession on upstream path changes.

Technical Notes: Workflow readiness is derived from the latest non-superseded outcome whose proposal turn remains on the active path; confirmations are carried through the same chat transport via typed data parts for durable replay/hydration.

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 4 suggestions posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-04-09T12:33:25Z

    observerResultPartSchema,
    phaseSummaryPartSchema,
    askQuestionToolPartSchema,
+    proposePhaseClosureToolPartSchema,


src/shared/chat.ts:295 — assistantPartsSchema now accepts tool-propose_phase_closure, but BrunchAssistantPart (used for persisted assistant parts elsewhere) doesn’t include that variant, so the code relies on unsafe casts and downstream handling may silently ignore this new tool part.

Severity: low

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode · 2026-04-09T12:33:25Z

+    execute: async (input) => {
+      createPhaseOutcome(db, {
+        projectId,
+        phase: input.phase,


src/server/interview.ts:111 — createProposePhaseClosureTool() receives the current phase but persists phase: input.phase, so a malformed/LLM-mistaken tool call could write a phase outcome for a different phase than the turn’s actual mode.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode · 2026-04-09T12:33:25Z

+
+      void sendMessage({
+        parts: [
+          { type: 'text', text: 'Confirm scope closure' },


src/client/workspace/workspace-controller.ts:113 — confirmPhaseClosure() hardcodes the text "Confirm scope closure" even though data-phase-summary includes a phase; if a non-scope closure is ever proposed (or the model emits the wrong phase), the UI/confirmation text will be misleading while still confirming the proposal by turnId.

Severity: medium

Other Locations

src/client/routes/InterviewWorkspace.tsx:64

src/client/routes/InterviewWorkspace.tsx:78

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode · 2026-04-09T12:33:25Z

-      ? { kind: 'persisted-turn', turn: lastTurn }
+  const latestPhaseSummary = findPhaseSummary(messages);
+  const phaseSummary =
+    latestPhaseSummary && (isLoading || workflow.phases[latestPhaseSummary.phase].status === 'proposed')


src/client/workspace/workspace-controller-core.ts:284 — phaseSummary is shown only while isLoading or when workflow.phases[phase].status === 'proposed', which can briefly hide the confirmation card after streaming ends but before router.invalidate() refreshes workflow, causing a flicker/momentary prompt re-enable.

Severity: low

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

lunelson · 2026-04-10T11:44:54Z

Merge activity

Apr 10, 11:44 AM UTC: A user started a stack merge that includes this pull request via Graphite.
Apr 10, 11:47 AM UTC: Graphite rebased this pull request as part of a merge.
Apr 10, 11:48 AM UTC: @lunelson merged this pull request with Graphite.

…design

This was referenced Apr 8, 2026

FE-567: Phase-aware observer extraction #32

Merged

FE-572: Canonical knowledge model foundation + cutover seam #34

Merged

lunelson changed the title ~~docs: re-sequence phase 5 and 6 around scope closure and knowledge redesign~~ FE-567: Explicit phase outcomes + scope closure Apr 9, 2026

lunelson changed the title ~~FE-567: Explicit phase outcomes + scope closure~~ FE-539: Explicit phase outcomes + scope closure Apr 9, 2026

lunelson marked this pull request as ready for review April 9, 2026 12:29

augmentcode Bot reviewed Apr 9, 2026

View reviewed changes

This was referenced Apr 10, 2026

FE-540: Design mode: commitment and exploration #35

Merged

FE-568: Requirements-review mode #36

Merged

lunelson changed the title ~~FE-539: Explicit phase outcomes + scope closure~~ FE-539: Explicit phase outcomes and scope closure Apr 10, 2026

lunelson mentioned this pull request Apr 10, 2026

FE-542: Criteria-review mode #37

Merged

lunelson changed the base branch from ln/fe-567-phase-aware-observer-extraction to graphite-base/33 April 10, 2026 11:45

lunelson changed the base branch from graphite-base/33 to main April 10, 2026 11:46

lunelson added 5 commits April 10, 2026 11:47

docs: re-sequence phase 5 and 6 around scope closure and knowledge re…

7e090b6

…design

design notes update

b250e1b

typescript and react pattern reviews

545d3fd

feat: explicit phase outcomes + scope closure

5b4fcd2

docs: sync slice 7 traceability

d041872

lunelson force-pushed the ln/fe-539-explicit-phase-outcomes-scope-closure branch from 8dce4a8 to d041872 Compare April 10, 2026 11:47

lunelson merged commit ccf100e into main Apr 10, 2026
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FE-539: Explicit phase outcomes and scope closure#33

FE-539: Explicit phase outcomes and scope closure#33
lunelson merged 5 commits into
mainfrom
ln/fe-539-explicit-phase-outcomes-scope-closure

lunelson commented Apr 8, 2026

Uh oh!

linear Bot commented Apr 8, 2026 •

edited

Loading

Acceptance

Acceptance

Uh oh!

lunelson commented Apr 8, 2026 •

edited

Loading

Uh oh!

augmentcode Bot commented Apr 9, 2026

Uh oh!

augmentcode Bot left a comment

Uh oh!

augmentcode Bot Apr 9, 2026

Uh oh!

augmentcode Bot Apr 9, 2026

Uh oh!

augmentcode Bot Apr 9, 2026

Uh oh!

augmentcode Bot Apr 9, 2026

Uh oh!

lunelson commented Apr 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

lunelson commented Apr 8, 2026

Uh oh!

linear Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Acceptance

Acceptance

Uh oh!

lunelson commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

augmentcode Bot commented Apr 9, 2026

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

lunelson commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

linear Bot commented Apr 8, 2026 •

edited

Loading

lunelson commented Apr 8, 2026 •

edited

Loading

lunelson commented Apr 10, 2026 •

edited

Loading