FE-540: Design mode: commitment and exploration#35
Conversation
FE-540 Design mode: commitment and exploration
Implement the second workflow mode on the new turn and knowledge model. The interviewer walks design forks; the observer captures decisions, assumptions, new constraints, and emerging requirements. Acceptance
|
🤖 Augment PR SummarySummary: Adds “design mode” as the next workflow phase after confirmed scope closure and unifies the phase-closing seam (recommended close + user-forced close) across workflow phases. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
| if (confirmationPart && !confirmationTarget) { | ||
| const forceClosePhase = | ||
| phaseClosureCommand?.kind === 'force-close-active-phase' ? phaseClosureCommand.phase : undefined; | ||
| const confirmationTarget = |
There was a problem hiding this comment.
src/server/app.ts:199-202 — The phase in the confirm-proposed-phase-closure payload isn’t validated/used when resolving confirmationTarget (lookup is only by proposalTurnId). This allows mismatched phase vs proposal metadata and makes the extra field effectively untrusted/inconsistent if a client sends a crafted payload.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
|
|
||
| function getWorkflowMetaLabel(state: WorkflowPhaseState) { | ||
| const parts = [`${state.readiness[0].toUpperCase() + state.readiness.slice(1)} readiness`]; | ||
| parts.push(state.closeability ? 'Closeable now' : 'Not yet closeable'); |
There was a problem hiding this comment.
src/client/routes/InterviewWorkspace.tsx:61 — getWorkflowMetaLabel will show “Not yet closeable” for phases whose status is closed (since closeability is false once closed), which is misleading user-facing state. This could confuse users reviewing already-closed phases in the header.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
1e022da to
4dee0a5
Compare

feat: enter design mode after scope closure
feat: enable design phase closure proposals
feat: support user-forced design closure
add figma captures to design notes
feat: extract phase-close command vocabulary
feat: project shared force-close availability
feat: persist phase-outcome closure basis
feat: cut workflow projection over to durable closure basis
feat: ship explicit phase-close command union
feat: deepen the shared phase-close module
cleanup and sync