FE-572: Canonical knowledge model foundation + cutover seam by lunelson · Pull Request #34 · hashintel/brunch

lunelson · 2026-04-09T09:13:36Z

No description provided.

linear · 2026-04-09T09:13:40Z

FE-572 Spike: knowledge-layer redesign ontology, graph, and workspace direction

Summary

Run slice 7a as a time-boxed redesign spike to specify the canonical brunch knowledge model before Phase 5/6 review slices harden the transitional Phase 4 seam.

Question

What should the canonical knowledge-layer design be for:

durable ontology (goal, term, context, constraint, assumption, decision, requirement, criterion)
cross-kind graph/edge model
storage direction (unified generic model vs continued mixed legacy/generic seam)
primary review/workspace shape beyond the current sidebar summary UI

Constraints

Preserve slice 7's new phase_outcome readiness architecture unless the spike finds a compelling incompatibility
Do not harden the current framing-based mixed legacy/generic seam into the long-term model
Produce a migration direction that gates slices 8–10 and 12 without invalidating already-landed closure mechanics

Expected output

Spike verdict with evidence from current code/docs
Recommended target ontology, graph, storage, and workspace direction
Traceability updates in memory/SPEC.md and memory/PLAN.md
Follow-on recommendation for the first scoped implementation slice

lunelson · 2026-04-09T09:14:03Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

augmentcode · 2026-04-09T12:36:06Z

🤖 Augment PR Summary

Summary: This PR lays the foundation for a canonical knowledge model and an explicit cutover seam away from the legacy “framing”/commitment storage.

Changes:

Introduces canonical knowledge kinds goal, term, and context (replacing durable framing usage in the UI and observer flow).
Updates the shared knowledge-kind registry and the client sidebar tabs to render the new collections.
Widens the observer schema and prompts to extract canonical scope kinds in scope mode and allow scope-kind corrections in later modes.
Cuts over decisions/assumptions persistence to the generic knowledge_item seam while keeping kind-specific collections as compatibility projections.
Adds a generic knowledge_edge table and switches dependency projection to read from it.
Extends the entities API (/api/projects/:id/entities) to return goals/terms/contexts plus relationships from knowledge_edge.
Adds a scope-bundle projection helper intended to preserve slice-7 closure semantics during the cutover.
Updates server/client tests and planning/spec docs to reflect the new ontology and seam.

Technical Notes: Dependency edges are now stored in knowledge_edge; decisions/assumptions are stored in knowledge_item and projected as dedicated collections for API/UI stability.

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

augmentcode

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-04-09T12:37:02Z

+  toItemId: number,
+  relation: InferSelectModel<typeof schema.knowledgeEdge>['relation'],
+): void {
+  db.insert(schema.knowledgeEdge).values({ from_item_id: fromItemId, to_item_id: toItemId, relation }).run();


addKnowledgeEdge() will persist edges to any existing knowledge_item IDs, but nothing here enforces that toItemId belongs to the same project_id as fromItemId. If the observer outputs an ID from another project that happens to exist, this can create cross-project edges that won’t show up in projections but will remain in the DB.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-04-09T12:37:08Z

+  return 'knowledge_item';
+}
+
+export function getScopeBundleForProject(db: DB, projectId: number) {


getScopeBundleForProject() currently reads all items of each kind for the project, ignoring turn_knowledge_item provenance / active-path semantics. If turn-tree revisit/branching is in play, this can mix off-path/stale scope items into the scope bundle used for closure/readiness.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-04-09T12:37:56Z

 /** Schema for observer structured output. */
 export const observerOutputSchema = z.object({
-  framing: z.array(
+  goals: z.array(


In this widened observerOutputSchema, the dependency ID fields (parentDecisionIds/parentAssumptionIds below) are still validated as unconstrained numbers, so floats/negatives/hallucinated IDs can make it through parsing and then fail at FK/PK insert time. Tightening validation (and/or ignoring unknown IDs) would make observer runs less brittle to model output quirks.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

lunelson · 2026-04-10T11:44:54Z

Merge activity

Apr 10, 11:44 AM UTC: A user started a stack merge that includes this pull request via Graphite.
Apr 10, 11:49 AM UTC: Graphite rebased this pull request as part of a merge.
Apr 10, 11:50 AM UTC: @lunelson merged this pull request with Graphite.

This was referenced Apr 9, 2026

FE-567: Phase-aware observer extraction #32

Merged

FE-539: Explicit phase outcomes and scope closure #33

Merged

lunelson changed the title ~~feat: cut over scope knowledge to canonical goal term context kinds~~ FE-572: Canonical knowledge model foundation + cutover seam Apr 9, 2026

lunelson marked this pull request as ready for review April 9, 2026 12:30

augmentcode Bot reviewed Apr 9, 2026

View reviewed changes

This was referenced Apr 10, 2026

FE-540: Design mode: commitment and exploration #35

Merged

FE-568: Requirements-review mode #36

Merged

lunelson mentioned this pull request Apr 10, 2026

FE-542: Criteria-review mode #37

Merged

lunelson changed the base branch from ln/fe-539-explicit-phase-outcomes-scope-closure to graphite-base/34 April 10, 2026 11:47

lunelson changed the base branch from graphite-base/34 to main April 10, 2026 11:48

lunelson added 4 commits April 10, 2026 11:49

feat: cut over scope knowledge to canonical goal term context kinds

327e2b0

docs update, re: adjusted phase closure logic, lexicon etc

ad7fd4a

feat: cut over commitments and edges to the generic knowledge seam

e7b2bc7

more design note captures

24f084f

lunelson force-pushed the ln/fe-572-spike-knowledge-ontology branch from 45a362f to 24f084f Compare April 10, 2026 11:49

lunelson merged commit e78233e into main Apr 10, 2026
2 checks passed

Conversation

lunelson commented Apr 9, 2026

Uh oh!

linear Bot commented Apr 9, 2026

Summary

Question

Constraints

Expected output

Uh oh!

lunelson commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

augmentcode Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

lunelson commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

lunelson commented Apr 9, 2026 •

edited

Loading

augmentcode Bot commented Apr 9, 2026 •

edited

Loading

lunelson commented Apr 10, 2026 •

edited

Loading