Don't include position in binary valve attributes #107531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
has-tests
integration: valve
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
MartinHjelmare
requested changes
Jan 8, 2024
| """Return the state attributes.""" | ||
|
|
||
| if not self.reports_position: | ||
| return None |
There was a problem hiding this comment.
Nowadays we always want to include all state attribute items. When a value isn't known it's set to None.
There was a problem hiding this comment.
Yes, but does that apply for an entity which doesn't support some state attribute item?
There was a problem hiding this comment.
Maybe you're right that it's not expected to be there if it's not supported.
home-assistant/architecture#680
Although with supported features possibly changing during entity lifetime, the case is a bit muddy.
There was a problem hiding this comment.
That is a muddy case indeed, but assumingly that is a less commonly happening. But something to discuss for sure 👍
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
frenck
approved these changes
Jan 12, 2024
frenck
pushed a commit
that referenced
this pull request
Jan 12, 2024
Merged
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Jan 13, 2024
…to v2024.1.3 (#305) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/home-assistant/home-assistant](https://www.home-assistant.io/) ([source](https://github.com/home-assistant/core)) | patch | `2024.1.2` -> `2024.1.3` | --- ### Release Notes <details> <summary>home-assistant/core (ghcr.io/home-assistant/home-assistant)</summary> ### [`v2024.1.3`](https://github.com/home-assistant/core/releases/tag/2024.1.3) [Compare Source](home-assistant/core@2024.1.2...2024.1.3) - Add diagnostics to A. O. Smith integration ([@​bdr99] - [#​106343]) ([aosmith docs]) - Catch missing inverter in Enphase Envoy ([@​catsmanac] - [#​106730]) ([enphase_envoy docs]) - Prevent toggle from calling stop on covers which do not support it ([@​vexofp] - [#​106848]) ([cover docs]) - Fix missing unique_id for spt integration ([@​miaucl] - [#​107087]) ([swiss_public_transport docs]) - Add support for the Spotify DJ ([@​BTMorton] - [#​107268]) ([spotify docs]) - Fix evohome high_precision temps not retreived consistently ([@​zxdavb] - [#​107366]) ([evohome docs]) - Reduce polling rate in Blink ([@​mkmer] - [#​107386]) ([blink docs]) - Fix KNX telegram device trigger not firing after integration reload ([@​farmio] - [#​107388]) ([knx docs]) - Fix language flavors in holiday ([@​gjohansson-ST] - [#​107392]) ([holiday docs]) - Handle OSError during setup for System Monitor ([@​gjohansson-ST] - [#​107396]) ([systemmonitor docs]) - Remove name from faa_delays ([@​joostlek] - [#​107418]) ([faa_delays docs]) - Fix Swiss public transport initial data for attributes ([@​miaucl] - [#​107452]) ([swiss_public_transport docs]) - Fix reauth flow for Comelit VEDO ([@​chemelli74] - [#​107461]) ([comelit docs]) - Fix asyncio.gather call ([@​cdce8p] - [#​107500]) ([microsoft_face docs]) - Fix Luftdaten sensor id string ([@​mrueg] - [#​107506]) ([luftdaten docs]) - Bump zm-py version to v0.5.3 for zoneminder ([@​nabbi] - [#​107331]) ([zoneminder docs]) (dependency) - Retry zoneminder connection setup ([@​nabbi] - [#​107519]) ([zoneminder docs]) (dependency) - Don't include position in binary valve attributes ([@​emontnemery] - [#​107531]) ([valve docs]) - Bump blinkpy to 0.22.5 ([@​mkmer] - [#​107537]) ([blink docs]) - Bump reolink_aio to 0.8.6 ([@​starkillerOG] - [#​107541]) ([reolink docs]) (dependency) - Bump mcstatus to v11.1.1 ([@​elmurato] - [#​107546]) ([minecraft_server docs]) (dependency) - Bump aioshelly to 7.1.0 ([@​thecode] - [#​107593]) ([shelly docs]) (dependency) - Fix Tado unique mobile device dispatcher ([@​erwindouna] - [#​107631]) ([tado docs]) - Fix tplink_lte setup ([@​cdce8p] - [#​107642]) ([tplink_lte docs]) - Prevent overriding cached attribute as property ([@​emontnemery] - [#​107657]) - Set max and min temp for flexit_bacnet climate entity ([@​lellky] - [#​107665]) ([flexit_bacnet docs]) - Fix duplicated resource issue in System Monitor ([@​gjohansson-ST] - [#​107671]) ([systemmonitor docs]) - Fix invalid alexa climate or water_heater state report with double listed targetSetpoint ([@​jbouwh] - [#​107673]) ([alexa docs]) - Redact sensitive data in alexa debug logging ([@​jbouwh] - [#​107676]) ([alexa docs]) - Fix `device_class` type for Shelly Gen1 sleeping sensors ([@​bieniu] - [#​107683]) ([shelly docs]) - Clamp tplink color temp to valid range ([@​bdraco] - [#​107695]) ([tplink docs]) - Fix cloud tts loading ([@​MartinHjelmare] - [#​107714]) ([cloud docs]) - Allow configuration of min_gradient from UI to be negative in Trend ([@​jpbede] - [#​107720]) ([trend docs]) - Bump aioswitcher to 3.4.1 ([@​YogevBokobza] - [#​107730]) ([switcher_kis docs]) - Fix mqtt text text min max config params can not be equal ([@​jbouwh] - [#​107738]) ([mqtt docs]) - Fix "not-logged" edge cases for Comelit VEDO ([@​chemelli74] - [#​107741]) ([comelit docs]) (dependency) - Fix Mac address check in kef integration ([@​eugenet8k] - [#​107746]) ([kef docs]) - Fix ld2410\_ble not being able to setup because it has a stale connection ([@​bdraco] - [#​107754]) ([ld2410\_ble docs][ld2410_ble docs]) - Bump pyunifiprotect to 4.23.1 ([@​AngellusMortis] - [#​107758]) ([unifiprotect docs]) (dependency) - Bump pyunifiprotect to 4.23.2 ([@​AngellusMortis] - [#​107769]) ([unifiprotect docs]) (dependency) - Rework events for UniFi Protect ([@​AngellusMortis] - [#​107771]) ([unifiprotect docs]) - Fix switcher kis logging incorrect property for device's name ([@​idofl] - [#​107775]) ([switcher_kis docs]) - Bump bluetooth deps ([@​bdraco] - [#​107816]) ([bluetooth docs]) (dependency) - Fix Tailwind cover stuck in closing state ([@​frenck] - [#​107827]) ([tailwind docs]) - Fix for exception in screenlogic.set_color_mode ([@​dieselrabbit] - [#​107850]) ([screenlogic docs]) - Bump aio_geojson_generic_client to 0.4 ([@​exxamalte] - [#​107866]) ([geo_json_events docs]) (dependency) [#​106343]: home-assistant/core#106343 [#​106730]: home-assistant/core#106730 [#​106848]: home-assistant/core#106848 [#​106970]: home-assistant/core#106970 [#​107087]: home-assistant/core#107087 [#​107239]: home-assistant/core#107239 [#​107268]: home-assistant/core#107268 [#​107331]: home-assistant/core#107331 [#​107365]: home-assistant/core#107365 [#​107366]: home-assistant/core#107366 [#​107386]: home-assistant/core#107386 [#​107388]: home-assistant/core#107388 [#​107392]: home-assistant/core#107392 [#​107396]: home-assistant/core#107396 [#​107418]: home-assistant/core#107418 [#​107452]: home-assistant/core#107452 [#​107461]: home-assistant/core#107461 [#​107500]: home-assistant/core#107500 [#​107506]: home-assistant/core#107506 [#​107519]: home-assistant/core#107519 [#​107531]: home-assistant/core#107531 [#​107537]: home-assistant/core#107537 [#​107541]: home-assistant/core#107541 [#​107546]: home-assistant/core#107546 [#​107593]: home-assistant/core#107593 [#​107631]: home-assistant/core#107631 [#​107642]: home-assistant/core#107642 [#​107657]: home-assistant/core#107657 [#​107665]: home-assistant/core#107665 [#​107671]: home-assistant/core#107671 [#​107673]: home-assistant/core#107673 [#​107676]: home-assistant/core#107676 [#​107683]: home-assistant/core#107683 [#​107695]: home-assistant/core#107695 [#​107714]: home-assistant/core#107714 [#​107720]: home-assistant/core#107720 [#​107730]: home-assistant/core#107730 [#​107738]: home-assistant/core#107738 [#​107741]: home-assistant/core#107741 [#​107746]: home-assistant/core#107746 [#​107754]: home-assistant/core#107754 [#​107758]: home-assistant/core#107758 [#​107769]: home-assistant/core#107769 [#​107771]: home-assistant/core#107771 [#​107775]: home-assistant/core#107775 [#​107816]: home-assistant/core#107816 [#​107827]: home-assistant/core#107827 [#​107850]: home-assistant/core#107850 [#​107866]: home-assistant/core#107866 [@​AngellusMortis]: https://github.com/AngellusMortis [@​BTMorton]: https://github.com/BTMorton [@​MartinHjelmare]: https://github.com/MartinHjelmare [@​YogevBokobza]: https://github.com/YogevBokobza [@​bdr99]: https://github.com/bdr99 [@​bdraco]: https://github.com/bdraco [@​bieniu]: https://github.com/bieniu [@​catsmanac]: https://github.com/catsmanac [@​cdce8p]: https://github.com/cdce8p [@​chemelli74]: https://github.com/chemelli74 [@​dieselrabbit]: https://github.com/dieselrabbit [@​elmurato]: https://github.com/elmurato [@​emontnemery]: https://github.com/emontnemery [@​erwindouna]: https://github.com/erwindouna [@​eugenet8k]: https://github.com/eugenet8k [@​exxamalte]: https://github.com/exxamalte [@​farmio]: https://github.com/farmio [@​frenck]: https://github.com/frenck [@​gjohansson-ST]: https://github.com/gjohansson-ST [@​idofl]: https://github.com/idofl [@​jbouwh]: https://github.com/jbouwh [@​joostlek]: https://github.com/joostlek [@​jpbede]: https://github.com/jpbede [@​lellky]: https://github.com/lellky [@​miaucl]: https://github.com/miaucl [@​mkmer]: https://github.com/mkmer [@​mrueg]: https://github.com/mrueg [@​nabbi]: https://github.com/nabbi [@​starkillerOG]: https://github.com/starkillerOG [@​thecode]: https://github.com/thecode [@​vexofp]: https://github.com/vexofp [@​zxdavb]: https://github.com/zxdavb [alexa docs]: https://www.home-assistant.io/integrations/alexa/ [aosmith docs]: https://www.home-assistant.io/integrations/aosmith/ [blink docs]: https://www.home-assistant.io/integrations/blink/ [bluetooth docs]: https://www.home-assistant.io/integrations/bluetooth/ [cloud docs]: https://www.home-assistant.io/integrations/cloud/ [comelit docs]: https://www.home-assistant.io/integrations/comelit/ [cover docs]: https://www.home-assistant.io/integrations/cover/ [enigma2 docs]: https://www.home-assistant.io/integrations/enigma2/ [enphase_envoy docs]: https://www.home-assistant.io/integrations/enphase_envoy/ [evohome docs]: https://www.home-assistant.io/integrations/evohome/ [faa_delays docs]: https://www.home-assistant.io/integrations/faa_delays/ [flexit_bacnet docs]: https://www.home-assistant.io/integrations/flexit_bacnet/ [geo_json_events docs]: https://www.home-assistant.io/integrations/geo_json_events/ [holiday docs]: https://www.home-assistant.io/integrations/holiday/ [kef docs]: https://www.home-assistant.io/integrations/kef/ [knx docs]: https://www.home-assistant.io/integrations/knx/ [ld2410_ble docs]: https://www.home-assistant.io/integrations/ld2410_ble/ [luftdaten docs]: https://www.home-assistant.io/integrations/luftdaten/ [microsoft_face docs]: https://www.home-assistant.io/integrations/microsoft_face/ [minecraft_server docs]: https://www.home-assistant.io/integrations/minecraft_server/ [mqtt docs]: https://www.home-assistant.io/integrations/mqtt/ [reolink docs]: https://www.home-assistant.io/integrations/reolink/ [screenlogic docs]: https://www.home-assistant.io/integrations/screenlogic/ [shelly docs]: https://www.home-assistant.io/integrations/shelly/ [spotify docs]: https://www.home-assistant.io/integrations/spotify/ [streamlabswater docs]: https://www.home-assistant.io/integrations/streamlabswater/ [swiss_public_transport docs]: https://www.home-assistant.io/integrations/swiss_public_transport/ [switcher_kis docs]: https://www.home-assistant.io/integrations/switcher_kis/ [system_bridge docs]: https://www.home-assistant.io/integrations/system_bridge/ [systemmonitor docs]: https://www.home-assistant.io/integrations/systemmonitor/ [tado docs]: https://www.home-assistant.io/integrations/tado/ [tailwind docs]: https://www.home-assistant.io/integrations/tailwind/ [tplink docs]: https://www.home-assistant.io/integrations/tplink/ [tplink_lte docs]: https://www.home-assistant.io/integrations/tplink_lte/ [trend docs]: https://www.home-assistant.io/integrations/trend/ [unifiprotect docs]: https://www.home-assistant.io/integrations/unifiprotect/ [valve docs]: https://www.home-assistant.io/integrations/valve/ [zha docs]: https://www.home-assistant.io/integrations/zha/ [zoneminder docs]: https://www.home-assistant.io/integrations/zoneminder/ </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjkuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEyOS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/305 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Don't include position in binary valve attributes
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: