chore: sync with main #28933
Merged
chore: sync with main #28933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Issue number: resolves #28673 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When reviewing #28671 I noticed a bug where the custom animation was not used when going back after a replace. `handleNavigate` will override whatever is in `incomingRouteParams`. Since we were passing `routeAnimation` (which is `undefined`), it was overriding the animation we set in `handleNavigateBack`. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - `routeAnimation` is no longer overridden ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.6.1-dev.11702048520.13c82dad`
Issue number: resolves #28633 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> In #28005 I introduced a fix that causes "clearOnEdit" to not clear input/textarea when the Tab key was pressed. However, there were several edge cases I missed. For instance, pressing the "shift" key and then the "tab" key would still clear the input because "shift" was not explicitly excluded. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Input and textarea now explicitly ignores modifier keys that do not change the value of the input - `didInputClearOnEdit` is not set to `true` when an ignored key is pressed. Otherwise, pressing an ignored key and then an accepted key would not cause the input to be cleared. For example, pressing "shift", releasing "shift", then pressing "A" should cause the input to still get cleared. - Added test coverage ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Playwright bug report for a9f34a5: microsoft/playwright#28495
…28671) Issue number: resolves #24260 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? When replacing a route (`router.push(newRoute, 'none', 'replace')`) the `RouterDirection` from the route being replaced is being used (if it exists) instead of the new one the user specifies. ## What is the new behavior? User-specified `RouteDirection` is used, if it exists. If it doesn't it falls back to the `RouteDirection` of the route being replaced. ## Does this introduce a breaking change? - [ ] Yes - [X] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information Please see the following comment for why I think the current behavior is incorrect, and why this change is needed: #24260 (comment) --------- Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Older versions of WebKit used an old `constant()` syntax for safe area variables: https://caniuse.com/?search=env As of Safari 11.3, `env()` is supported instead. We haven't supported Safari 11 in years, so I think this is safe to remove.
I've noticed a few instances where the team forgets to add the "resolves" keyword (or similar "closes"/"fixes" keywords) when linking a PR to an issue. GitHub will not link the PR with the issue and will not close the issue on PR merge unless one of these keywords is used. I've updated the PR template to add the "resolves" keyword so team members don't need to worry about remembering to add it.
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.8.1 to 4.8.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🐳 v4.8.2 (2023-12-11)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> make sure typesDir exist before writing to it (<a href="https://redirect.github.com/ionic-team/stencil/issues/5109">#5109</a>) (<a href="https://github.com/ionic-team/stencil/commit/9e4e27e58ad918cb6a0358d63bd348880a6c04e4">9e4e27e</a>)</li> <li><strong>compiler:</strong> reapply changes to style import transformer (<a href="https://redirect.github.com/ionic-team/stencil/issues/5125">#5125</a>) (<a href="https://redirect.github.com/ionic-team/stencil/issues/5131">#5131</a>) (<a href="https://github.com/ionic-team/stencil/commit/735d45afdda420420f6d3992662cb63ded2c937e">735d45a</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/5016">#5016</a></li> <li><strong>runtime:</strong> hide slotted content with no destination in scoped components (<a href="https://redirect.github.com/ionic-team/stencil/issues/5135">#5135</a>) (<a href="https://github.com/ionic-team/stencil/commit/77bce27e028a8c2e72b51bada45ecae9e35420fb">77bce27</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/4284">#4284</a></li> <li><strong>runtime:</strong> relocate slotted content when slot parent element tag changes (<a href="https://redirect.github.com/ionic-team/stencil/issues/5120">#5120</a>) (<a href="https://github.com/ionic-team/stencil/commit/4303d6af1bbcd995e3e02891b5e50768e8eeaffd">4303d6a</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/4284">#4284</a></li> <li><strong>runtime:</strong> update <code>textContent</code> patch to mimic Shadow Root (<a href="https://redirect.github.com/ionic-team/stencil/issues/5146">#5146</a>) (<a href="https://github.com/ionic-team/stencil/commit/55c56d69a6e7d049bd8da17c6aec54667ec89489">55c56d6</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3977">#3977</a></li> <li><strong>testing:</strong> make Puppeteer an optional dependency (<a href="https://redirect.github.com/ionic-team/stencil/issues/5145">#5145</a>) (<a href="https://github.com/ionic-team/stencil/commit/43cf0dc5324fb90547d97a0592c3a2d98e69fb0d">43cf0dc</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h2>🐳 <a href="https://github.com/ionic-team/stencil/compare/v4.8.1...v4.8.2">4.8.2</a> (2023-12-11)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> make sure typesDir exist before writing to it (<a href="https://redirect.github.com/ionic-team/stencil/issues/5109">#5109</a>) (<a href="https://github.com/ionic-team/stencil/commit/9e4e27e58ad918cb6a0358d63bd348880a6c04e4">9e4e27e</a>)</li> <li><strong>compiler:</strong> reapply changes to style import transformer (<a href="https://redirect.github.com/ionic-team/stencil/issues/5125">#5125</a>) (<a href="https://redirect.github.com/ionic-team/stencil/issues/5131">#5131</a>) (<a href="https://github.com/ionic-team/stencil/commit/735d45afdda420420f6d3992662cb63ded2c937e">735d45a</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/5016">#5016</a></li> <li><strong>runtime:</strong> hide slotted content with no destination in scoped components (<a href="https://redirect.github.com/ionic-team/stencil/issues/5135">#5135</a>) (<a href="https://github.com/ionic-team/stencil/commit/77bce27e028a8c2e72b51bada45ecae9e35420fb">77bce27</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/4284">#4284</a></li> <li><strong>runtime:</strong> relocate slotted content when slot parent element tag changes (<a href="https://redirect.github.com/ionic-team/stencil/issues/5120">#5120</a>) (<a href="https://github.com/ionic-team/stencil/commit/4303d6af1bbcd995e3e02891b5e50768e8eeaffd">4303d6a</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/4284">#4284</a></li> <li><strong>runtime:</strong> update <code>textContent</code> patch to mimic Shadow Root (<a href="https://redirect.github.com/ionic-team/stencil/issues/5146">#5146</a>) (<a href="https://github.com/ionic-team/stencil/commit/55c56d69a6e7d049bd8da17c6aec54667ec89489">55c56d6</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3977">#3977</a></li> <li><strong>testing:</strong> make Puppeteer an optional dependency (<a href="https://redirect.github.com/ionic-team/stencil/issues/5145">#5145</a>) (<a href="https://github.com/ionic-team/stencil/commit/43cf0dc5324fb90547d97a0592c3a2d98e69fb0d">43cf0dc</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/70884f87e8798d1ac8c05ad4da1bffd8688626b1"><code>70884f8</code></a> Release v4.8.2 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5157">#5157</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/6abe25070243a0b17b13f6fec020048b87c85a32"><code>6abe250</code></a> fix(compiler): make style getter behavior consistent between default and nati...</li> <li><a href="https://github.com/ionic-team/stencil/commit/55c56d69a6e7d049bd8da17c6aec54667ec89489"><code>55c56d6</code></a> fix(runtime): update <code>textContent</code> patch to mimic Shadow Root (<a href="https://redirect.github.com/ionic-team/stencil/issues/5146">#5146</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/476c7b67940e9f58ce2ed23d925178c61aec7d10"><code>476c7b6</code></a> chore(deps): update dependency cspell to v8.1.3 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5151">#5151</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/fa5e9f617c762b55a981f46f8d892babb021e51a"><code>fa5e9f6</code></a> chore(deps): update dependency terser to v5.26.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5156">#5156</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/15eb129ee52b0a9220bd05a869fe2b38ce4669e0"><code>15eb129</code></a> chore(deps): update dependency puppeteer to v21.6.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5154">#5154</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/0868b0052c136dd168fc612885de7344de477c13"><code>0868b00</code></a> chore(deps): update typescript-eslint to v6.13.2 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5153">#5153</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/d6d5cdae5b55e31df3813b85a1704dfeb49e46ac"><code>d6d5cda</code></a> chore(deps): update dependency <code>@types/node</code> to v20.10.4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5150">#5150</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/43cf0dc5324fb90547d97a0592c3a2d98e69fb0d"><code>43cf0dc</code></a> fix(testing): make Puppeteer an optional dependency (<a href="https://redirect.github.com/ionic-team/stencil/issues/5145">#5145</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/3c5787579cd24ea91fa740e42b559be6ff1ba80e"><code>3c57875</code></a> chore(esbuild): build mock-doc with esbuild (<a href="https://redirect.github.com/ionic-team/stencil/issues/5012">#5012</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.8.1...v4.8.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… inside of a split pane (#28691) Issue number: resolves #21530 --------- ## What is the current behavior? The `box-shadow` and `transform` properties cannot be styled on a menu when it is inside of a split pane and visible due to the following: 1) The `box-shadow` and `transform` properties are set to `none` with `!important` 2) The menu itself is not on "top" of the split pane content so the content hides any box shadow ## What is the new behavior? - Removes all uses of `!important` in split pane and menu - Developers will need to change the `z-index` from `0` to `1` on the `ion-menu` so the menu will sit on top of the split pane and show the `box-shadow` ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information I considered putting the test for this in `split-pane` but I thought since it was styling the `ion-menu` it should go in menu. I can move this if others think it makes more sense in `split-pane`. --------- Co-authored-by: ionitron <hi@ionicframework.com>
#28687) Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Ionic React projects using `@types/react@18.2.43` or greater will run into a type-check error on build with `IonRouterOutlet` and potentially other components: ``` Property 'placeholder' is missing in type '{ children: Element[]; }' but required in type 'Pick<IonRouterOutlet & { basePath?: string | undefined; ref?: Ref<any> | undefined; ionPage?: boolean | undefined; } & IonicReactProps & Omit<...>, "color" | ... 254 more ... | "ionPage">'. ``` Definitely typed decided to make a breaking type change in a patch release: DefinitelyTyped/DefinitelyTyped@b954269 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Patches the type to allow for compatibility between React v16, 17 and 18. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> ### Testing 1. Create a new Ionic react project with the "list" template. 2. Run `npm run build` 3. Observe: Exception posted above 4. Install the dev-build 5. Run `npm run build` 6. Observe: No exception, build passes 7. You can additionally serve the app to verify no runtime exceptions/broken behavior. Dev-build: `7.6.1-dev.11702322681.17e39348`
Release 7.6.1
The team had feedback during a sprint retro that the breaking change process documentation was a bit spread out. In particular, some team members were not clear that you need to a) update the breaking.md file and b) add the "BREAKING CHANGE" comment to the commit description. This PR adds both of these things are comments for awareness.
This best practice currently resides in our internal testing process docs. I think this is valuable information for contributors to have as well, so I've added it to our public best practices doc.
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> While working on an unrelated task, I noticed the list items in the list starter app run off the page. This is due to the text wrapping behavior in v7.6 where we allows the labels to grow/shrink. However, we do not set a limit on how much they can grow. This means that child elements inside of `ion-label` with long text can cause the label container to grow indefinitely. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Labels in item have a max-width of 100% ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.6.1-dev.11702498225.1ad6eda6` | before | after | | - | - | |  |  | --------- Co-authored-by: ionitron <hi@ionicframework.com>
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Buttons slotted in the start/end slots of input, textarea, or select have a lot of excess padding that can cause them to look misaligned from other pieces such as the control's label, especially when using `fill="clear"`. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> Padding removed, and a border radius added so that non-clear buttons as well as the focus state on clear buttons still look okay. Existing screenshot tests have also been updated to include buttons (non-clear ones so you can see the border radius in the screenshots). Let me know if you think this should go on a feature branch instead. I chose `main` because the current experience looks somewhat broken and we just did a minor release recently, but this could be considered a notable enough behavior change. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
Issue number: resolves #28716 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> All components that have per-mode stylesheets can have their mode adjusted by setting `mode` on the component. We use the `setMode` function to determine which mode to use on the component: https://github.com/ionic-team/ionic-framework/blob/516b84475e5d78060f35fa2c4821efc712536353/core/src/global/ionic-global.ts#L75 While this works on refresher, it is missing the `virtualProp` jsdoc comment which causes it to not have the appropriate type information. As a result, when developers try to use a JS binding for `mode`, they will get compilation errors. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Adds virtualProp for mode to refresher ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> I am considering this a bug fix instead of a feature. In non-TypeScript environments you can set `mode` on `ion-refresher` and it does change the mode. What's missing here is the type information associated with it. Dev build: `7.6.2-dev.11702914017.1ae72da5`
#28713) Bumps [@capacitor/keyboard](https://github.com/ionic-team/capacitor-plugins) from 5.0.6 to 5.0.7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/capacitor-plugins/releases"><code>@capacitor/keyboard</code>'s releases</a>.</em></p> <blockquote> <h2><code>@capacitor/keyboard</code><a href="https://github.com/5"><code>@5</code></a>.0.7</h2> <h2><a href="https://github.com/ionic-team/capacitor-plugins/compare/@capacitor/keyboard@5.0.6...@capacitor/keyboard@5.0.7">5.0.7</a> (2023-12-15)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>keyboard:</strong> Change keyboard style during setStyle (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1935">#1935</a>) (<a href="https://github.com/ionic-team/capacitor-plugins/commit/3b520b845563f08897f55eb44fe212ae384a7675">3b520b8</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/c5aab483fe0609ab1b2503c245a6c27b6cfd5a7b"><code>c5aab48</code></a> chore(release): publish [skip ci]</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/77dc373b41fb5fee9fb7acdb511564043494bb10"><code>77dc373</code></a> fix(camera): reject promise on web input cancel event (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1964">#1964</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/bf7ec3306e7943358ac9ea118b904ff27d6ea2f6"><code>bf7ec33</code></a> feat(google-maps): Separate mapId for Google Maps Cloud IDs (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1943">#1943</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/3b520b845563f08897f55eb44fe212ae384a7675"><code>3b520b8</code></a> fix(keyboard): Change keyboard style during setStyle (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1935">#1935</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/e18f45853322516c2da8c8505814deb72a5eaecc"><code>e18f458</code></a> docs(screen-reader): Use stateChange event in example code (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1934">#1934</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/fb941c7f39c37684c07c5162644756f4b919418d"><code>fb941c7</code></a> feat(filesystem): add removeAllListeners method (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1868">#1868</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/3d20522a7d4ecf678ce9e0dded9af3065235c817"><code>3d20522</code></a> chore(ci): Pin <code>@actions/http-client</code> version to 2.1.1 (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1870">#1870</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/dc2eb14b7d8db3c5a178c420a0fd37209b97912d"><code>dc2eb14</code></a> chore(release): publish [skip ci]</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/73ad64b665406d028cf2e171da89801a0ea9cf78"><code>73ad64b</code></a> fix(google-maps): use URLSession for remote iconUrl on iOS (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1818">#1818</a>) (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1824">#1824</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/ef656564518d03624d5d74a3ca173a53594ec4ba"><code>ef65656</code></a> fix(google-maps): Apply iconAnchor value to Marker anchor on Android (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1822">#1822</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/capacitor-plugins/compare/@capacitor/keyboard@5.0.6...@capacitor/keyboard@5.0.7">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Release 7.6.2
After each release, we need to update the local `package-lock.json` dependencies. We do this via a `npm install --package-lock-only` command. However, this command can fail for reasons such as a connection timeout. When this happens, the package-lock files do not get updated. The problem is this action is also done in the same job as generating the changelog and creating the GitHub release. This operations cannot be re-done. As a result, we cannot simply re-run this job and try updating the package-lock files again. This PR changes the workflow to split the package-lock update out to its own job. In the event that this job fails, we can re-run only this job and leave the other jobs untouched.
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> In #28694 there was some confusion around how to access `this` inside of a callback function passed to a property on Ionic components. The root issue was due to how the `this` context is determined with developers being responsible for setting the appropriate `this` context. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - While this isn't an Ionic bug, I think it's worth calling out this behavior so developers are aware of how to account for it. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Note: The link in the docs will not work until ionic-team/ionic-docs#3333 is merged. --------- Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
Issue number: Internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> We removed the background color from today's calendar day button if selected when implementing the calendar-day button shadow part feature: 79b005d#diff-8e2912d52559aa44c9c6dc062c8d683e7b51c92c7b7ba420ad6f7587f1e1a61aL139 We did not catch this because we do not have test coverage for this use case. We typically avoid rendering datetime on today's date because "today" could be something totally different depending on the test machine's locale/configuration. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Adds the background rule that was removed - Added test coverage. I mocked today's date to be a fixed date so it never changes ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
Issue number: resolves #28617 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> We currently check to see if `webkitOverflowScrolling` is supported on the refresher's style object in order to enable to native iOS refresher. This works well for iOS, but it does not work for iPadOS. This is because this property was removed in iPadOS 13: https://developer.apple.com/documentation/safari-release-notes/safari-13-release-notes > Disabled -webkit-overflow-scrolling: touch on iPad. All frames and scrollable overflow areas now use accelerated one-finger scrolling without changing stacking. As a result, the native iOS refresher does not activate on iPadOS. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - I think it's safe to assume that `webkitOverflowScrolling` may be removed on iOS in the future too since it was already removed on iPadOS. As a result, I implemented a solution that avoids checking this. - The `CSS.supports` check is required because otherwise the native iOS refresher would be activated in an emulated environment such as Chrome dev tools because the user agent is spoofed. The `apple-pay-logo-black` named image is only supported on Apple devices. Risks: - Apple could remove the `apple-pay-logo-black` named image in the future. However, we currently use this check elsewhere in Ionic too and it has worked well: https://github.com/ionic-team/ionic-framework/blob/60303aad23f823488afc8f8824e9c72e3ab86acc/core/src/components/datetime/datetime.ios.scss#L177. - Apple could add touch emulation to desktop Safari which could cause the native refresher to activate when using responsive design mode for testing. However, this would only impact app developer and would not impact production use cases. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.5.8-dev.11703088210.14a72b83` Co-authored-by: Sean Perkins <sean-perkins@users.noreply.github.com> --------- Co-authored-by: Sean Perkins <sean-perkins@user.noreply.github.com>
Bumps [ionicons](https://github.com/ionic-team/ionicons) from 7.2.1 to 7.2.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/ionicons/releases">ionicons's releases</a>.</em></p> <blockquote> <h2>v7.2.2</h2> <h2><a href="https://github.com/ionic-team/ionicons/compare/v7.2.1...v7.2.2">7.2.2</a> (2023-12-13)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>icon:</strong> add better warning when loading icons (<a href="https://redirect.github.com/ionic-team/ionicons/issues/1297">#1297</a>) (<a href="https://github.com/ionic-team/ionicons/commit/d582e6208e626722e4350426a509a6870e90a0bc">d582e62</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/ionicons/blob/main/CHANGELOG.md">ionicons's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/ionic-team/ionicons/compare/v7.2.1...v7.2.2">7.2.2</a> (2023-12-13)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>icon:</strong> add better warning when loading icons (<a href="https://redirect.github.com/ionic-team/ionicons/issues/1297">#1297</a>) (<a href="https://github.com/ionic-team/ionicons/commit/d582e6208e626722e4350426a509a6870e90a0bc">d582e62</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/ionicons/commit/fccc2606274ac79c420a15df210e9649449a2acb"><code>fccc260</code></a> v7.2.2</li> <li><a href="https://github.com/ionic-team/ionicons/commit/d582e6208e626722e4350426a509a6870e90a0bc"><code>d582e62</code></a> fix(icon): add better warning when loading icons (<a href="https://redirect.github.com/ionic-team/ionicons/issues/1297">#1297</a>)</li> <li><a href="https://github.com/ionic-team/ionicons/commit/625d54fdada2947957d468a89c65a27bd79aa670"><code>625d54f</code></a> merge release-7.2.1</li> <li><a href="https://github.com/ionic-team/ionicons/commit/841fb965437fc6ca30d953179ff139621b8aafd6"><code>841fb96</code></a> remove duplicate entry</li> <li><a href="https://github.com/ionic-team/ionicons/commit/9dab13aef7402ccf4d9ea76ccf0175d0dd13a663"><code>9dab13a</code></a> chore(): update package lock files</li> <li>See full diff in <a href="https://github.com/ionic-team/ionicons/compare/v7.2.1...v7.2.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The keyboard navigation tests for radio were disable due to flakiness with Safari when it came to the CI. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Re-enabled the tests. Debugging was done with a saved artifact. The artifact didn't provide a clear reason of why it flakes. But it did seem that the test was tabbing before the Safari page finished loading. I've added a `waitFor()` to verify that the radios have rendered. This was done for Safari only to prevent any additional wait time. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> There is no great way to test this since it only flakes on GitHub.
) Bumps [@stencil/sass](https://github.com/ionic-team/stencil-sass) from 3.0.7 to 3.0.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil-sass/releases"><code>@stencil/sass</code>'s releases</a>.</em></p> <blockquote> <h2>v3.0.8</h2> <h2>What's Changed</h2> <ul> <li>chore(deps): update actions/setup-node action to v3.8.2 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/423">ionic-team/stencil-sass#423</a></li> <li>chore(deps): update actions/setup-node action to v4 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/425">ionic-team/stencil-sass#425</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.6.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/424">ionic-team/stencil-sass#424</a></li> <li>chore(deps): update node.js to v20.9.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/426">ionic-team/stencil-sass#426</a></li> <li>chore(deps): update dependency rollup to v4.1.5 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/427">ionic-team/stencil-sass#427</a></li> <li>chore(deps): update dependency rollup to v4.1.6 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/430">ionic-team/stencil-sass#430</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.7.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/428">ionic-team/stencil-sass#428</a></li> <li>chore(deps): update dependency terser to v5.23.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/429">ionic-team/stencil-sass#429</a></li> <li>chore(deps): update dependency terser to v5.24.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/433">ionic-team/stencil-sass#433</a></li> <li>chore(deps): update dependency rollup to v4.2.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/432">ionic-team/stencil-sass#432</a></li> <li>chore(deps): update dependency npm to v10.2.3 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/431">ionic-team/stencil-sass#431</a></li> <li>chore(deps): update dependency rollup to v4.3.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/434">ionic-team/stencil-sass#434</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.7.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/435">ionic-team/stencil-sass#435</a></li> <li>chore(deps): update dependency rollup to v4.3.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/436">ionic-team/stencil-sass#436</a></li> <li>chore(deps): update dependency rollup to v4.4.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/437">ionic-team/stencil-sass#437</a></li> <li>chore(deps): update dependency prettier to v3.1.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/438">ionic-team/stencil-sass#438</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.7.2 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/439">ionic-team/stencil-sass#439</a></li> <li>chore(deps): update dependency rollup to v4.4.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/440">ionic-team/stencil-sass#440</a></li> <li>chore(deps): update dependency npm to v10.2.4 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/441">ionic-team/stencil-sass#441</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.8.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/444">ionic-team/stencil-sass#444</a></li> <li>chore(deps): update dependency np to v9 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/445">ionic-team/stencil-sass#445</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.8.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/446">ionic-team/stencil-sass#446</a></li> <li>chore(deps): update dependency terser to v5.25.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/447">ionic-team/stencil-sass#447</a></li> <li>chore(deps): update dependency np to v9.1.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/449">ionic-team/stencil-sass#449</a></li> <li>chore(deps): update dependency npm to v10.2.5 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/448">ionic-team/stencil-sass#448</a></li> <li>chore(deps): update dependency terser to v5.26.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/450">ionic-team/stencil-sass#450</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.8.2 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/453">ionic-team/stencil-sass#453</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ionic-team/stencil-sass/compare/v3.0.7...v3.0.8">https://github.com/ionic-team/stencil-sass/compare/v3.0.7...v3.0.8</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil-sass/commit/5132964c48fa825bcc5e9e29502fbf034cb7ec9d"><code>5132964</code></a> 3.0.8</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/9709fe24358967aee291cbc51a73c76e964f4717"><code>9709fe2</code></a> chore(deps): update dependency <code>@stencil/core</code> to v4.8.2 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/453">#453</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/59591b16a3b68927e76faa5165d973a0192a47ea"><code>59591b1</code></a> chore(deps): update dependency terser to v5.26.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/450">#450</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/cc7d97f7d9db4825d076bbb0a8c04fe93b362352"><code>cc7d97f</code></a> chore(deps): update dependency npm to v10.2.5 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/448">#448</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/838cd61da74b372e67351e2725b43186a79f2428"><code>838cd61</code></a> chore(deps): update dependency np to v9.1.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/449">#449</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/e53802422ed0f56c89b860672f1ac297291b83be"><code>e538024</code></a> chore(deps): update dependency terser to v5.25.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/447">#447</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/4d7ff18177b2b5fdef34df42c9c9233570934d4c"><code>4d7ff18</code></a> chore(deps): update dependency <code>@stencil/core</code> to v4.8.1 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/446">#446</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/f9b99826dbe80524f08092f52f878a390b1af5d9"><code>f9b9982</code></a> chore(deps): update dependency np to v9 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/445">#445</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/b4d8158a986a11ea38d757f498c243a3c489cfff"><code>b4d8158</code></a> chore(deps): update dependency <code>@stencil/core</code> to v4.8.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/444">#444</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/d2864095215f2f26232307f41850f5919b5e9aaa"><code>d286409</code></a> chore(deps): update dependency npm to v10.2.4 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/441">#441</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil-sass/compare/v3.0.7...v3.0.8">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…28706) Bumps [@capacitor/core](https://github.com/ionic-team/capacitor) from 5.5.1 to 5.6.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/capacitor/releases"><code>@capacitor/core</code>'s releases</a>.</em></p> <blockquote> <h2>5.6.0</h2> <h1><a href="https://github.com/ionic-team/capacitor/compare/5.5.1...5.6.0">5.6.0</a> (2023-12-14)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>cli:</strong> Use latest native-run (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7030">#7030</a>) (<a href="https://github.com/ionic-team/capacitor/commit/1d948d4df6b6b6f8cfdc02e72d84ae8be963f4a0">1d948d4</a>)</li> <li><strong>http:</strong> properly write form-urlencoded data on android request body (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7130">#7130</a>) (<a href="https://github.com/ionic-team/capacitor/commit/a745a89e18a5082ae4e737d78aa20929f6952382">a745a89</a>)</li> <li><strong>http:</strong> set formdata boundary and body when content-type not explicitly set (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7133">#7133</a>) (<a href="https://github.com/ionic-team/capacitor/commit/3862d6e6721793d78add9acf5b14fd9a8f7a5b60">3862d6e</a>)</li> <li><strong>ios:</strong> add some new cordova-ios classes used by Cordova plugins (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7115">#7115</a>) (<a href="https://github.com/ionic-team/capacitor/commit/5fb902b232d9afded2edc865c8d3c0c0e7efe5e7">5fb902b</a>)</li> </ul> <h3>Features</h3> <ul> <li>support for Amazon Fire WebView (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6603">#6603</a>) (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7129">#7129</a>) (<a href="https://github.com/ionic-team/capacitor/commit/421d2c02e4d1954d16d573facae9c235fee60f02">421d2c0</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/capacitor/blob/5.6.0/CHANGELOG.md"><code>@capacitor/core</code>'s changelog</a>.</em></p> <blockquote> <h1><a href="https://github.com/ionic-team/capacitor/compare/5.5.1...5.6.0">5.6.0</a> (2023-12-14)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>cli:</strong> Use latest native-run (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7030">#7030</a>) (<a href="https://github.com/ionic-team/capacitor/commit/1d948d4df6b6b6f8cfdc02e72d84ae8be963f4a0">1d948d4</a>)</li> <li><strong>http:</strong> properly write form-urlencoded data on android request body (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7130">#7130</a>) (<a href="https://github.com/ionic-team/capacitor/commit/a745a89e18a5082ae4e737d78aa20929f6952382">a745a89</a>)</li> <li><strong>http:</strong> set formdata boundary and body when content-type not explicitly set (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7133">#7133</a>) (<a href="https://github.com/ionic-team/capacitor/commit/3862d6e6721793d78add9acf5b14fd9a8f7a5b60">3862d6e</a>)</li> <li><strong>ios:</strong> add some new cordova-ios classes used by Cordova plugins (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7115">#7115</a>) (<a href="https://github.com/ionic-team/capacitor/commit/5fb902b232d9afded2edc865c8d3c0c0e7efe5e7">5fb902b</a>)</li> </ul> <h3>Features</h3> <ul> <li>support for Amazon Fire WebView (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6603">#6603</a>) (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7129">#7129</a>) (<a href="https://github.com/ionic-team/capacitor/commit/421d2c02e4d1954d16d573facae9c235fee60f02">421d2c0</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/capacitor/commit/12cdab84fcc28a28bc0ca493298fd8e13a53ea4e"><code>12cdab8</code></a> Release 5.6.0</li> <li><a href="https://github.com/ionic-team/capacitor/commit/421d2c02e4d1954d16d573facae9c235fee60f02"><code>421d2c0</code></a> feat: support for Amazon Fire WebView (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6603">#6603</a>) (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7129">#7129</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/a745a89e18a5082ae4e737d78aa20929f6952382"><code>a745a89</code></a> fix(http): properly write form-urlencoded data on android request body (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7130">#7130</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/dfc97ee2d87e70fb94f3e92bb30d0ae8f9a9eafa"><code>dfc97ee</code></a> docs(http): FormData and other complex types do not work on CapacitorHttp plu...</li> <li><a href="https://github.com/ionic-team/capacitor/commit/3862d6e6721793d78add9acf5b14fd9a8f7a5b60"><code>3862d6e</code></a> fix(http): set formdata boundary and body when content-type not explicitly se...</li> <li><a href="https://github.com/ionic-team/capacitor/commit/5fb902b232d9afded2edc865c8d3c0c0e7efe5e7"><code>5fb902b</code></a> fix(ios): add some new cordova-ios classes used by Cordova plugins (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7115">#7115</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/7977a6da4876b1a9ee1b1a532f84789ec37c3c74"><code>7977a6d</code></a> chore(android): Update json test dependency (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7102">#7102</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/13935f0c3bf87d5220bcdb5759c109edb841d9b5"><code>13935f0</code></a> docs: add warning around androidScheme with Android webview 117 (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7098">#7098</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/8d97b800ca2d3b5f4e3485cbbbcd747b94c8bf0b"><code>8d97b80</code></a> chore(android): Mock Log class for tests (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7099">#7099</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/1d948d4df6b6b6f8cfdc02e72d84ae8be963f4a0"><code>1d948d4</code></a> fix(cli): Use latest native-run (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7030">#7030</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/capacitor/compare/5.5.1...5.6.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…arger screens (#28745) Issue number: resolves #28737 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> In #28246 we removed the overflow on Nav and Router Outlet to allow content to flow outside of these containers. This allows the translucent tab effect to work (otherwise content would be clipped and there would be no translucency). However, this had the unintended side effect of causing page transitions to flow outside of these components. This is most noticeable on larger displays when using SplitPane because the page can cover the menu mid-transition. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Overflow is no longer allowed on the main content. I originally set the overflow on the router outlet/nav itself, but that caused the translucent tab bar behavior to regress. Since this issue only happens with split pane, I decided to apply the fix there. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> ### Dev build `7.6.3-dev.11703103144.148eb1f6`⚠️ Please test in a physical app too ### Before/After Demo | `main` | branch | | - | - | | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/2f3f0d74-9a7e-4ebe-b58a-6e1a6ea3636e"></video> | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/cdbf8fb5-e217-48cf-8c1e-4bdecee4de4c"></video> | ### Screenshot Diffs The `menu-custom` screenshot diffs ([Example](https://github.com/ionic-team/ionic-framework/pull/28745/files)) are correct. By adding `overflow: hidden`, the box shadow from the "Content" header no longer flows outside of the container. The menu [border on MD has an opacity of 0.18](https://github.com/ionic-team/ionic-framework/blob/e5226016a0f0b066a7bd7fc9997f905d3b87fbc4/core/src/components/menu/menu.md.vars.scss#L7), so the border color was mixing with the color of the box shadow from the header. Since the shadow no longer flows outside of the container, the border color does not mix with the box shadow color. ### Does this break translucent tabs when the split pane is inside of a tab? No. The [split pane has `contain: strict` set](https://github.com/ionic-team/ionic-framework/blob/e5226016a0f0b066a7bd7fc9997f905d3b87fbc4/core/src/components/split-pane/split-pane.scss#L24) which prevents content from flowing under the tab bar, so the translucent tab bar never worked with this layout. --------- Co-authored-by: ionitron <hi@ionicframework.com>
This PR begins holiday triage mode for the Ionic Framework repo.
To make it easy for the team to quickly triage issues, we'd like to automatically assign issues to team members at random. This PR use https://github.com/marketplace/actions/auto-assign-issue to assign 1 member of the `framework` GitHub team to be the person to triage.
The token I was using didn't have the correct permissions, and I need to figure out how to generate a new token (I don't think I have access to the account where these tokens live). For now, I'm going to hard code the team members until I can figure out the token access out.
This script was used to aid in the test of local version of `@ionic/angular`. However, these instructions have been replaced by the instructions in `packages/angular/test/README.md`. This PR removes the old script.
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> There are some tests that use Playwright's `waitForSelector` [function](https://playwright.dev/docs/api/class-page#page-wait-for-selector). However, Playwright has informed the community to not use this function by labeling it as [discouraged](https://playwright.dev/docs/api/class-page#page-wait-for-selector). ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Replaced `waitForSelector` with the [recommended](https://playwright.dev/docs/api/class-page#page-wait-for-selector) `waitFor` [function](https://playwright.dev/docs/api/class-locator#locator-wait-for). ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> N/A
Issue number: resolves #28525 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When navigated via tab-key, the ion-item is not highlighted correctly after switching from button=false to button=true. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> Now, when dynamically changing the the `button` option to `True`, there's a `@watch` callback that will make sure the internal `isFocusable` `@state` will be updated. - A new unit test was added to item/test. As there was still any unit test for the `ion-item`, a new files was created - `item.spec.tsx` ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> New behavior in runtime:  --------- Co-authored-by: Sean Perkins <sean@ionic.io>
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> All the E2E tests are run when performing the "Update Reference Screenshots" GitHub actions.  ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - All E2E tests still run as default. - The GH action has the option to run a specific component instead of all tests. - A specified component has the option to run all tests that include the component's name in the file path - A specified component has the option to run all tests that are in the component's folder - If a single component is selected, then the default is to only run tests inside it's folder.  ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> How to test: 1. Create a new branch based off this one 2. Make a style change 3. Push it to the new branch 4. Update the reference images using the new branch 5. This will show you all the options Recommended to test: - a component with the ion prefix (`ion-button`) - a component without the prefix (`button`) - a component that doesn't exist (`random-component`) - no provided component, leave the first input blank - the checkbox --------- Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
…re (#28887) Bumps [@axe-core/playwright](https://github.com/dequelabs/axe-core-npm) from 4.8.3 to 4.8.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dequelabs/axe-core-npm/releases"><code>@axe-core/playwright</code>'s releases</a>.</em></p> <blockquote> <h2>Release 4.8.4</h2> <h2>What's Changed</h2> <ul> <li>chore: RC v4.8.3 by <a href="https://github.com/github-actions"><code>@github-actions</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/983">dequelabs/axe-core-npm#983</a></li> <li>chore: bump puppeteer from 19.7.3 to 21.7.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/979">dequelabs/axe-core-npm#979</a></li> <li>Release v4.8.3 by <a href="https://github.com/dequejenn"><code>@dequejenn</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/986">dequelabs/axe-core-npm#986</a></li> <li>chore: bump the npm-low-risk group with 11 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/982">dequelabs/axe-core-npm#982</a></li> <li>chore: bump follow-redirects from 1.15.2 to 1.15.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/988">dequelabs/axe-core-npm#988</a></li> <li>chore: merge master into develop by <a href="https://github.com/github-actions"><code>@github-actions</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/987">dequelabs/axe-core-npm#987</a></li> <li>ci: add env var required for creating gh releases by <a href="https://github.com/michael-siek"><code>@michael-siek</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/989">dequelabs/axe-core-npm#989</a></li> <li>ci: remove deprecated release candidate action by <a href="https://github.com/michael-siek"><code>@michael-siek</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/990">dequelabs/axe-core-npm#990</a></li> <li>fix(webdriverjs): use new headless argument to fix selenium-webdriver@4.17.0 breaking release by <a href="https://github.com/straker"><code>@straker</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/992">dequelabs/axe-core-npm#992</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/dequelabs/axe-core-npm/compare/v4.8.3...4.8.4">https://github.com/dequelabs/axe-core-npm/compare/v4.8.3...4.8.4</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/dequelabs/axe-core-npm/blob/develop/CHANGELOG.md"><code>@axe-core/playwright</code>'s changelog</a>.</em></p> <blockquote> <h1>Change Log</h1> <p>All notable changes to this project will be documented in this file. See <a href="https://conventionalcommits.org">Conventional Commits</a> for commit guidelines.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/0daba98684ede79bfb6488dd1b81f7d863e69d99"><code>0daba98</code></a> fix(webdriverjs): use new headless argument to fix selenium-webdriver@4.17.0 ...</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/2220400acdb08909909f63da35983c49f46b5b72"><code>2220400</code></a> ci: remove deprecated release candidate action (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/990">#990</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/4f295d393ab17127ddbd9f82a261200e15e54d7e"><code>4f295d3</code></a> ci: add env var required for creating gh releases (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/989">#989</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/81aefd56461de89ad6e1a2a00138bac2d9400d89"><code>81aefd5</code></a> Merge pull request <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/987">#987</a> from dequelabs/master</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/7d49d53bbb8e89907293cc91b7db0710c801dca8"><code>7d49d53</code></a> Merge branch 'develop' into master</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/92669c1ea1806477933ee99ce5e9483682214907"><code>92669c1</code></a> chore: bump follow-redirects from 1.15.2 to 1.15.5 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/988">#988</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/dc380aa88599dcc8285d2193d9a425d3b721f6de"><code>dc380aa</code></a> chore: bump the npm-low-risk group with 11 updates (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/982">#982</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/3ceecac297d165d252e19b7d3452919d8c813194"><code>3ceecac</code></a> Merge pull request <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/986">#986</a> from dequelabs/release</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/6b60442cbdb624d41bbd8a1fa001567affc9c52b"><code>6b60442</code></a> chore: bump puppeteer from 19.7.3 to 21.7.0 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/979">#979</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/54b75d095ae46ddc878e493a8c26ea7d9a960b7f"><code>54b75d0</code></a> Merge pull request <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/983">#983</a> from dequelabs/release-2024-01-09</li> <li>See full diff in <a href="https://github.com/dequelabs/axe-core-npm/compare/v4.8.3...4.8.4">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `IonPicker` tests in the React app were skipped due to a Stencil bug that has since been resolved. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> Tests re-enabled. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Issue number: resolves #28769 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> As part of #28146, we allowed text wrapping inside of `ion-item` for accessibility purposes. One of the behaviors we added was to allow start, default, and end slotted containers to wrap to the next line to align with the iOS spec. However, this decision was based on an incorrect assumption. The following screenshot shows the Settings app on iOS: | default scale | 310% scale | | - | - | | <img width="1170" alt="Frame 4" src="https://github.com/ionic-team/ionic-framework/assets/2721089/462ef153-a060-41c8-9a00-f0aad17839be"> | <img width="1170" alt="Frame 5" src="https://github.com/ionic-team/ionic-framework/assets/2721089/f047f880-7b80-4710-939b-96da075fbbf9"> | At the default scale, the blue icon is in the iOS equivalent of the "start" slot, "Bluetooth" is in the default slot, and "On" is in the "end" slot. We incorrectly assumed the same markup was true when scaling the text up. However, at 310% scale the icon, "Bluetooth" text, and "On" text all become part of the default slot in a single container that wraps. You can tell because the bottom border runs underneath the blue icon at 310% whereas it does not at the default scale. This allows the text to wrap underneath the blue icon. When we originally implemented #28146 we thought that this meant the start, default, and end slot containers should wrap to the next line. I further validated this behavior by creating an app with Swift UI. I created a list of items where each item has the native equivalent of a checkbox in the `start` slot and multiple `ion-labels` in the default slot of the item: | Default Scale | 310% Scale | | - | - | |  |  | The content within each label wraps within the container, but the containers themselves never wrap to the next line. Demo code: ```swift import SwiftUI struct ContentView: View { struct Item: Identifiable, Hashable { let id = UUID() } private var items = [ Item(), Item(), Item(), Item(), Item() ] @State private var multiSelection = Set<UUID>() var body: some View { NavigationView { List(items, selection: $multiSelection) {_ in HStack { Text("Column 1 with really long text") Text("Column 2 with really long text") Text("Column 3 with really long text") Text("Column 4 with really long text") } } .toolbar { EditButton() } } Text("\(multiSelection.count) selections") } } #Preview { ContentView() } ``` ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - This PR removes the ability for the start, default, and end slot containers to wrap to the next line. This behavior aligns with pre-v7.6.0 behaviors. The containers inside of the default slot will not wrap to the next line. However, content within each container (such as text within an `ion-label`) will continue to wrap to meet the team's accessibility requirements. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.6.5-dev.11704916749.1e64a3a7` --------- Co-authored-by: ionitron <hi@ionicframework.com>
Issue number: Internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> React and React Router packages do not build correctly on Windows because certain dependencies were not marked as external. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - 3rd party packages are correctly marked as external ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.10.0 to 4.11.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🍝 4.11.0 (2024-01-22)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>runtime:</strong> resolve memory leak caused by global content ref (<a href="https://redirect.github.com/ionic-team/stencil/issues/5266">#5266</a>) (<a href="https://github.com/ionic-team/stencil/commit/fb1b3f5a5bf1096fa67ad0807881585975b4161b">fb1b3f5</a>)</li> <li><strong>screenshot:</strong> recognise clip options (<a href="https://redirect.github.com/ionic-team/stencil/issues/5205">#5205</a>) (<a href="https://github.com/ionic-team/stencil/commit/0d61a53a24a361cc5b6f9545eaccb6957f9debcc">0d61a53</a>)</li> <li><strong>style:</strong> fixes to watching nested and multiple styles on Stencil components (<a href="https://redirect.github.com/ionic-team/stencil/issues/5244">#5244</a>) (<a href="https://github.com/ionic-team/stencil/commit/fa5ab1b75f19e1117f0cead1caaf6b00ddccadf3">fa5ab1b</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>compiler:</strong> deprecate customResolveOptions config option (<a href="https://redirect.github.com/ionic-team/stencil/issues/5269">#5269</a>) (<a href="https://github.com/ionic-team/stencil/commit/6faf746990330da4369e0d73725b0fc2becebb33">6faf746</a>)</li> <li><strong>deps:</strong> upgrade rollup, commonjs plugin (<a href="https://redirect.github.com/ionic-team/stencil/issues/5274">#5274</a>) (<a href="https://github.com/ionic-team/stencil/commit/661120c6524f1bf2987547677c01654a8bfb199e">661120c</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h1>🍝 <a href="https://github.com/ionic-team/stencil/compare/v4.10.0...v4.11.0">4.11.0</a> (2024-01-22)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>runtime:</strong> resolve memory leak caused by global content ref (<a href="https://redirect.github.com/ionic-team/stencil/issues/5266">#5266</a>) (<a href="https://github.com/ionic-team/stencil/commit/fb1b3f5a5bf1096fa67ad0807881585975b4161b">fb1b3f5</a>)</li> <li><strong>screenshot:</strong> recognise clip options (<a href="https://redirect.github.com/ionic-team/stencil/issues/5205">#5205</a>) (<a href="https://github.com/ionic-team/stencil/commit/0d61a53a24a361cc5b6f9545eaccb6957f9debcc">0d61a53</a>)</li> <li><strong>style:</strong> fixes to watching nested and multiple styles on Stencil components (<a href="https://redirect.github.com/ionic-team/stencil/issues/5244">#5244</a>) (<a href="https://github.com/ionic-team/stencil/commit/fa5ab1b75f19e1117f0cead1caaf6b00ddccadf3">fa5ab1b</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>compiler:</strong> deprecate customResolveOptions config option (<a href="https://redirect.github.com/ionic-team/stencil/issues/5269">#5269</a>) (<a href="https://github.com/ionic-team/stencil/commit/6faf746990330da4369e0d73725b0fc2becebb33">6faf746</a>)</li> <li><strong>deps:</strong> upgrade rollup, commonjs plugin (<a href="https://redirect.github.com/ionic-team/stencil/issues/5274">#5274</a>) (<a href="https://github.com/ionic-team/stencil/commit/661120c6524f1bf2987547677c01654a8bfb199e">661120c</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/b2ec143e8c98d8c0d6bbd55645bd5100b1014702"><code>b2ec143</code></a> Release v4.11.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5285">#5285</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/36443725e8ef3ad0b47286c036b69352ef258b59"><code>3644372</code></a> chore(deps): update typescript-eslint to v6.19.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5283">#5283</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/1a75ab099160b0d641d26de85eb4a6a189203d2f"><code>1a75ab0</code></a> chore(deps): update actions/upload-artifact action to v4.2.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5281">#5281</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9c8ed64b06cc48466318195e3cbe196f3bc5f028"><code>9c8ed64</code></a> chore(deps): update dependency autoprefixer to v10.4.17 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5279">#5279</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/e1fc49f9bf7177648251b871cb78c9ce86eec630"><code>e1fc49f</code></a> chore(deps): update dependency terser to v5.27.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5282">#5282</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/ff8c4e55d3cdc2812b819e4c6b19cbb5ac73baf6"><code>ff8c4e5</code></a> chore(deps): update dependency prettier to v3.2.4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5280">#5280</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/fa5ab1b75f19e1117f0cead1caaf6b00ddccadf3"><code>fa5ab1b</code></a> fix(style): fixes to watching nested and multiple styles on Stencil component...</li> <li><a href="https://github.com/ionic-team/stencil/commit/661120c6524f1bf2987547677c01654a8bfb199e"><code>661120c</code></a> feat(deps): upgrade rollup, commonjs plugin (<a href="https://redirect.github.com/ionic-team/stencil/issues/5274">#5274</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/6faf746990330da4369e0d73725b0fc2becebb33"><code>6faf746</code></a> feat(compiler): deprecate customResolveOptions config option (<a href="https://redirect.github.com/ionic-team/stencil/issues/5269">#5269</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/493250f150d93a3a687ba2d0f5b6640c1a50f36c"><code>493250f</code></a> chore(compiler): resolve strictNullCheck for element-decorator (<a href="https://redirect.github.com/ionic-team/stencil/issues/5264">#5264</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.10.0...v4.11.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [@stencil/sass](https://github.com/ionic-team/stencil-sass) from 3.0.8 to 3.0.9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil-sass/releases"><code>@stencil/sass</code>'s releases</a>.</em></p> <blockquote> <h2>v3.0.9</h2> <h2>What's Changed</h2> <h3>Bug Fixes</h3> <ul> <li>fix(plugin): normalize dependency path by <a href="https://github.com/christian-bromann"><code>@christian-bromann</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/459">ionic-team/stencil-sass#459</a></li> </ul> <h3>Dependency Updates</h3> <ul> <li>chore(deps): update dependency np to v9.2.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/451">ionic-team/stencil-sass#451</a></li> <li>chore(deps): update actions/setup-node action to v4.0.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/454">ionic-team/stencil-sass#454</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.9.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/455">ionic-team/stencil-sass#455</a></li> <li>chore(deps): update dependency prettier to v3.1.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/452">ionic-team/stencil-sass#452</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.9.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/456">ionic-team/stencil-sass#456</a></li> <li>chore(deps): update dependency npm to v10.3.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/457">ionic-team/stencil-sass#457</a></li> <li>chore(deps): update dependency prettier to v3.2.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/458">ionic-team/stencil-sass#458</a></li> <li>chore(deps): update node.js to v20.11.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/443">ionic-team/stencil-sass#443</a></li> <li>chore(deps): update dependency rollup to v4.9.5 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/442">ionic-team/stencil-sass#442</a></li> <li>chore(deps): update dependency prettier to v3.2.2 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/460">ionic-team/stencil-sass#460</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.10.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/462">ionic-team/stencil-sass#462</a></li> <li>chore(deps): update dependency terser to v5.27.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/464">ionic-team/stencil-sass#464</a></li> <li>chore(deps): update dependency prettier to v3.2.4 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/463">ionic-team/stencil-sass#463</a></li> <li>chore(build): improve build process by <a href="https://github.com/christian-bromann"><code>@christian-bromann</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/461">ionic-team/stencil-sass#461</a></li> <li>chore(deps): update dependency rollup to v4.9.6 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/465">ionic-team/stencil-sass#465</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.11.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/466">ionic-team/stencil-sass#466</a></li> <li>chore(deps): update dependency npm to v10.4.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/468">ionic-team/stencil-sass#468</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/christian-bromann"><code>@christian-bromann</code></a> made their first contribution in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/459">ionic-team/stencil-sass#459</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ionic-team/stencil-sass/compare/v3.0.8...v3.0.9">https://github.com/ionic-team/stencil-sass/compare/v3.0.8...v3.0.9</a></p> <h2>v3.0.9-0</h2> <h2>What's Changed</h2> <ul> <li>chore(deps): update dependency np to v9.2.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/451">ionic-team/stencil-sass#451</a></li> <li>chore(deps): update actions/setup-node action to v4.0.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/454">ionic-team/stencil-sass#454</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.9.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/455">ionic-team/stencil-sass#455</a></li> <li>chore(deps): update dependency prettier to v3.1.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/452">ionic-team/stencil-sass#452</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.9.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/456">ionic-team/stencil-sass#456</a></li> <li>chore(deps): update dependency npm to v10.3.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/457">ionic-team/stencil-sass#457</a></li> <li>chore(deps): update dependency prettier to v3.2.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/458">ionic-team/stencil-sass#458</a></li> <li>chore(deps): update node.js to v20.11.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/443">ionic-team/stencil-sass#443</a></li> <li>chore(deps): update dependency rollup to v4.9.5 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/442">ionic-team/stencil-sass#442</a></li> <li>chore(deps): update dependency prettier to v3.2.2 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/460">ionic-team/stencil-sass#460</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.10.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/462">ionic-team/stencil-sass#462</a></li> <li>fix(plugin): normalize dependency path by <a href="https://github.com/christian-bromann"><code>@christian-bromann</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/459">ionic-team/stencil-sass#459</a></li> <li>chore(deps): update dependency terser to v5.27.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/464">ionic-team/stencil-sass#464</a></li> <li>chore(deps): update dependency prettier to v3.2.4 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/463">ionic-team/stencil-sass#463</a></li> <li>chore(build): improve build process by <a href="https://github.com/christian-bromann"><code>@christian-bromann</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/461">ionic-team/stencil-sass#461</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/christian-bromann"><code>@christian-bromann</code></a> made their first contribution in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/459">ionic-team/stencil-sass#459</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil-sass/commit/75b82537555fb520fe667b6f6eed5f21854f5668"><code>75b8253</code></a> 3.0.9</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/b2ac91a7dbc9af0cc4fb03ca0692c92be6fbece1"><code>b2ac91a</code></a> chore(deps): update dependency npm to v10.4.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/468">#468</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/946e7322e57c38af52877807aa94f420a4dbc7d9"><code>946e732</code></a> chore(deps): update dependency <code>@stencil/core</code> to v4.11.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/466">#466</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/9da4825c7d7fc5052ed57ab892a9d6937255f63f"><code>9da4825</code></a> chore(deps): update dependency rollup to v4.9.6 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/465">#465</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/ca0d500ec66433accaf0584a62da1524068cd183"><code>ca0d500</code></a> 3.0.9-0</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/21e7a77ad2368c1322e2f6a6e4c631351e1cc0be"><code>21e7a77</code></a> chore(build): improve build process (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/461">#461</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/6774845febe10662dd291cdfc002517bb1fb5be8"><code>6774845</code></a> chore(deps): update dependency prettier to v3.2.4 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/463">#463</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/555401c8d7d74ec24feff8097428c9809d8146ed"><code>555401c</code></a> chore(deps): update dependency terser to v5.27.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/464">#464</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/3ef9e400c2501441e2895b5fd9cca73e6d872d38"><code>3ef9e40</code></a> fix(plugin): normalize dependency path (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/459">#459</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/fa5740376d37cc6e6ca0f2df94881f9607866d41"><code>fa57403</code></a> chore(deps): update dependency <code>@stencil/core</code> to v4.10.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/462">#462</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil-sass/compare/v3.0.8...v3.0.9">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.11.0 to 4.12.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🌅 4.12.0 (2024-01-29)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>hmr:</strong> allow changes to component decorators when using HMR (<a href="https://redirect.github.com/ionic-team/stencil/issues/5290">#5290</a>) (<a href="https://github.com/ionic-team/stencil/commit/656355fc753fe09128f6f20f33150123863839d8">656355f</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>runtime:</strong> automatically insert <code>key</code> attrs during compilation (<a href="https://redirect.github.com/ionic-team/stencil/issues/5143">#5143</a>) (<a href="https://github.com/ionic-team/stencil/commit/9c47438a9a727c9d21cc7441e022097a966bd60d">9c47438</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h1>🌅 <a href="https://github.com/ionic-team/stencil/compare/v4.11.0...v4.12.0">4.12.0</a> (2024-01-29)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>hmr:</strong> allow changes to component decorators when using HMR (<a href="https://redirect.github.com/ionic-team/stencil/issues/5290">#5290</a>) (<a href="https://github.com/ionic-team/stencil/commit/656355fc753fe09128f6f20f33150123863839d8">656355f</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>runtime:</strong> automatically insert <code>key</code> attrs during compilation (<a href="https://redirect.github.com/ionic-team/stencil/issues/5143">#5143</a>) (<a href="https://github.com/ionic-team/stencil/commit/9c47438a9a727c9d21cc7441e022097a966bd60d">9c47438</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/89816e1032c7dbd853e6a824d5cffeca0d6d4355"><code>89816e1</code></a> v4.12.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5302">#5302</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/ccaa7fd7ccb56f3849cf6753c7bac6cc99ee2401"><code>ccaa7fd</code></a> chore(deps): update dependency <code>@types/node</code> to v20.11.6 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5297">#5297</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/200d40ac5e5bd39856970eca9348ff37d7e706b6"><code>200d40a</code></a> chore(deps): update dependency dts-bundle-generator to v9.2.5 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5298">#5298</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/106dc0e2b6814e274e1c1728f206479d5fbdb41f"><code>106dc0e</code></a> chore(deps): update dependency esbuild to v0.19.12 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5299">#5299</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9c47438a9a727c9d21cc7441e022097a966bd60d"><code>9c47438</code></a> feat(runtime): automatically insert <code>key</code> attrs during compilation (<a href="https://redirect.github.com/ionic-team/stencil/issues/5143">#5143</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/278c336166e27d329fffb686f2ecb3185d156696"><code>278c336</code></a> chore(config): add some documentation to the <code>buildDist</code> option (<a href="https://redirect.github.com/ionic-team/stencil/issues/5296">#5296</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/e6d97fec9b6bdd12156e8aef9e458f4760958bae"><code>e6d97fe</code></a> chore(repo): add docs section to pr template (<a href="https://redirect.github.com/ionic-team/stencil/issues/5293">#5293</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/bdedd8289ebff8451b4db9a2f2ca21a30c492822"><code>bdedd82</code></a> chore(snc): resolve strictNullChecks for typescript-config (<a href="https://redirect.github.com/ionic-team/stencil/issues/5294">#5294</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/5ac2f5defd4413531efbfeb489b03f51238e5899"><code>5ac2f5d</code></a> chore(docs): add a step for creating a new version of the stencil docs (<a href="https://redirect.github.com/ionic-team/stencil/issues/5295">#5295</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/5f3e04f3d929c1fedcf90ef9df9f89b13cf17a04"><code>5f3e04f</code></a> chore(readme): remove broken image (<a href="https://redirect.github.com/ionic-team/stencil/issues/5291">#5291</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.11.0...v4.12.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#28913) Bumps [@capacitor/keyboard](https://github.com/ionic-team/capacitor-plugins) from 5.0.7 to 5.0.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/capacitor-plugins/releases"><code>@capacitor/keyboard</code>'s releases</a>.</em></p> <blockquote> <h2><code>@capacitor/keyboard</code><a href="https://github.com/5"><code>@5</code></a>.0.8</h2> <h2><a href="https://github.com/ionic-team/capacitor-plugins/compare/@capacitor/keyboard@5.0.7...@capacitor/keyboard@5.0.8">5.0.8</a> (2024-01-29)</h2> <p><strong>Note:</strong> Version bump only for package <code>@capacitor/keyboard</code></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/d5483ce9f666f1a38c25a11e63899fd35701ca45"><code>d5483ce</code></a> chore(release): publish [skip ci]</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/be9ff28e06a367feb58cff612e4f1409985664de"><code>be9ff28</code></a> docs: fix addListener links (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/2012">#2012</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/d8540feeb6fe6d3f19712720ef5c6569709187fe"><code>d8540fe</code></a> fix(screen-orientation) Add ScreenOrientationLockType (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/2005">#2005</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/e2cdf3538b9741c5ec394abb14516ceaf5e12d43"><code>e2cdf35</code></a> feat(browser): implement close() method for android</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/f9afbe9b03fefa13be3120158487fc685d199d69"><code>f9afbe9</code></a> fix(filesystem): requestPermissions not resolving (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1991">#1991</a>)</li> <li>See full diff in <a href="https://github.com/ionic-team/capacitor-plugins/compare/@capacitor/keyboard@5.0.7...@capacitor/keyboard@5.0.8">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…able options (#27940) Issue number: resolves #27965 --------- https://www.youtube.com/watch?v=a_m7jxrTlaw&list=PLIvujZeVDLMx040-j1W4WFs1BxuTGdI_b&index=3 <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> There is a lack of autocomplete support for AlertButton attribute of `role` (there may be similar situations for other components too, however, I was working on this component and found it). ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Support for autocomplete for the two types defined `cancel` and `destructive`, and also supports any arbitrary string if passed in. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> I suggest there to be some global interface similar to the following: ``` interface LooseAutocomplete<T extends string> = T | Omit<string, T>; ``` I referenced this great [video](https://youtu.be/a_m7jxrTlaw) from Matt @mattpocock --------- Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Issue number: Internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Several tests were still using the legacy form syntax. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Migrated tests in `core`, `angular`, and `vue` to use the modern form syntax (`react` did not have form controls). I opted not to migrate `item/test/highlight` and `item/test/counter` because those tests are going to be removed in the future once the deprecate item APIs are removed. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com> Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
github-actions
bot
added
package: core
liamdebeasi
requested review from
a team,
averyjohnston,
brandyscarney,
sean-perkins and
thetaPC
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information