Throw errors for invalid values in panner node constructor#80
Open
servo-wpt-sync wants to merge 750 commits intojdm:masterfrom
Open
Throw errors for invalid values in panner node constructor#80servo-wpt-sync wants to merge 750 commits intojdm:masterfrom
servo-wpt-sync wants to merge 750 commits intojdm:masterfrom
Conversation
The layout tests aren't testing much at the moment, as they're never served over HTTPS. This patch creates `.https` versions of the tests and reworks them to actually exercise the behavior of `__Host` and `__Secure` cookie prefixes. Bug: 843945 Change-Id: I31968133ca8846f3ffc4faec2339e3d0d03c77f8 Reviewed-on: https://chromium-review.googlesource.com/1179150 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#584016}
In StyleValueToCSSValue, when checking whether a certain CSSStyleValue matches the property in question, we now ask the registration (via CSSOMTypes) if the CSSStyleValue matches. If it doesn't match, we throw a TypeError like for normal properties. If it does match, the CSSStyleValue is stringified, tokenized, and set on the style rule as tokens. I have postponed support for <color> and <transform-function>, because CSSUnsupportedStyleValue currently does not handle registered custom properties at all. This is appropriate to fix in a separate CL. Note that, because the string version of StylePropertyMap.set also uses StyleValueToCSSValue, it will no longer be possible to set registered custom properties with a string--even if the syntax is matched. A subsequent CL will fix this. R=futhark@chromium.org Bug: 641877 Change-Id: Ib5c31640f81e957620339c9bdf617ab1af5d3d47 Reviewed-on: https://chromium-review.googlesource.com/1179153 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#584024}
… and computed styles Spec: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue BUG=873760 TEST=external/wpt/css/css-logical/logical-box-border-color.html TEST=external/wpt/css/css-logical/logical-box-border-shorthands.html TEST=external/wpt/css/css-logical/logical-box-border-style.html TEST=external/wpt/css/css-logical/logical-box-border-width.html TEST=external/wpt/css/css-logical/logical-box-inset.html TEST=external/wpt/css/css-logical/logical-box-margin.html TEST=external/wpt/css/css-logical/logical-box-padding.html Change-Id: I60fca339c419d1d19eb6b31f0426c11f9d1cf95f Reviewed-on: https://chromium-review.googlesource.com/1176084 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Anders Ruud <andruud@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#584027}
Created new dictionary TrustedTypePolicyOptions with callbacks and adjusted TrustedTypePolicyFactory and TrustedTypePolicy to accept the dictionary. Added createURL() and createScriptURL, and adjusted createHTML() in TrustedTypePolicyOptions. Bug: 739170 Change-Id: Ie63fdf90b5aac53188fcd8141c95d287c3e726fd Reviewed-on: https://chromium-review.googlesource.com/1167282 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Maja Kabus <kabusm@google.com> Cr-Commit-Position: refs/heads/master@{#584038}
For whatwg/html#3918. Several tests were removed as they no longer apply after the change in HTML. The expectations were reversed and moved to the new no-new-global.window.js file. Co-authored-by: Timothy Gu <timothygu99@gmail.com>
This CL updates the implementation and tests to be adapted versions of https://github.com/domenic/async-local-storage/tree/73580d0151f04849ca9e691807907e95c4d17d12/prototype. Change-Id: I9071883a6fef8ef97c405a9a749bf9c2d3cfb58a Reviewed-on: https://chromium-review.googlesource.com/1171573 Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584064}
…31363332762842ba327166bdc361c6fffc4858f . (web-platform-tests#12552) This contains two sets of changes from a single bug, [bug 1483685](https://bugzilla.mozilla.org/show_bug.cgi?id=1483685), by @dholbert, reviewed by @iyermihir.
This adds web-platform-tests for Network Error Logging. They should be suitable to upstream into the cross-platform WPT repo. Bug: 748549 Change-Id: I24098aeec8488c34a5f9239309264e9534dca6e4 Reviewed-on: https://chromium-review.googlesource.com/1106518 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#584093}
- Before registering the fetch make sure there is enough quota to complete the fetch. - Abandon the fetch if there is no quota to persist the response. TBR=avi@chromium.org Bug: 872735 Change-Id: I2a8348209989f85722e20bd8a5bccc75015fbf51 Reviewed-on: https://chromium-review.googlesource.com/1169202 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#584099}
R=jsbell@chromium.org Bug: 720919 Change-Id: I88447c05f40937eb7f73cc2399ce5b1a025e1911 Reviewed-on: https://chromium-review.googlesource.com/1179942 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#584105}
Bug: 739170 Change-Id: Ia0ec627627b8ad6b208eb9351f3e7786e6d2c9b2 Reviewed-on: https://chromium-review.googlesource.com/1177752 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#584108}
New class TrustedScript added as a C++ implementation of JS TrustedScript. Bug: 739170 Change-Id: Ife70f8838aefa6bb4aac45f09639464c19de6e1b Reviewed-on: https://chromium-review.googlesource.com/1168494 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#584197}
This patch implements navigator.getWakeLock(WakeLockType) and other necessary interfaces such as WakeLock and WakeLockRequest to provide acesss to Screen wakelock for now. Latest WakeLock API spec can be seen here, https://www.w3.org/TR/wake-lock. Intent to Implement, https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/KMNZmMF1_H4 Bug: 257511 Change-Id: I7fa4d0f7f287d7497b48f583e18e0ca5ca39e662 Reviewed-on: https://chromium-review.googlesource.com/918062 Commit-Queue: Mrunal Kapade <mrunal.kapade@intel.com> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#584239}
From web-platform-tests#12465 (comment) "The CSS build system finds tests (based on <link rel=help>), moves them to the destination direction (roughly one per spec), and then also moves any files in an adjacent support directory. " The support directory for the parsing test files is now adjacent to those files. The parsing tests previously in box-shadow-syntax-001.html are moved into parsing/box-shadow-[in]valid.html, for consistency with other parsing tests, and to avoid the need for an extra copy of parsing-testcommon.js fixes web-platform-tests#12419
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1467344 gecko-commit: d0c3ab5c291b0743911fc3b62938e3a2c130f20c gecko-integration-branch: mozilla-inbound gecko-reviewers: hiro
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1467344 gecko-commit: 37038c5ebcb4450b1a008743be8580c140e3102b gecko-integration-branch: mozilla-inbound gecko-reviewers: hiro
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1467344 gecko-commit: 0394a44b3955e4230a79cd8226a5cd779cf068ee gecko-integration-branch: mozilla-inbound gecko-reviewers: hiro
This is a collection of fix-ups to the corresponding tests for CSS animations to apply the same sort of naming etc. that we have now applied to CSS transitions tests. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1467344 gecko-commit: 877cdf25b483aaccf75c0ef6821194523dcce259 gecko-integration-branch: mozilla-inbound gecko-reviewers: hiro
This brings us into alignment with the Fetch Standard as well as Firefox and Edge. Bug: 165083, 874536 Change-Id: Id06d07d301aeae8bd0c48bfe94df68cf1ed68db9 Reviewed-on: https://chromium-review.googlesource.com/1176263 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584357}
The format itself hasn't changed, but incremental updating from the current version doesn't work after web-platform-tests#12381. Fixes web-platform-tests#12559.
The legend should mask the border at its static position, but Edge moves the mask if it is relatively positioned.
We were previously considering the grammar for conditionals in wpt manifests to be something like: "if " expr ":" string This excluded the possibilty of complex values on the RHS. Here we change it to the more obvious (and intended) "if " expr ":" value Differential Revision: https://phabricator.services.mozilla.com/D3127 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1482496 gecko-commit: ae52877671adab5f4a00e7887c6806dc26aa7cfa gecko-integration-branch: autoland gecko-reviewers: ato
- Added error handling as suggested in web-platform-tests#12162 - changed XHR calls to FetchAPI - changed async tests to Promise tests - corrected the existing redirect tests and reported bug: crbug/872285 - removed Same-Site and Cross-Origin XSLT tests as they seemed to fail because loading cross origin xslt is not supported "Unsafe attempt to load URL from frame" (No idea why they passed before) - added two test cases for multiple redirects. The idea is that the Sec-Metadata header should be "downgraded" to less secure and should carry the value to the end. If a cross-origin domain controls a redirect at any point of the redirect chain, then the final requests are potentially influenced by the attacker. - (Same-Origin -> Cross-Site -> Same-Origin -> Same-Origin) -> site=cross-site - (Same-Origin -> Same-Site -> Same-Origin -> Same-Origin) -> site=same-site Change-Id: I591af1948cc1f16e3b5c44f51020149e43fc2746 Reviewed-on: https://chromium-review.googlesource.com/1193953 Commit-Queue: Maciek Trzos <mtrzos@google.com> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#587556}
…m-tests#12759) Previously it threw ValueError due to the unescaped % in the error message.
Also remove author from tests. The commit log is more reliable anyway. R=foolip@chromium.org Change-Id: Ibd5a9f7089a8d10bbe77db071b2e1147b05817f4 Reviewed-on: https://chromium-review.googlesource.com/1196429 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#587548}
Moved the layout tests under third_party/WebKit/LayoutTests/imagecapture/ to third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/ Moved the layout tests under fast/imagecapture to wpt and suffixed some file names with -fast.html to avoid name collision. ImageCapture-creation.html was renamed to ImageCapture-creation.https.html as it needed to be served over https Moved third_party/WebKit/LayoutTests/imagecapture/resources/imagecapture-helpers.js to third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/resources/imagecapture-helpers.js and extended it by adding a wrapper promise test, image_capture_test. Copy the auto generated image_capture.mojom.js to wpt/resources/chromium/mock-imagecapture.js used a flag called "scramble_message_ids = false" to the mojom compiler. Used the testharness from wpt/ No new tests have been added. BUG=706434 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7de5b87b60396da841dda490da02bce800fcb793 Reviewed-on: https://chromium-review.googlesource.com/1165355 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#587144}
This queues a report through the Reporting API whenever send() is called on a synchronous XMLHttpRequest object from a frame in which sync-xhr is not allowed according to feature policy. Bug: 867471 Change-Id: If778ea5517fb5728992fe8287b278d1af729902f Reviewed-on: https://chromium-review.googlesource.com/1191404 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#587583}
Whilst it is logically correct to use 408 for the ErrorStatus::ScriptTimeout and ::Timeout errors, it causes a collision with HTTP semantics implement in HTTP clients. To support Keep-Alive we allow retries in HTTP clients and if a client sees code 408 it thinks that the server has gone away and retries the request. This causes WebDriverCommand::ExecuteScript, ::Get, and ::Refresh commands to be sent twice with some HTTP clients. This is a backwards incompatible change to WebDriver in order to not break HTTP/1.1 Keep-Alive. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1484941 gecko-commit: 72a737dd8639ab72ddc96d1144f44b06507b915e gecko-integration-branch: mozilla-inbound gecko-reviewers: whimboo
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1485580 gecko-commit: 1fd335726c0088e8ffe303beff533442c973b083 gecko-integration-branch: mozilla-inbound gecko-reviewers: jgraham
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1486572 gecko-commit: 3eb891993d3e0802ae958cb8256d4e44c3b0817e gecko-integration-branch: mozilla-inbound
We were previously using the original test url as the lhs for each comparison after the top level, rather than the previous rhs url as expected. Differential Revision: https://phabricator.services.mozilla.com/D4081 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1485668 gecko-commit: 0cd882a506cfa9c7489160d06437361430e0aa65 gecko-integration-branch: autoland gecko-reviewers: ato
* tests for MerchantValidationEvent * contructor tests, including validationURL * complete() method * Test fixup
This queues a report through the Reporting API whenever navigator.requestMIDIAccess is invoked from a frame in which the 'midi`' feature is not allowed according to feature policy. Bug: 867471 Change-Id: Ib7966a3721067fcf7a325d75377178caaa4b327a Reviewed-on: https://chromium-review.googlesource.com/1195703 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#587617}
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1486000 gecko-commit: 18c0aff587fa935a8149f83d58664e77c35e598a gecko-integration-branch: mozilla-inbound gecko-reviewers: bbouvier
Consider the following case: <span style="position:relative; left:-100px;"> <div style="display:inline-block; position:absolute;"></div> </span> In our implementation the absolute positioned element will have a counter offset applied, to ignore the negative offset on its rel-pos parent. The compensation was added in https://codereview.chromium.org/423173003/ which wasn't covered by the added test, and isn't consistent with other browser implementations. (Checked with Safari, IE, and Firefox.) BUG=398164 Change-Id: I44127ff42446a7483d7e4ebb3197ecdc915db39d Reviewed-on: https://chromium-review.googlesource.com/1195084 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587745}
…tio for responsive images The CL https://chromium.googlesource.com/chromium/src/+/bd4c33b5e81d495ecdac66b0375924d9565330cb did not handle responsive images correctly. This CL resets overridden_intrinsic_size_: When source is chosen using W descriptor, 'sizes' sets the new width of the overridden_intrinsic_size_, and the new height is calculated by the aspect ratio defined by the intrinsicSize attribute. Bug: 874629 Change-Id: I16b2f6c2fb9ae741144ba509c57f1e033c8cdc17 Reviewed-on: https://chromium-review.googlesource.com/1195801 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#587774}
The new Baseline Alignment algorithm states that items with sizing cyclic dependencies must be excluded from any baseline context they participate in. One of these cyclic dependencies can happen with intrinsic sized grid areas and relative items. The grid spec states [1] that flex-sized tracks should be considered as content-sized when the grid container has an indefinite size. We were using the AvailableSize(direction) function to determine whether the grid container is indefinite or not. However, this function may provide different results during the different phases of the grid layout logic. This issue causes assert violations like the one described in the bugs listed below. The new Baseline Alignment logic is now integrated in the Grid Track sizing algorithm. Hence, we need to ensure that an item that participates in any baseline alignment context during the track sizing also does during the alignment phase, at the end of the grid layout logic. In order to achieve that, this CL forces a new computation of the Baseline offsets during the step 3 of the Grid sizing algorith, since during this step the available space is not indefinite anymore. It's worth mentioning that this change assumes the issue grid items being excluded and included of Baseline Context during the different phases of the Grid sizing algorithm, which I hope we can clarify in the issue [2] I filed for the CSS WG. [1] https://drafts.csswg.org/css-grid/#fr-unit [2] w3c/csswg-drafts#3046 Bug: 867833, 874861, 876593 Change-Id: I668d399b920c9280a8e20b3e8362f562eded4770 Reviewed-on: https://chromium-review.googlesource.com/1177757 Reviewed-by: Sergio Villar <svillar@igalia.com> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#587799}
The Storage API [1] defines the "persistent-storage" string to allow querying the state of the permission. Plug this into the Permission API [2] implementation and add a web platform test. [1] https://storage.spec.whatwg.org/ [2] https://w3c.github.io/permissions Intent to Ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/FRAmGlAoDTY/discussion ChromeStatus: https://www.chromestatus.com/feature/4770049554382848 Bug: 878525 Change-Id: Ia12fb43676e04e7e60ad58b5ffbd7ee22f78ffc4 Reviewed-on: https://chromium-review.googlesource.com/1194106 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#587839}
Our current implementation of canvas textBaseline alignment for top middle and bottom doesn't do what the spec says it should, i.e. align with the EM square. https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-textbaseline This has been a bug on FF side for quite some years: https://bugzilla.mozilla.org/show_bug.cgi?id=737852 This change fixes this misalignment by using the EM square ascent and descent from SimpleFontData instead of the font's max ascent/descent. Also fixing the EM related metrics in canvas TextMetrics. Bug:607053,277215 Change-Id: Id6374e6fcd4e46fa989a7e23a80dc1f5bf961b94 Reviewed-on: https://chromium-review.googlesource.com/1194494 Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#587855}
…an-inline-block Add test for specifying column-span:all on an inline-block.
This CL adds all remaining tests from https://github.com/abarth/http-state/tree/master/tests. Not all of them pass, but all of them run consistently with the same results. This also adds a lot of documentation - in code and when running a server. By navigating to <server>/cookies/http-state/resources/cookie-setter.py All tests are gathered and run. The shown document explains the usage of the server for debugging purposes. Change-Id: I4a75655704dddc213a3f3b6fa26beeb14acf3338 Reviewed-on: https://chromium-review.googlesource.com/1021577 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583606}
servo-wpt-sync
force-pushed
the
servo_export_21555
branch
4 times, most recently
from
24b9b26 to
3738c83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed in servo/servo#21555.