luaengine: fix font aspect-ratio in multi-screens games

[lucab]

Do not assume ui-container aspect when drawing on other containers.
This fixes LUA draw_text() in multi-screens game, where the font
aspect for each screen is wrongly computed on the aggregated target.

Signed-off-by: Luca Bruno lucab@debian.org

[galibert]

Could you fold the two instances of container testing into a
get_aspect(container) ui_manager method (or whichever name you want)?

OG.

On Thu, Feb 12, 2015 at 10:53 AM, Luca Bruno notifications@github.com
wrote:

Do not assume ui-container aspect when drawing on other containers.
This fixes LUA draw_text() in multi-screens game, where the font
aspect for each screen is wrongly computed on the aggregated target.

Signed-off-by: Luca Bruno lucab@debian.org

You can view, comment on, or merge this pull request online at:

#129
Commit Summary

• ui: use per-container pixel aspect (draw_text bugfix)

File Changes

• M src/emu/screen.c
  https://github.com/mamedev/mame/pull/129/files#diff-0 (24)
• M src/emu/screen.h
  https://github.com/mamedev/mame/pull/129/files#diff-1 (1)
• M src/emu/ui/ui.c
  https://github.com/mamedev/mame/pull/129/files#diff-2 (14)

Patch Links:

• https://github.com/mamedev/mame/pull/129.patch
• https://github.com/mamedev/mame/pull/129.diff

—
Reply to this email directly or view it on GitHub
#129.

[lucab]

I had a look at it before sending this, but I have some doubts. I see that ui container has an associated render_target(with orientation, pixel aspect, etc), is there any equivalent for a generic render_container/screen? Otherwise, the folded method will still have to special case for the ui container.

[galibert]

I have no idea :-) My problem is not with the special casing, it's with
having the same special casing code in two different methods of the same
class.

OG.

On Thu, Feb 12, 2015 at 12:01 PM, Luca Bruno notifications@github.com
wrote:

I had a look at it before sending this, but I have some doubts. I see that
ui container has an associated render_target(with orientation, pixel
aspect, etc), is there any equivalent for a generic
render_container/screen? Otherwise, the folded method will still have to
special case for the ui container.

—
Reply to this email directly or view it on GitHub
#129 (comment).

[lucab]

I see, then probably you'd prefer this minimally invasive version with a single method and a default parameter...

[lucab]

I've folded the two methods back into render_manager::ui_aspect(), but this PR became stale in the meanwhile. As I've piled up some other luaengine fixes and a bit of doc in the meanwhile, let me close this old PR and open a new one with all the fresh stuff.