Two quick debugger fixes #136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for making another pull request so quickly, but I found a way to crash the debuggers and fixed it.
The to achieve the crash that this fixes, open a memory window, select two bytes per chunk, decrease bytes per line until there are only three chunks (six bytes) on each line, then try to switch to eight bytes per line. It's not something people would hit every day, but it's still a way to crash using any of the debuggers.
The other change is just touching up user-friendliness on OSX: if there's only one chunk per line displayed in a memory view, the menu item to decrease bytes per line will be disabled so you get visual feedback that it won't do anything (or audible feedback if you try using the keyboard shortcut).