VGM dump feature #134
Closed
VGM dump feature #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
.."preserve these decades of video-game history"... |
|
ValleyBell was the author of that text change. I think the difference is only subtle. Which version do you consider to be more precise? The original one or the one edited by ValleyBell ? I would be glad to rethink this based on your feedback. |
|
Anyway... It is not really a huge issue at all. But I'll be glad to hear your opinion on the topic. |
|
Right now I'm working on updating this code to the latest master. The files in the following list seem to be new sound devices that do not yet output VGM. I'll first make sure the current feature builds nicely after rebasing to master and later I'll focus on updating these:
|
|
Also these files have issues and need to be fixed:
|
felipesanches
force-pushed
the
vgmdump
branch
2 times, most recently
from
f8ea8e7 to
4024134
Compare
|
I removed a reference to an unused rf5c164. I'm gradually trying to keep this patch as clean / minimal / non-intrusive as possible. Actual development is being done on the vgmdump_development branch (https://github.com/felipesanches/mame/tree/vgmdump_development) while in this branch I'll keep rebasing and amending a single commit that should cleanly apply against master. |
felipesanches
force-pushed
the
vgmdump
branch
2 times, most recently
from
24d7a84 to
ca5d537
Compare
felipesanches
force-pushed
the
vgmdump
branch
from
ca5d537 to
a9679e2
Compare
|
I'm not sure why this is still sitting in our pull requests; neither the patch nor the upstream repo have been updated for 9 months, and there's been no indication that we'd want to accept it anyway. Closing. |
Zoltan45
pushed a commit
to Zoltan45/mame-mkp
that referenced
this pull request
Jun 28, 2021
version bump: mame 0.218
ICEknigh7
added a commit
to ICEknigh7/mame
that referenced
this pull request
Jun 8, 2022
- Balalín (type-in, MicroHobby mamedev#125) [Ignacio Prini] - Magnus Zone (type-in, MicroHobby mamedev#126) [Ignacio Prini] - Oráculo Egipcio (type-in, MicroHobby mamedev#127) [Ignacio Prini] - Demolition (type-in, MicroHobby mamedev#128) [Ignacio Prini] - Basket Trainer (type-in, MicroHobby mamedev#129) [Ignacio Prini] - Galaxy Fun (type-in, MicroHobby mamedev#130) [Ignacio Prini] - Micro Draw (type-in, MicroHobby mamedev#131, mamedev#132) [Ignacio Prini] - El Alambrista (type-in, MicroHobby mamedev#133) [Ignacio Prini] - Ranamirez (type-in, MicroHobby mamedev#134) [Ignacio Prini] - Fórmula Suicida (type-in, MicroHobby mamedev#135) [Ignacio Prini] - Phantasmas (type-in, MicroHobby mamedev#136) [Ignacio Prini] - Dardos (type-in, MicroHobby mamedev#137) [Ignacio Prini] - S.E.M.I.S.I.S. (type-in, MicroHobby mamedev#138, mamedev#139) [Ignacio Prini] - Alley's Gun (type-in, MicroHobby mamedev#140) [Ignacio Prini] - Kleingeld (type-in, MicroHobby mamedev#141, mamedev#142) [Ignacio Prini] - Caribe’s Day (type-in, MicroHobby mamedev#143) [Ignacio Prini] - Rally (type-in, MicroHobby mamedev#144) [Ignacio Prini] - La Profecía (type-in, MicroHobby mamedev#145) [Ignacio Prini] - Mine Alert (type-in, MicroHobby mamedev#146, mamedev#147) [Ignacio Prini] - Freddy (type-in, MicroHobby mamedev#148) [Ignacio Prini] - Russian's Attack (type-in, MicroHobby mamedev#149, mamedev#150) [Ignacio Prini] - En Ruta (type-in, MicroHobby mamedev#151) [Ignacio Prini] - Zinco (type-in, MicroHobby mamedev#152) [Ignacio Prini] - Ruffo’s Dream (type-in, MicroHobby mamedev#153) [Ignacio Prini] - Crozet (type-in, MicroHobby mamedev#154) [Ignacio Prini] - Rock Animation (type-in, MicroHobby mamedev#155) [Ignacio Prini] - Bunker (type-in, MicroHobby mamedev#156) [Ignacio Prini] - Telepuzzle (type-in, MicroHobby mamedev#157) [Ignacio Prini] - Golfo Pérsico (type-in, MicroHobby mamedev#158) [Ignacio Prini] - Mad Drivers (type-in, MicroHobby mamedev#159) [Ignacio Prini] - Bowling Star (type-in, MicroHobby mamedev#160) [Ignacio Prini] - Gas-Car (type-in, MicroHobby mamedev#161) [Ignacio Prini] - Ghost Like (type-in, MicroHobby mamedev#162) [Ignacio Prini] - Sky Invaders (type-in, MicroHobby mamedev#163) [Ignacio Prini] - Perico Jones (type-in, MicroHobby mamedev#164) [Ignacio Prini] - Brad Zotes (type-in, MicroHobby mamedev#165) [Ignacio Prini] - Striker (type-in, MicroHobby mamedev#166) [Ignacio Prini] - Indy (type-in, MicroHobby mamedev#167) [Ignacio Prini] - Topin (type-in, MicroHobby mamedev#168) [Ignacio Prini] - Starlike (type-in, MicroHobby mamedev#169) [Ignacio Prini] - Tres en Raya (type-in, MicroHobby mamedev#170) [Ignacio Prini] - Goteras (type-in, MicroHobby mamedev#171) [Ignacio Prini] - Parvision (type-in, MicroHobby mamedev#172) [Ignacio Prini] - Furax (type-in, MicroHobby mamedev#173) [Ignacio Prini] - Duck Shooting (type-in, MicroHobby mamedev#174) [Ignacio Prini] - Nomen Rosae (type-in, MicroHobby mamedev#175) [Ignacio Prini] - PunkyMan (type-in, MicroHobby mamedev#176) [Ignacio Prini] - El Retorno del Yedi (type-in, MicroHobby mamedev#177) [Ignacio Prini] - Sky Warrior (type-in, MicroHobby mamedev#178) [Ignacio Prini] - Reptkon (type-in, MicroHobby mamedev#179) [Ignacio Prini] - Intro (type-in, MicroHobby mamedev#180) [Ignacio Prini] - Keops (type-in, MicroHobby mamedev#181) [Ignacio Prini] - Sir Gawain (type-in, MicroHobby mamedev#182) [Ignacio Prini] - Snake (type-in, MicroHobby mamedev#183) [Ignacio Prini] - Microbowl (type-in, MicroHobby mamedev#184) [Ignacio Prini] - God Save the Punk (type-in, MicroHobby mamedev#185) [Ignacio Prini]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am maintaining a branch at https://github.com/felipesanches/mame/commits/vgmdump with the VGM dump functionality. Since the feature has been ported to MAME/MESS 0.156, the work of merging the 0.158 codebase was trivial requiring no further patching. It merged automatically.
Apparently, further patching may only be needed once new sound emulation cores eventually get added to the MAME/MESS codebase. Otherwise, it seems straightforward to maintain.
Please, either merge this into official MAME/MESS codebase or simply leave this pull request open so that interested people can easily see it.