Skip to content

Conversation

LuigiBlood
Copy link
Contributor

.... You can select the device on each controller port.

…ort. You can select the device on each controller port.
@cuavas
Copy link
Member

cuavas commented May 2, 2015

Is it really a good idea to do the mouse support this way? I would've thought making it a slot device would be a better idea, making it easier to add other controller types (e.g. Densha De Go! controller) later. Also, introducing global variables for the mouse is a red flag. New code shouldn't be introducing things like that.

@etabeta78
Copy link
Contributor

This approach is the "legacy way" to add input devices (still used e.g. by
megadrive), adopted when there were no slot devices available. I agree that
it would be better to use slot devices, of course, but maybe the patch can
be accepted and cleaned it up afterwards?

f.

On Sat, May 2, 2015 at 4:27 AM, Vas Crabb notifications@github.com wrote:

Is it really a good idea to do the mouse support this way? I would've
thought making it a slot device would be a better idea, making it easier to
add other controller types (e.g. Densha De Go! controller) later. Also,
introducing global variables for the mouse is a red flag. New code
shouldn't be introducing things like that.


Reply to this email directly or view it on GitHub
#169 (comment).

@cuavas
Copy link
Member

cuavas commented May 2, 2015

Using globals for mouse input is still a bad sign - at the very least that should be cleaned up before accepting the patch.

@etabeta78
Copy link
Contributor

oh yeah, those should just go inside the driver class, of course :)
I was referring only to the PORT_CONFIG stuff...

f.

On Sat, May 2, 2015 at 9:11 AM, Vas Crabb notifications@github.com wrote:

Using globals for mouse input is still a bad sign - at the very least that
should be cleaned up before accepting the patch.


Reply to this email directly or view it on GitHub
#169 (comment).

@LuigiBlood
Copy link
Contributor Author

I didn't know about slot devices. And about the mouse input... it was a pain to do. I don't know how to do that without globals. I only looked at the Amiga files and Apple files.

@cuavas
Copy link
Member

cuavas commented May 2, 2015

OK, good enough for me. The globals have been eliminated, members are initialised on the right spot, multiple mouses should work.

cuavas added a commit that referenced this pull request May 2, 2015
Added 4 controller support for N64/N64DD, as well as rough mouse support...
@cuavas cuavas merged commit c18f104 into mamedev:master May 2, 2015
ICEknigh7 added a commit to ICEknigh7/mame that referenced this pull request Jun 8, 2022
- Balalín (type-in, MicroHobby mamedev#125) [Ignacio Prini]
- Magnus Zone (type-in, MicroHobby mamedev#126) [Ignacio Prini]
- Oráculo Egipcio (type-in, MicroHobby mamedev#127) [Ignacio Prini]
- Demolition (type-in, MicroHobby mamedev#128) [Ignacio Prini]
- Basket Trainer (type-in, MicroHobby mamedev#129) [Ignacio Prini]
- Galaxy Fun (type-in, MicroHobby mamedev#130) [Ignacio Prini]
- Micro Draw (type-in, MicroHobby mamedev#131, mamedev#132) [Ignacio Prini]
- El Alambrista (type-in, MicroHobby mamedev#133) [Ignacio Prini]
- Ranamirez (type-in, MicroHobby mamedev#134) [Ignacio Prini]
- Fórmula Suicida (type-in, MicroHobby mamedev#135) [Ignacio Prini]
- Phantasmas (type-in, MicroHobby mamedev#136) [Ignacio Prini]
- Dardos (type-in, MicroHobby mamedev#137) [Ignacio Prini]
- S.E.M.I.S.I.S. (type-in, MicroHobby mamedev#138, mamedev#139) [Ignacio Prini]
- Alley's Gun (type-in, MicroHobby mamedev#140) [Ignacio Prini]
- Kleingeld (type-in, MicroHobby mamedev#141, mamedev#142) [Ignacio Prini]
- Caribe’s Day (type-in, MicroHobby mamedev#143) [Ignacio Prini]
- Rally (type-in, MicroHobby mamedev#144) [Ignacio Prini]
- La Profecía (type-in, MicroHobby mamedev#145) [Ignacio Prini]
- Mine Alert (type-in, MicroHobby mamedev#146, mamedev#147) [Ignacio Prini]
- Freddy (type-in, MicroHobby mamedev#148) [Ignacio Prini]
- Russian's Attack (type-in, MicroHobby mamedev#149, mamedev#150) [Ignacio Prini]
- En Ruta (type-in, MicroHobby mamedev#151) [Ignacio Prini]
- Zinco (type-in, MicroHobby mamedev#152) [Ignacio Prini]
- Ruffo’s Dream (type-in, MicroHobby mamedev#153) [Ignacio Prini]
- Crozet (type-in, MicroHobby mamedev#154) [Ignacio Prini]
- Rock Animation (type-in, MicroHobby mamedev#155) [Ignacio Prini]
- Bunker (type-in, MicroHobby mamedev#156) [Ignacio Prini]
- Telepuzzle (type-in, MicroHobby mamedev#157) [Ignacio Prini]
- Golfo Pérsico (type-in, MicroHobby mamedev#158) [Ignacio Prini]
- Mad Drivers (type-in, MicroHobby mamedev#159) [Ignacio Prini]
- Bowling Star (type-in, MicroHobby mamedev#160) [Ignacio Prini]
- Gas-Car (type-in, MicroHobby mamedev#161) [Ignacio Prini]
- Ghost Like (type-in, MicroHobby mamedev#162) [Ignacio Prini]
- Sky Invaders (type-in, MicroHobby mamedev#163) [Ignacio Prini]
- Perico Jones (type-in, MicroHobby mamedev#164) [Ignacio Prini]
- Brad Zotes (type-in, MicroHobby mamedev#165) [Ignacio Prini]
- Striker (type-in, MicroHobby mamedev#166) [Ignacio Prini]
- Indy (type-in, MicroHobby mamedev#167) [Ignacio Prini]
- Topin (type-in, MicroHobby mamedev#168) [Ignacio Prini]
- Starlike (type-in, MicroHobby mamedev#169) [Ignacio Prini]
- Tres en Raya (type-in, MicroHobby mamedev#170) [Ignacio Prini]
- Goteras (type-in, MicroHobby mamedev#171) [Ignacio Prini]
- Parvision (type-in, MicroHobby mamedev#172) [Ignacio Prini]
- Furax (type-in, MicroHobby mamedev#173) [Ignacio Prini]
- Duck Shooting (type-in, MicroHobby mamedev#174) [Ignacio Prini]
- Nomen Rosae (type-in, MicroHobby mamedev#175) [Ignacio Prini]
- PunkyMan (type-in, MicroHobby mamedev#176) [Ignacio Prini]
- El Retorno del Yedi (type-in, MicroHobby mamedev#177) [Ignacio Prini]
- Sky Warrior (type-in, MicroHobby mamedev#178) [Ignacio Prini]
- Reptkon (type-in, MicroHobby mamedev#179) [Ignacio Prini]
- Intro (type-in, MicroHobby mamedev#180) [Ignacio Prini]
- Keops (type-in, MicroHobby mamedev#181) [Ignacio Prini]
- Sir Gawain (type-in, MicroHobby mamedev#182) [Ignacio Prini]
- Snake (type-in, MicroHobby mamedev#183) [Ignacio Prini]
- Microbowl (type-in, MicroHobby mamedev#184) [Ignacio Prini]
- God Save the Punk (type-in, MicroHobby mamedev#185) [Ignacio Prini]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants