[Discussion] clang-format-10#2177
Merged
Merged
Conversation
rhaschke
requested review from
IanTheEngineer,
bmagyar,
gavanderhoorn,
henningkayser,
jrgnicho,
mamoll,
mikeferguson,
mlautman,
tylerjw and
v4hn
as code owners
tylerjw
approved these changes
Aug 3, 2020
Member
tylerjw
left a comment
tylerjw
left a comment
There was a problem hiding this comment.
lgtm, will need to be rebased.
Member
I pushed a rebased branch to #2169 |
Allow some excess characters per line if that improves readability.
rhaschke
force-pushed
the
clang-format-10
branch
from
e6a9b22 to
142c0d8
Compare
rhaschke
force-pushed
the
clang-format-10
branch
from
142c0d8 to
f69a324
Compare
Codecov Report
@@ Coverage Diff @@
## master #2177 +/- ##
==========================================
+ Coverage 57.73% 57.77% +0.04%
==========================================
Files 326 326
Lines 25629 25621 -8
==========================================
+ Hits 14797 14803 +6
+ Misses 10832 10818 -14
Continue to review full report at Codecov.
|
henningkayser
approved these changes
Aug 11, 2020
Contributor
Author
|
As there was sufficient consent to merge this as early as possible, I'm going to merge this now. |
Merged
k-okada
added a commit
to ros-perception/opencv_apps
that referenced
this pull request
Sep 26, 2021
sjahr
added a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding to #2169, I tweaked the clang-format config even more.