Skip to content

Add functions to generate properties from frontend api - #9989

Closed
cg2121 wants to merge 4 commits into
obsproject:masterfrom
cg2121:frontend-api-props-view
Closed

Add functions to generate properties from frontend api#9989
cg2121 wants to merge 4 commits into
obsproject:masterfrom
cg2121:frontend-api-props-view

Conversation

@cg2121

@cg2121 cg2121 commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

Description

Adds functions to the frontend api to generate a properties widget. This is useful so frontend plugins no longer have to link to UI files.

Motivation and Context

Got sick of dealing with cmake files in frontend plugins.

How Has This Been Tested?

Tested with script properties. Still need to be tested with Decklink and AJA plugins.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@cg2121 cg2121 mentioned this pull request Dec 11, 2023
6 tasks
This adds a properties view constructor that constructs a view
by type of object.
This is needed so frontend plugins don't have to link to UI files.
@cg2121
cg2121 force-pushed the frontend-api-props-view branch from fef0054 to dfe04f2 Compare December 11, 2023 12:52
@cg2121
cg2121 force-pushed the frontend-api-props-view branch from dfe04f2 to 70b438b Compare December 11, 2023 13:05
@cg2121 cg2121 added kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. kind/cleanup Non-breaking change which makes code smaller or more readable labels Dec 11, 2023
@tytan652

Copy link
Copy Markdown
Collaborator

I don't wish to see more "Qt" frontend-api and the property view becoming a "stable" API.

@norihiro

Copy link
Copy Markdown
Contributor

Decklink has its own UI to output preview and program to decklink-output. AJA has its own UI to output preview and program to aja-output. Majority of the code was just copied from decklink-output-ui to aja-output-ui. So does NDI.
Instead of improving the frontend plugins, I think the better implementation would be having a unified code in UI to setup preview, program, and probably sources to any outputs.

@cg2121

cg2121 commented Dec 16, 2023

Copy link
Copy Markdown
Contributor Author

Closing, as this is just a band-aid around the problem. Like @norihiro said, we need a plugin agnostic UI for outputs.

@cg2121 cg2121 closed this Dec 16, 2023
@cg2121
cg2121 deleted the frontend-api-props-view branch December 16, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Non-breaking change which makes code smaller or more readable kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants