-
Notifications
You must be signed in to change notification settings - Fork 129
fix(pegboard): continue exporting metrics even if fetching actor fails #2520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying rivet with
|
| Latest commit: |
3e0b88b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6e009397.rivet.pages.dev |
| Branch Preview URL: | https://05-31-fix-pegboard-continue.rivet.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
3e0b88b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae06cb93.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://05-31-fix-pegboard-continue.rivet-hub-7jb.pages.dev |
Deploying rivet-studio with
|
| Latest commit: |
3e0b88b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://23f004ab.rivet-studio.pages.dev |
| Branch Preview URL: | https://05-31-fix-pegboard-continue.rivet-studio.pages.dev |
dff268d to
4527a1a
Compare
a6a6179 to
3e0b88b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Enhances error handling in the pegboard metrics collection service to ensure continuous metrics export even when actor fetches fail. The changes introduce an allow_errors parameter across multiple components.
- Added
allow_errors: trueinpegboard/standalone/usage-metrics-publish/src/lib.rsto continue metrics collection despite actor fetch failures - Implemented strict error handling (
allow_errors: false) in actor API endpoints to maintain data integrity - Added error handling logic in
pegboard_actor_getoperation to log warnings and continue processing whenallow_errorsis true - Modified actor fetching stream to handle failures gracefully while maintaining metrics collection for available actors
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| /// path endpoint. | ||
| pub endpoint_type: Option<crate::types::EndpointType>, | ||
|
|
||
| pub allow_errors: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Missing documentation for allow_errors field to explain when it should be used and potential implications.
| pub allow_errors: bool, | |
| /// When true, errors fetching individual actors will be logged and skipped instead of failing the entire operation. | |
| /// This is useful for bulk operations where partial failures are acceptable. | |
| pub allow_errors: bool, |
Merge activity
|
#2520) <!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->

Changes