Skip to content

Conversation

@NathanFlurry
Copy link
Member

Changes

Copy link
Member Author

NathanFlurry commented Jun 2, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 2, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e0b88b
Status: ✅  Deploy successful!
Preview URL: https://6e009397.rivet.pages.dev
Branch Preview URL: https://05-31-fix-pegboard-continue.rivet.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 2, 2025

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e0b88b
Status: ✅  Deploy successful!
Preview URL: https://ae06cb93.rivet-hub-7jb.pages.dev
Branch Preview URL: https://05-31-fix-pegboard-continue.rivet-hub-7jb.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 2, 2025

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e0b88b
Status: ✅  Deploy successful!
Preview URL: https://23f004ab.rivet-studio.pages.dev
Branch Preview URL: https://05-31-fix-pegboard-continue.rivet-studio.pages.dev

View logs

@MasterPtato MasterPtato force-pushed the 05-31-fix_pegboard_fix_collecting_metrics_for_actors_without_workflows branch from dff268d to 4527a1a Compare June 3, 2025 01:54
@MasterPtato MasterPtato force-pushed the 05-31-fix_pegboard_continue_exporting_metrics_even_if_fetching_actor_fails branch from a6a6179 to 3e0b88b Compare June 3, 2025 01:54
@MasterPtato MasterPtato marked this pull request as ready for review June 3, 2025 01:55
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Enhances error handling in the pegboard metrics collection service to ensure continuous metrics export even when actor fetches fail. The changes introduce an allow_errors parameter across multiple components.

  • Added allow_errors: true in pegboard/standalone/usage-metrics-publish/src/lib.rs to continue metrics collection despite actor fetch failures
  • Implemented strict error handling (allow_errors: false) in actor API endpoints to maintain data integrity
  • Added error handling logic in pegboard_actor_get operation to log warnings and continue processing when allow_errors is true
  • Modified actor fetching stream to handle failures gracefully while maintaining metrics collection for available actors

4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

/// path endpoint.
pub endpoint_type: Option<crate::types::EndpointType>,

pub allow_errors: bool,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Missing documentation for allow_errors field to explain when it should be used and potential implications.

Suggested change
pub allow_errors: bool,
/// When true, errors fetching individual actors will be logged and skipped instead of failing the entire operation.
/// This is useful for bulk operations where partial failures are acceptable.
pub allow_errors: bool,

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 3, 2025

Merge activity

  • Jun 3, 7:01 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Jun 3, 7:02 AM UTC: CI is running for this pull request on a draft pull request (#2528) due to your merge queue CI optimization settings.
  • Jun 3, 7:03 AM UTC: Merged by the Graphite merge queue via draft PR: #2528.

graphite-app bot pushed a commit that referenced this pull request Jun 3, 2025
#2520)

<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Jun 3, 2025
@graphite-app graphite-app bot deleted the 05-31-fix_pegboard_continue_exporting_metrics_even_if_fetching_actor_fails branch June 3, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant