fix: add create ts to server list #2523
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2025
Closed
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds create_ts to server-related operations and improves metrics reporting accuracy, particularly focusing on CPU usage measurement in millicores.
- Added
create_tsfield toServerRowandServerstructs with corresponding SQL query updates inget.rs,list.rs, andlost_list.rs - Changed CPU usage metric description from percent to millicores in
pegboard/metrics.rsfor accuracy - Improved actor state handling in
pegboard/actor/get.rswith better error logging and optional row fetching - Removed incorrect CPU millicores to percentage conversion in usage metrics collection
- Updated Grafana dashboard configurations by removing
maxDataPointsconstraints for better data granularity
10 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
| Latest commit: |
863f139
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d2988443.rivet.pages.dev |
| Branch Preview URL: | https://06-03-fix-add-create-ts-to-s.rivet.pages.dev |
graphite-app
bot
changed the base branch from
06-02-fix_fix_pb_metrics_standalone
to
graphite-base/2523
MasterPtato
force-pushed
the
graphite-base/2523
branch
from
d6f19c0 to
eeb9b08
Compare
MasterPtato
force-pushed
the
06-03-fix_add_create_ts_to_server_list
branch
from
8d30998 to
5e33d41
Compare
This was referenced Jun 3, 2025
MasterPtato
force-pushed
the
06-03-fix_add_create_ts_to_server_list
branch
from
5e33d41 to
7666132
Compare
Deploying rivet-studio with
|
| Latest commit: |
863f139
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c726546d.rivet-studio.pages.dev |
| Branch Preview URL: | https://06-03-fix-add-create-ts-to-s.rivet-studio.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
863f139
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://de0a12f1.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://06-03-fix-add-create-ts-to-s.rivet-hub-7jb.pages.dev |
This was referenced Jun 4, 2025
NathanFlurry
force-pushed
the
06-03-fix_add_create_ts_to_server_list
branch
from
7666132 to
20eace2
Compare
MasterPtato
force-pushed
the
06-03-fix_add_create_ts_to_server_list
branch
from
20eace2 to
b77a826
Compare
This was referenced Jun 5, 2025
Closed
MasterPtato
force-pushed
the
06-03-fix_add_create_ts_to_server_list
branch
from
b77a826 to
863f139
Compare
This was referenced Jun 6, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes