-
Notifications
You must be signed in to change notification settings - Fork 129
fix: fix edge dc eligible calculation #2567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
MasterPtato
wants to merge
1
commit into
06-06-fix_cluster_fix_scaling_logic_and_dedup_metrics
from
06-06-fix_fix_edge_dc_eligible_calculation
Closed
fix: fix edge dc eligible calculation #2567
MasterPtato
wants to merge
1
commit into
06-06-fix_cluster_fix_scaling_logic_and_dedup_metrics
from
06-06-fix_fix_edge_dc_eligible_calculation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2025
Closed
This was referenced Jun 6, 2025
Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Improved datacenter eligibility calculation in packages/core/api/actor/src/utils.rs by considering pool min/max count constraints instead of only desired_count.
- Updated
filter_edge_dcfunction to check pool min_count and max_count boundaries when determining if a datacenter can host instances - More accurate eligibility determination prevents potential issues where desired_count > 0 but actual instances cannot be allocated due to constraints
- This fix ensures proper resource allocation by respecting pool capacity limits in datacenter selection
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
| Latest commit: |
b500574
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a3e4989c.rivet.pages.dev |
| Branch Preview URL: | https://06-06-fix-fix-edge-dc-eligib.rivet.pages.dev |
98fe76a to
6f44cae
Compare
0be6e64 to
c1c5ebd
Compare
6f44cae to
b500574
Compare
c1c5ebd to
4da1c2e
Compare
Deploying rivet-studio with
|
| Latest commit: |
b500574
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://42464df5.rivet-studio.pages.dev |
| Branch Preview URL: | https://06-06-fix-fix-edge-dc-eligib.rivet-studio.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
b500574
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://acc38857.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://06-06-fix-fix-edge-dc-eligib.rivet-hub-7jb.pages.dev |
This was referenced Jun 6, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Changes