Skip to content

Conversation

@MasterPtato
Copy link
Contributor

Changes

@MasterPtato MasterPtato requested a review from NathanFlurry June 6, 2025 01:37
Copy link
Contributor Author

MasterPtato commented Jun 6, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Improved datacenter eligibility calculation in packages/core/api/actor/src/utils.rs by considering pool min/max count constraints instead of only desired_count.

  • Updated filter_edge_dc function to check pool min_count and max_count boundaries when determining if a datacenter can host instances
  • More accurate eligibility determination prevents potential issues where desired_count > 0 but actual instances cannot be allocated due to constraints
  • This fix ensures proper resource allocation by respecting pool capacity limits in datacenter selection

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 6, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: b500574
Status: ✅  Deploy successful!
Preview URL: https://a3e4989c.rivet.pages.dev
Branch Preview URL: https://06-06-fix-fix-edge-dc-eligib.rivet.pages.dev

View logs

@MasterPtato MasterPtato force-pushed the 06-06-fix_fix_edge_dc_eligible_calculation branch from 98fe76a to 6f44cae Compare June 6, 2025 18:29
@MasterPtato MasterPtato force-pushed the 06-06-fix_cluster_fix_scaling_logic_and_dedup_metrics branch from 0be6e64 to c1c5ebd Compare June 6, 2025 18:29
@MasterPtato MasterPtato force-pushed the 06-06-fix_fix_edge_dc_eligible_calculation branch from 6f44cae to b500574 Compare June 6, 2025 20:45
@MasterPtato MasterPtato force-pushed the 06-06-fix_cluster_fix_scaling_logic_and_dedup_metrics branch from c1c5ebd to 4da1c2e Compare June 6, 2025 20:45
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 6, 2025

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: b500574
Status: ✅  Deploy successful!
Preview URL: https://42464df5.rivet-studio.pages.dev
Branch Preview URL: https://06-06-fix-fix-edge-dc-eligib.rivet-studio.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: b500574
Status: ✅  Deploy successful!
Preview URL: https://acc38857.rivet-hub-7jb.pages.dev
Branch Preview URL: https://06-06-fix-fix-edge-dc-eligib.rivet-hub-7jb.pages.dev

View logs

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 9, 2025

Merge activity

  • Jun 9, 4:47 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
  • Jun 9, 4:48 PM UTC: CI is running for this pull request on a draft pull request (#2574) due to your merge queue CI optimization settings.
  • Jun 9, 4:49 PM UTC: Merged by the Graphite merge queue via draft PR: #2574.

graphite-app bot pushed a commit that referenced this pull request Jun 9, 2025
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Jun 9, 2025
@graphite-app graphite-app bot deleted the 06-06-fix_fix_edge_dc_eligible_calculation branch June 9, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant