fix(pegboard): fix allocation metrics #2568
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2025
Closed
Closed
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses critical metric tracking issues in the Pegboard service, focusing on proper resource allocation monitoring and drain state synchronization.
- Fixed swapped CPU/memory metric handling in
packages/core/services/cluster/src/ops/datacenter/topology_get/pegboard.rswhere values were incorrectly interpreted (MHz vs MiB) - Added concurrent metric updates with drain state changes in
packages/edge/services/pegboard/src/workflows/client/mod.rsusingctx.join() - Implemented ClickHouse metric recording before actor allocation in
packages/edge/services/pegboard/src/workflows/actor/mod.rs - Enhanced drain state labeling in metrics to properly distinguish between 'active' and 'draining' clients
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+80
to
82
| server_entry.cpu += | ||
| value.parse::<f64>()? as u32 * server_spec::LINODE_CPU_PER_CORE / 1000; | ||
| } |
There was a problem hiding this comment.
style: Potential loss of precision when converting f64 to u32 before multiplication. Consider reordering operations
Deploying rivet with
|
| Latest commit: |
b59017e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eb6d12ee.rivet.pages.dev |
| Branch Preview URL: | https://06-06-fix-pegboard-fix-alloc.rivet.pages.dev |
This was referenced Jun 6, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes