chore(rivetkit): note duplicate admission logic

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

• fix(pegboard): align drain grace defaults with stop threshold #4958 : 2 dependent PRs (#4960 , #4966 )
• fix(rivetkit): preserve bridge error messages #4959
• fix(rivetkit): fire abort signal on shutdown finalize #4957
• fix(rivetkit): use startup kv preload #4956
• fix(client): flatten skipReadyWait option #4955
• ci(publish): add manual preview publish flow #4954
• fix(depot): add ltx decode diagnostics #4953
• fix(universaldb): preserve plain set values #4952
• fix(universaldb): align versionstamp operand encoding #4951
• fix(rivetkit): export database provider types #4950
• wip: kitchen sink agentic loop finish #4949
• chore(rivetkit): note duplicate admission logic #4948 👈 (View in Graphite)
• test(rivetkit): cover bypass fetch header forwarding #4947
• feat(kitchen-sink): add actor probe controls #4946
• fix(gateway): split actor response wait errors #4945
• fix(guard): handle bypass preflight before query parse #4944
• feat(kitchen-sink): add mock agent event log copy #4943
• fix(kitchen-sink): default mock agent to local endpoint #4942
• test(rivetkit): enable driver lifecycle regressions #4941
• test(rivetkit): verify cached websocket db refs exceed grace #4940
• fix(rivetkit-core): keep sleeping actors reachable during grace #4939
• test(rivetkit): cover async websocket close db access #4938
• fix(rivetkit): keep actors awake until keepAwake work finishes #4937
• fix(rivetkit): persist native onSleep state on errors #4936
• fix(rivetkit-core): allow dispatch during sleep grace #4935
• fix(rivetkit): make duplicate sleep requests idempotent #4934
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review: chore(rivetkit): note duplicate admission logic

Overview

This small chore PR does two things:

1. Adds paired TODO comments in ActorTask::dispatch_lifecycle_error and RegistryDispatcher::active_actor noting that their admission/lifecycle-guard logic is duplicated and should eventually be unified.
2. Adds a #[cfg(test)] helper is_actor_request_path in registry/http.rs.

Code Quality

• TODO comments follow project style conventions: complete sentences, no dashes, no fragmented structure. Both cross-reference each other symmetrically, which is helpful for future refactoring.
• is_actor_request_path is logically sound. The byte-level suffix check guards correctly against false positives on paths like /requestfoo by requiring the character after /request to be empty, /, or ?.

Concerns / Suggestions

1. No issue link on the TODOs

The TODOs flag a real duplication risk — a change to admission policy in one location will not automatically be reflected in the other — but without a linked ticket they are easy to lose. Consider TODO(#NNNN): Share admission policy with ....

2. is_actor_request_path is test-only but logically paired with production code

normalize_actor_request_path lives in production code and implicitly encodes the same prefix assumption. Having the gate predicate only in #[cfg(test)] while the normalization lives in production code is asymmetric. Either promote is_actor_request_path to production code and use it as the routing gate, or add a comment explaining why the production router does not need it (e.g. the routing match already enforces the prefix before calling normalize_actor_request_path).

3. Admission guard semantics diverge between the two sites

dispatch_lifecycle_error checks destroy_requested() and stopped(), while RegistryDispatcher::active_actor additionally checks started(). This semantic difference could mask bugs if one path is updated but not the other. Worth capturing in .agent/todo/ as a follow-up.

Summary

The TODOs are well-placed and correctly identify a maintenance risk. Main gaps: no issue link to track the refactor, unexplained asymmetry of the test-only helper, and diverging admission-guard semantics between the two sites. Low risk overall, but the duplication is a latent bug surface worth consolidating soon.