chore(rivetkit): doc skip ready wait#4927
chore(rivetkit): doc skip ready wait#4927NathanFlurry wants to merge 4 commits intographite-base/4927from
Conversation
PR Review:
|
| Area | Status |
|---|---|
| Correctness | resolveActorGatewayOptions nullish-coalescing order produces the wrong result when both aliases are passed with conflicting values |
| Backward compat | bypassConnectable still works at all call sites |
| DRY | shouldBypassConnectable helper cleanly eliminates four duplicate checks |
| Test coverage | Mostly complete; missing one WebSocket path test for skipReadyWait |
| Docs | Good; one phrasing ambiguity in lifecycle.mdx |
Overall a clean, well-scoped change. The main thing worth fixing before merge is the OR-vs-nullish-coalescing inconsistency in resolveActorGatewayOptions.
f7d89ed to
6b85d8c
Compare
656743e to
5fbbe77
Compare
5fbbe77 to
4df4d5a
Compare
|
Landed in main via stack-merge fast-forward push. Commits are in main; closing to match. |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: