Skip to content

feat(rivetkit): support gateway bypass probes#4915

Closed
NathanFlurry wants to merge 1 commit into05-03-feat_kitchen-sink_add_mock_agentic_lifecycle_loopfrom
05-03-feat_rivetkit_support_gateway_bypass_probes
Closed

feat(rivetkit): support gateway bypass probes#4915
NathanFlurry wants to merge 1 commit into05-03-feat_kitchen-sink_add_mock_agentic_lifecycle_loopfrom
05-03-feat_rivetkit_support_gateway_bypass_probes

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

NathanFlurry commented May 4, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 4, 2026

Re-reviewed after force-push — no changes to issues noted previously. All 7 items (dual-timeout, cleanup TDZ, missing after-sleep assertions, withTimeout leak, unexplained /request/bypass path, 404 fallback semantics, inconsistent once:true) remain unaddressed.

@NathanFlurry NathanFlurry force-pushed the 05-03-feat_rivetkit_support_gateway_bypass_probes branch from a642bb2 to a5ac952 Compare May 4, 2026 00:44
@NathanFlurry NathanFlurry force-pushed the 05-03-feat_kitchen-sink_add_mock_agentic_lifecycle_loop branch from 58a8948 to d4ad418 Compare May 4, 2026 00:44
@NathanFlurry NathanFlurry force-pushed the 05-03-feat_rivetkit_support_gateway_bypass_probes branch from a5ac952 to 5425291 Compare May 4, 2026 00:54
@NathanFlurry NathanFlurry force-pushed the 05-03-feat_kitchen-sink_add_mock_agentic_lifecycle_loop branch from d4ad418 to 2483b16 Compare May 4, 2026 00:54
@NathanFlurry NathanFlurry force-pushed the 05-03-feat_rivetkit_support_gateway_bypass_probes branch from 5425291 to 7143a97 Compare May 4, 2026 03:01
@NathanFlurry NathanFlurry force-pushed the 05-03-feat_kitchen-sink_add_mock_agentic_lifecycle_loop branch from 2483b16 to 39bcaec Compare May 4, 2026 03:01
@NathanFlurry NathanFlurry marked this pull request as ready for review May 4, 2026 03:32
@NathanFlurry
Copy link
Copy Markdown
Member Author

Landed in main via stack-merge fast-forward push. Commits are in main; closing to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant