fix(rivetkit): align logs with engine logfmt#4933
fix(rivetkit): align logs with engine logfmt#4933NathanFlurry wants to merge 8 commits intographite-base/4933from
Conversation
Code Review: fix(rivetkit): align logs with engine logfmtOverviewThis PR aligns the log format output for the NAPI/TypeScript layers with the engine's logfmt format. It adds logfmt (and GCP/Stackdriver) support on the Rust side via RustGenerally solid. The conditional layer pattern with Minor issues:
TypeScriptThe overall approach (parse pino JSON output, reformat as logfmt) works, but there are correctness and robustness gaps. Potential bug: incomplete control character escaping in Only Missing Objects/arrays become opaque JSON strings. No test coverage. The Summary
The control character escaping issue is the only real bug. Everything else is minor. The overall approach is clean and consistent with the engine's logging patterns. |
Preview packages published to npmInstall with: npm install rivetkit@pr-4933All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-5484e59
docker pull rivetdev/engine:full-5484e59Individual packagesnpm install rivetkit@pr-4933
npm install @rivetkit/react@pr-4933
npm install @rivetkit/rivetkit-napi@pr-4933
npm install @rivetkit/workflow-engine@pr-4933 |
76cce67 to
b81dab2
Compare
|
Landed in main via stack-merge fast-forward push. Commits are in main; closing to match. |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: