fix(ci): standardize publish rust toolchain

[NathanFlurry]

What

Standardizes publish Docker builds on Rust 1.91.1 and keeps builder-base source Dockerfiles aligned. Also preserves the rustfmt/script-mode fixes from the failed CI run.

Why

Publish builders were split between rustc 1.89.0 and 1.91.0, while the locked AWS crates require rustc 1.91/1.91.1. Installing the same toolchain inside active publish build stages lets the current base images pass without waiting for a base-image rebuild.

[claude]

PR #4931 Review: fix(ci): standardize publish rust toolchain

State: CLOSED - reviewed for record.

Overview

This PR standardizes all publish Docker builds on Rust 1.91.1 and cleans up several dead-code warnings that would fail under -D warnings. It uses an inline rustup toolchain install workaround inside each build Dockerfile to unblock CI immediately without waiting for base-image rebuilds.

Docker / Toolchain

• Inline rustup install is a pragmatic workaround. Once builder-base images are rebuilt, these extra RUN rustup... blocks will be redundant. Worth a follow-up cleanup.
• RUST_TOOLCHAIN ARG: the version is hardcoded in 8 Dockerfiles; centralizing it would eliminate future drift.
• engine-builder.Dockerfile was already at 1.91.0, bumped to 1.91.1 consistently.

CI Check Change (rust.yml)

• -A unsafe-op-in-unsafe-fn is overly broad. This lint flags unsafe ops inside unsafe fn that lack their own unsafe block, which is a real safety signal. Rust edition 2024 makes it a hard error, so the specific call sites will need fixing eventually. Better to address those sites (likely in NAPI or VFS code) than suppress globally.
• Dropping --all-features can miss feature-gated compilation errors. If rivetkit-wasm is the only problem target, --exclude rivetkit-wasm is the right scalpel, but restoring --all-features for the remaining workspace would be safer.

Dead Code Fixes

• epoxy/setup.rs: Removes unreachable code below an early return Ok(...). No behavior change.
• universaldb/rocksdb.rs: The if empty block was unreachable due to the return above it. Refactoring is correct.
• rivetkit-core/http.rs: Removes is_actor_request_path with no remaining callers. Clean.
• rivetkit-core/serverless.rs: Removes unused configured_token from ServerlessSettings. Clean.

VFS Metrics (depot-client/vfs.rs)

• New page_cache_weighted_size field is a useful observability addition.
• Potential unit inconsistency: computed as page_cache.weighted_size() + protected_page_cache.len(). moka::Cache::weighted_size() returns sum of entry weights; HashSet::len() returns a count. If moka uses weight=1 per page these are equivalent, but non-unit weights would produce a misleading result. Worth verifying or adding an inline comment stating the weight assumption.

Guard-Core Tests

Tests live in src/utils/tests.rs with a path shim. CLAUDE.md says Rust tests should live under tests/, not src/. Consider moving to engine/packages/guard-core/tests/utils.rs in a follow-up.

Envoy-Client Test Fixture

actors_notify: Arc::new(tokio::sync::Notify::new()) added to EnvoyContext. Aligns with the CLAUDE.md performance rule requiring a paired Notify for any shared counter with a waiter. Correct.

Summary

Area	Verdict
Toolchain standardization	Correct fix, minor duplication concern
-A unsafe-op-in-unsafe-fn	Address at call sites instead of suppressing globally
Dead code removals	All correct
page_cache_weighted_size unit mixing	Verify weight assumption
Guard-core test placement	Minor convention deviation (src/ vs tests/)
actors_notify fixture update	Correct

The core CI unblock is sound. The two items worth addressing before or after landing are the global unsafe-op-in-unsafe-fn allow and the mixed-unit weighted-size metric.

[github-actions]

Preview packages published to npm

Install with:

npm install rivetkit@pr-4931

All packages published as 0.0.0-pr.4931.883fbb7 with tag pr-4931.

Engine binary is shipped via @rivetkit/engine-cli on linux-x64-musl, linux-arm64-musl, darwin-x64, and darwin-arm64. Windows users should use the release installer or set RIVET_ENGINE_BINARY.

Docker images:

docker pull rivetdev/engine:slim-883fbb7
docker pull rivetdev/engine:full-883fbb7

Individual packages

npm install rivetkit@pr-4931
npm install @rivetkit/react@pr-4931
npm install @rivetkit/rivetkit-napi@pr-4931
npm install @rivetkit/workflow-engine@pr-4931

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(rivetkit): note duplicate admission logic #4948
• test(rivetkit): cover bypass fetch header forwarding #4947
• feat(kitchen-sink): add actor probe controls #4946
• fix(gateway): split actor response wait errors #4945
• fix(guard): handle bypass preflight before query parse #4944
• feat(kitchen-sink): add mock agent event log copy #4943
• fix(kitchen-sink): default mock agent to local endpoint #4942
• test(rivetkit): enable driver lifecycle regressions #4941
• test(rivetkit): verify cached websocket db refs exceed grace #4940
• fix(rivetkit-core): keep sleeping actors reachable during grace #4939
• test(rivetkit): cover async websocket close db access #4938
• fix(rivetkit): keep actors awake until keepAwake work finishes #4937
• fix(rivetkit): persist native onSleep state on errors #4936
• fix(rivetkit-core): allow dispatch during sleep grace #4935
• fix(rivetkit): make duplicate sleep requests idempotent #4934
• fix(rivetkit): align logs with engine logfmt #4933
• fix(ci): standardize publish rust toolchain #4931 👈 (View in Graphite)
• SPLIT UP: agentic loop test #4932
• chore(rivetkit): doc skip ready wait #4927
• fix(guard): parse gateway bypass query booleans #4926
• feat(depot-client): add vfs staging cache ttl #4930
• feat(depot-client): wire sqlite optimization flags #4923
• feat(rivetkit): support gateway bypass client overrides #4928
• test(depot-client): stabilize fault harness #4924
• chore(depot-client): split sqlite vfs transports #4922
• feat(rivetkit): support gateway bypass probes #4915
• feat(kitchen-sink): add mock agentic lifecycle loop #4914
• feat(kitchen-sink): add mock agentic loop #4891
• feat(rivetkit): support gateway bypass client requests #4917
• fix(pegboard): restore hibernating request ids #4898 : 2 other dependent PRs (#4899 , #4916 )
• chore(guard): configure local timeout knobs #4913
• docs(rivetkit): raise serverless start payload limit #4911
• test(kitchen-sink): add sqlite memory soak harness #4910
• feat(rivetkit): expose runtime diagnostics #4909
• chore(depot-client): migrate to worker thread #4907 : 2 other dependent PRs (#4912 , #4918 )
• test(driver): select matrix cells with vitest filters #4906
• fix(pegboard): restore hibernating requests on serverful start #4904 : 1 other dependent PR (#4905 )
• fix(rivetkit): drain shutdown work before sleep #4902 : 1 other dependent PR (#4903 )
• feat(sqlite): wire remote sqlite execute handlers #4897
• test(serverless): avoid pinning header validation order #4896
• chore(driver-test-runner): add native/wasm runtime matrix to skill #4884 : 3 other dependent PRs (#4892 , #4894 , #4901 )
• chroe: rename rivetkit-sqlite to depot-client #4883
• fix(rivetkit-wasm): fix mem leaks #4880
• chore(rivetkit): wasm support #4860
• feat(sqlite): add cold read benchmarks and simplify optimizations #4857
• feat(sqlite): benchmark cold reads #4848 : 1 other dependent PR (#4864 )
• docs(actors): document manual lifecycle controls #4847
• test(sqlite): expand db stress coverage #4846 : 1 other dependent PR (#4849 )
• test(raw-websocket): add serverless smoke coverage #4845
• feat(serverless): configure drain grace period #4844
• fix(publish): enable frontend build for engine target and use turbo build instead of turbo build:engine #4843
• feat(rivetkit): expose conn handle in onWebSocket context #4842
• fix(rivetkit): normalize waitUntil/keepAwake promises to null to avoid serde undefined error #4841
• fix(rivetkit): remove requirement for token #4839 : 1 other dependent PR (#4840 )
• fix(pegboard-envoy): allow sqlite requests across lifecycle states #4838
• fix(pegboard): route scoped actor key reads by runner dc #4837
• fix(sqlite-storage): let sqlite open take over stale owners #4834
• fix(engine-tests): parallelize multi-DC startup + enable 6 multi-DC tests #4833
• fix(api): honor cursor in actor_ids list path #4832
• fix(api): silently filter invalid IDs from actor_ids query instead of 400 #4831
• fix(api-peer): make actors_delete idempotent for already-destroyed actors #4830
• fix(pegboard): use Iterator streaming mode in list_names so limit param is honored #4829
• chore(engine-tests): convert envoy tests to Sleep crash policy + triage ignored #4828
• feat(engine-tests): wire envoy actor names through prepopulate_actor_names #4827
• chore(depot): fault injection tests #4868
• feat(sqlite): pitr & forking #4859 : 1 other dependent PR (#4863 )
• chore(sqlite): stateless storage refactor #4856
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[NathanFlurry]

Landed in main via stack-merge fast-forward push. Commits are in main; closing to match.