Fix a typo. #158
Fix a typo. #158
Conversation
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
articles/100_ament.md
Outdated
| [ament_tools](https://github.com/ament/ament_tools) is a Python package which provides the command line tool `ament` to build, test, install, and uninstall packages. | ||
| It is similar to [catkin_tools](https://github.com/catkin/catkin_tools) and builds each package in a workspace in topological order. | ||
| Support for different build systems is integrated through extension points which allows to contribute support for other build types without change the ament tool itself. | ||
| Support for different build systems is integrated through extension points which allows to contribute support for other build types without changing the ament tool itself. |
There was a problem hiding this comment.
as long as you're here, I think the words to contribute can be deleted as well
There was a problem hiding this comment.
Heh, I just changed that myself. Not sure if you just want to remove "to contribute", or if you like my "allows the implementation of". I'm fine either way.
|
"build types" are imo not "implemented". I think saying that a build type like
|
@sloretz @mikaelarguedas Do you have any comment on this? |
|
I agree with you @dirk-thomas . Would just change the english to "Support for different build systems is integrated through extension points which allows support for other build types to be added without changing the ament tool itself." |
The current state of this PR seems fine to me: @dhood'd suggestion is fine as well it just changes "which allows to contribute support for other build types" to "which allows support for other build types to be added". I dont think it deserves to be changed but maybe it's more english. |
|
I'm happy with either "supported" or "implemented". |
|
I updated it to:
I will leave it up to someone else to squash and merge this. 👍 from me. |
|
@csukuangfj Thank you for your attention to detail. |
6 participants
No description provided.