Skip to content

Add a hint for using nolimit to the limiting error message - #162383

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
JonathanBrouwer:nolimit
Sep 7, 2026
Merged

Add a hint for using nolimit to the limiting error message#162383
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
JonathanBrouwer:nolimit

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

So people know they can get around it :)
I think the current wording is fine, if you'd like the message to be a bit scarier by adding "If really needed, ", lmk

@rustbot

rustbot commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: infra-ci
  • infra-ci expanded to Kobzol, Mark-Simulacrum, jieyouxu, marcoieni, ubiratansoares
  • Random selection from Mark-Simulacrum, jieyouxu, marcoieni, ubiratansoares

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 6, 2026

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, thanks.
@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ed9f5ed has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Sep 7, 2026
Add a hint for using `nolimit` to the limiting error message

So people know they can get around it :)
I think the current wording is fine, if you'd like the message to be a bit scarier by adding "If really needed, ", lmk
rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026
Rollup of 4 pull requests

Successful merges:

 - #162367 (Use `reason` for tracked item diagnostics from `cfg_select!`)
 - #162319 (docs(core): correct ARMv8-M Baseline atomic CAS support)
 - #162383 (Add a hint for using `nolimit` to the limiting error message)
 - #162384 (remove EnumSizeOpt)
rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026
Rollup of 14 pull requests

Successful merges:

 - #162404 (`rust-analyzer` subtree update)
 - #161624 (diagnostics: Point closure trait errors at captured values)
 - #161697 (make `Complex` ABI-compatible on sparc64 and powerpc64)
 - #162182 (delay unexpected successful goal during ambiguity reporting)
 - #162328 (Allow overriding filecheck even if LLVM is built or downloaded)
 - #162367 (Use `reason` for tracked item diagnostics from `cfg_select!`)
 - #162381 (fix bare urls split text)
 - #162388 (std: fix set_permissions_nofollow on espidf and horizon)
 - #162319 (docs(core): correct ARMv8-M Baseline atomic CAS support)
 - #162341 (add regression test for packus_epi16 issue)
 - #162383 (Add a hint for using `nolimit` to the limiting error message)
 - #162384 (remove EnumSizeOpt)
 - #162390 (remove outdated comment in `UnsafeCell::raw_get` source)
 - #162397 (docs: Ask for ABI documentation in the platform support template)
@rust-bors
rust-bors Bot merged commit d757a55 into rust-lang:main Sep 7, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 7, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026
Rollup merge of #162383 - JonathanBrouwer:nolimit, r=jieyouxu

Add a hint for using `nolimit` to the limiting error message

So people know they can get around it :)
I think the current wording is fine, if you'd like the message to be a bit scarier by adding "If really needed, ", lmk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants