remove outdated comment in UnsafeCell::raw_get source - #162390
Open
RedDaedalus wants to merge 1 commit into
Open
remove outdated comment in UnsafeCell::raw_get source#162390RedDaedalus wants to merge 1 commit into
UnsafeCell::raw_get source#162390RedDaedalus wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @Darksonn rustbot has assigned @Darksonn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@RalfJung You happy with this? |
Member
|
Good catch, thanks! |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Sep 7, 2026
…=RalfJung remove outdated comment in `UnsafeCell::raw_get` source It was decided that UnsafeCell can be accessed mutably without going through `get` (rust-lang/unsafe-code-guidelines#281) and a comment stating that std has special privileges was removed in rust-lang#159730, but that PR missed `raw_get`. This comment actively contradicted `CovariantUnsafeCell`: https://github.com/rust-lang/rust/blob/5a2be9f5f075d31e3ca5526b5b029881ce441253/library/core/src/cell/covariant_unsafe_cell.rs#L154-L161
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 7, 2026
…=RalfJung remove outdated comment in `UnsafeCell::raw_get` source It was decided that UnsafeCell can be accessed mutably without going through `get` (rust-lang/unsafe-code-guidelines#281) and a comment stating that std has special privileges was removed in rust-lang#159730, but that PR missed `raw_get`. This comment actively contradicted `CovariantUnsafeCell`: https://github.com/rust-lang/rust/blob/5a2be9f5f075d31e3ca5526b5b029881ce441253/library/core/src/cell/covariant_unsafe_cell.rs#L154-L161
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Sep 7, 2026
…=RalfJung remove outdated comment in `UnsafeCell::raw_get` source It was decided that UnsafeCell can be accessed mutably without going through `get` (rust-lang/unsafe-code-guidelines#281) and a comment stating that std has special privileges was removed in rust-lang#159730, but that PR missed `raw_get`. This comment actively contradicted `CovariantUnsafeCell`: https://github.com/rust-lang/rust/blob/5a2be9f5f075d31e3ca5526b5b029881ce441253/library/core/src/cell/covariant_unsafe_cell.rs#L154-L161
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 7, 2026
Rollup of 14 pull requests Successful merges: - #162404 (`rust-analyzer` subtree update) - #161624 (diagnostics: Point closure trait errors at captured values) - #161697 (make `Complex` ABI-compatible on sparc64 and powerpc64) - #162182 (delay unexpected successful goal during ambiguity reporting) - #162328 (Allow overriding filecheck even if LLVM is built or downloaded) - #162367 (Use `reason` for tracked item diagnostics from `cfg_select!`) - #162381 (fix bare urls split text) - #162388 (std: fix set_permissions_nofollow on espidf and horizon) - #162319 (docs(core): correct ARMv8-M Baseline atomic CAS support) - #162341 (add regression test for packus_epi16 issue) - #162383 (Add a hint for using `nolimit` to the limiting error message) - #162384 (remove EnumSizeOpt) - #162390 (remove outdated comment in `UnsafeCell::raw_get` source) - #162397 (docs: Ask for ABI documentation in the platform support template)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was decided that UnsafeCell can be accessed mutably without going through
get(rust-lang/unsafe-code-guidelines#281) and a comment stating that std has special privileges was removed in #159730, but that PR missedraw_get. This comment actively contradictedCovariantUnsafeCell:rust/library/core/src/cell/covariant_unsafe_cell.rs
Lines 154 to 161 in 5a2be9f