remove EnumSizeOpt - #162384
Merged
Merged
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
Member
|
@bors r+ rollup (removing an off-by-default MIR opt shouldn't have any collateral impact or conflict much with other PRs) |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Sep 7, 2026
remove EnumSizeOpt This was landed years ago but has never been enabled due to odd issues that came up when merging it. The issues never got investigated (or at least, not with any conclusions). The author of the pass [said](rust-lang#154413 (comment)) they don't have time to work on it and recommend removing it. So... let's do that. r? @saethlin Fixes rust-lang#154413
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 7, 2026
Rollup of 14 pull requests Successful merges: - #162404 (`rust-analyzer` subtree update) - #161624 (diagnostics: Point closure trait errors at captured values) - #161697 (make `Complex` ABI-compatible on sparc64 and powerpc64) - #162182 (delay unexpected successful goal during ambiguity reporting) - #162328 (Allow overriding filecheck even if LLVM is built or downloaded) - #162367 (Use `reason` for tracked item diagnostics from `cfg_select!`) - #162381 (fix bare urls split text) - #162388 (std: fix set_permissions_nofollow on espidf and horizon) - #162319 (docs(core): correct ARMv8-M Baseline atomic CAS support) - #162341 (add regression test for packus_epi16 issue) - #162383 (Add a hint for using `nolimit` to the limiting error message) - #162384 (remove EnumSizeOpt) - #162390 (remove outdated comment in `UnsafeCell::raw_get` source) - #162397 (docs: Ask for ABI documentation in the platform support template)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 7, 2026
Rollup merge of #162384 - RalfJung:EnumSizeOpt, r=saethlin remove EnumSizeOpt This was landed years ago but has never been enabled due to odd issues that came up when merging it. The issues never got investigated (or at least, not with any conclusions). The author of the pass [said](#154413 (comment)) they don't have time to work on it and recommend removing it. So... let's do that. r? @saethlin Fixes #154413
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was landed years ago but has never been enabled due to odd issues that came up when merging it. The issues never got investigated (or at least, not with any conclusions). The author of the pass said they don't have time to work on it and recommend removing it.
So... let's do that.
r? @saethlin
Fixes #154413