Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate incorrect HSL units #1175

Merged
merged 4 commits into from Dec 29, 2020
Merged

Deprecate incorrect HSL units #1175

merged 4 commits into from Dec 29, 2020

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Dec 29, 2020 •
edited

Partially addresses #1174
See sass/sass#2904

See sass/sass-spec#1608

@nex3
Mark deprecation warnings as such
7ba7351
@nex3
Improve error reporting for incompatible units
d532f01 
The new messages more consistently include argument names and actual
values. Errors about mixed unitless and unitful numbers are now more
consistent.
@nex3
Print the LHS first in incompatible unit errors
f9a9373 
Closes #766
@nex3 nex3 requested a review from jathak December 29, 2020 04:47
jathak
jathak approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@jathak jathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a couple of tests need to be updated to use the new error messages. Otherwise LGTM

@nex3 nex3 mentioned this pull request Dec 29, 2020
Open
3 tasks
@nex3 nex3 merged commit 723dc69 into master Dec 29, 2020
@nex3 nex3 deleted the angle-units branch December 29, 2020 22:58
@nex3 nex3 mentioned this pull request Jan 12, 2021
Closed
@nex3 nex3 mentioned this pull request Jul 18, 2022
Open
11 tasks
nex3 added a commit that referenced this pull request Jul 19, 2022
@nex3
Deprecate passing non-deg units to hwb()'s $hue argument
a2feb9b 
This was overlooked in #1175, because the spec said that `hwb()`
should already be throwing an error if non-`deg` units were passed.
However, Dart Sass didn't implement the spec correctly and these units
were in fact not being checked at all.

See #1174
@nex3 nex3 mentioned this pull request Jul 19, 2022
Merged
nex3 added a commit that referenced this pull request Jul 19, 2022
@nex3
Deprecate passing non-deg units to hwb()'s $hue argument (#1747)
1bd7744 
This was overlooked in #1175, because the spec said that `hwb()`
should already be throwing an error if non-`deg` units were passed.
However, Dart Sass didn't implement the spec correctly and these units
were in fact not being checked at all.

See #1174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathak jathak jathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nex3 @danielgindi @jathak