Implement get_left_child #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM. A couple of quick tests will be fine, no need for anything elaborate. |
Member
Author
|
If you are now happy with #570 I'll wait for that to be merged, then sort this out with a simple test or two, as that PR will change the drawing code needed and the test writing. |
Member
|
OK, sounds good. I you want #570 merged, give a quick rebase and we'll get it in next. |
Member
Author
|
Rebased to master - I noticed that the previous verification method was missing "minlex_postorder": when I add it in, the tests fail, which I wasn't expecting, so I've stuck in the code, but commented it out and opened a review. Do you have any inkling of why this fails @jeromekelleher (I presume you wrote the test)? |
jeromekelleher
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #615. It was logically easier (and probably more generally useful) for me to implement a get_left_child rather than a get_left_sib method, so to position labels we just check to see if a node is the left child of its parent.
Will stick a test in if you think this is a reasonable approach, @jeromekelleher .