Bg/163 publish docker image#2
Merged
BenjaminDev merged 127 commits intodevfrom Jun 1, 2020
Merged
Conversation
* Add C API code structure * Add compilable C API proof of concept * Update C API proof of concept to execute succesfully * Update example to properly pass a list * Update code style * Clean up reference code
* Documentation update for release * pep8 fix
…-style Update code style to Black standards
…ions Add bindings for algorithms/distributions.h
Documentation update
Add bindings for base/percentile
No longer need this, they are part of our global .github repo.
split the style tests
Update style_check.yml
fix_test_logging_typo
- Fixed pydp.so cleanup before new build
* added publishing for pypi * bazel is already installed lol * twine needs to be run via pipenv * Mac workflow test (OpenMined#6) * Update pypipublish_osx.yml * cleaning up files after testing
Added support for macOS
Added copying of .so file which was accidently removed. Also, moved installation from pipenv to pip
Fixed issue in build_PyDP.sh with find | xargs on linux
* add version to __init__ file * lint * add init file to setup.cfg
Fixed bug in docker file preventing creation of usable package
* tests are passing 🎉 * styling * minor change
* fixed the issue with the logger tests * style fix * cpp style fix
python 3.6 was causing dockerfile to break due to some pipfile due to some issues. While we fix that in mean-time, just adding this quick fix.
Fixed Dockerfile
Fixed OpenMined#149 * Readme * Update README.md * Update README.md * Update README.md * Update README.md edit url for contribution.md * Update README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Publish to Docker Hub so it's easy for people to try out the library.
Changes:
Notes: Dev dependencies are not baked into the image but only used to run tests.
Fixes OpenMined#163
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Did you run
make test-all?Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: