[MIG] business_requirement: Migration to v12 #315

victormmtorres · 2019-06-26T17:40:51Z

new file: business_requirement/README.rst new file: business_requirement/__init__.py new file: business_requirement/__openerp__.py new file: business_requirement/data/business_data.xml new file: business_requirement/models/__init__.py new file: business_requirement/models/business.py new file: business_requirement/security/ir.model.access.csv new file: business_requirement/security/security.xml new file: business_requirement/static/description/icon.png new file: business_requirement/static/img/bus_req.png new file: business_requirement/static/img/bus_req_alias.png new file: business_requirement/static/img/bus_req_approved.png new file: business_requirement/static/img/bus_req_cancel.png new file: business_requirement/static/img/bus_req_confirmed.png new file: business_requirement/static/img/bus_req_cust_story.png new file: business_requirement/static/img/bus_req_done.png new file: business_requirement/static/img/bus_req_drop.png new file: business_requirement/static/img/bus_req_module_diag.png new file: business_requirement/static/img/bus_req_tags.png new file: business_requirement/static/img/bus_req_tags2.png new file: business_requirement/static/img/bus_req_tree.png new file: business_requirement/static/img/module_diag.graphml new file: business_requirement/tests/__init__.py new file: business_requirement/tests/test_br.py new file: business_requirement/views/business_view.xml new file: business_requirement/wizards/__init__.py new file: business_requirement/wizards/mail_compose_message.py [FIX] Comments lines and Rst File modified: business_requirement/README.rst modified: business_requirement/models/business.py

Improved README and removed the part that is to be in repo README

GitHub comments for inheritance message_post method to modify subject. New fields for the review and request BR meaning. Improve the message meaning for the status to be useful for internal projects and not only for customer oriented projects. modified: business_requirement/__init__.py modified: business_requirement/models/business.py modified: business_requirement/views/business_view.xml [REM] business_requirement: Cause it's not longer necessary to inherit the wizard I remove from the repository. deleted: business_requirement/wizards/__init__.py deleted: business_requirement/wizards/mail_compose_message.py

If confirmed the user can't modify the first tab (story/scenario/gap) but can still change the second one (Other information). If approved, the user can't change the first and second tab. modified: business_requirement/models/business.py [IMP] business_requirement: Modify business requirement categories to be simplify the name to "Categories". Change business requirement "description" to full screen wide. modified: business_requirement/models/business.py modified: business_requirement/views/business_view.xml [IMP] business_requirement: Change Text field by Html to avoid use Html widget on the view. Remove sequence field on the Tree view. Next version will use sequence for the Kanban view. modified: business_requirement/models/business.py modified: business_requirement/views/business_view.xml [FIX] business_requirement: Change some model functions name to follow guideline and remove not necessary isolated functions. modified: business_requirement/models/business.py

[FIX] business_requirement: Update README to correct runbot address + figure

…BR. (OCA#17) * [IMP] business_requirement: Improvement on master project related to BR. modified: business_requirement/__openerp__.py modified: business_requirement/models/__init__.py new file: business_requirement/models/project.py new file: business_requirement/views/project.xml * [FIX] business_requirement: Increase Coverall regards the new model inherited. modified: business_requirement/tests/__init__.py new file: business_requirement/tests/test_project.py * [FIX] business_requirement: Modify style and format for python and xml files. modified: business_requirement/models/project.py modified: business_requirement/views/project.xml * [FIX] business_requirement: Fix version number. modified: business_requirement/__openerp__.py * [FIX] business_requirement: Fix format on XML attributes for views. modified: business_requirement/views/project.xml

[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221

This PR only updates module business_requirement. Other affected modules will be fixed with separate PRs. Fixes OCA#36 (business_requirement). [8.0] business-requirement: fix link in README.rst [IMP] Added reference and name_get for Business Requirement In tests use / for the default ref value

[FIX] fix the business_requirement super method message_post didnt pass parameters

Need to add Stakeholder Group for this State Approval. modified: business_requirement/__openerp__.py modified: business_requirement/security/security.xml modified: business_requirement/views/business_view.xml

* [FIX]Move when button to generate the project appears. It should get displayed when the stage is set to Stakeholder approval (rename to Approved by Stakeholders) * [FIX]Move when button to generate the project appears. It should get displayed when the stage is set to Stakeholder approval (rename to Approved by Stakeholders) * [Fix] Fix unit test * [IMP] Improved the UT to fix the Travis. * [IMP] Improved UT for increase Code Coverage. * [IMP] Added UT to increase coveralls. * [IMP] Added UT to increase coveralls. * [IMP] Added UT to increase coveralls. * [FIX] stakeholder_approval * [FIX] stakeholder_approval

[IMP] Changed Workflow.

Need to add reponsible and reviewers. Responsible should be required and populate on upgrade version Reviewers are users who are involved on the BR process [FIX][business_requirement] Name formating improvement (OCA#116) * [FIX] business_requirement To fix OCA#114 * [FIX] business_requirement Fix name_get method as peer code review comments Need to force string to unicode before replace

…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes. [ADD][business_requirement] Added To be reviewed field in BR (OCA#120) * [ADD]Added To be reviewed field in BR * [IMP] Improved form view as per requirement. * [IMP] Improved code as per comment. * [FIX] Fixed issues. * [IMP]Improved Code. * [IMP] IMproved code.

[IMP]Improved BR-fields position (OCA#166) * [IMP]Improved BR-fields position * exchanged requested and responsible [IMP]default sort on BR list (OCA#167) [FIX] kanban state editable in BR (OCA#169) [IMP][BR1030][22333]-Modify layout of BR Form view (OCA#210)

* [FIX] Fixed order in tree view. * [FIX] Fixed order

* [8.0][BR1030][ADD][Reference field improvements] * [IMP]Improved code

…e or Description in m2o fields (OCA#203) * [IMP] Added code to search BR based on Name or Description in m2o fields. * [IMP] Added UT to improved code coverage. * [IMP] Modified the variables names as per GIT review. [8.0-i190] [ADD] Added filter in BR search to allow user to search BR from Name or Description. (OCA#220)

…CA#192) * [IMP][8.0][22070][ISSUE#115]-Improved code as per changes * [IMP]Improved domain and added copy=False in linked_project * [ADD/IMP]Linked Project with BR and DL with Smartbutton * [IMP]Improved code * [IMP]Count number of linked project in BR,removed count function and veriable from project * [IMP]Improved method name * [FIX]Fix Travis * [IMP]Improved code * [IMP]Improved code * [IMP] Improved method name to field

* [IMP][I215][BR1030]Set Default Values * [IMP]Improved test-cases

* [WIP]:Added Demo Data. * [ADD]:Added demo data. * [ADD]Added demo datas for BR modules * [REM]Removed unnecessary demo data * [IMP]Improved Demo datas * [WIP/IMP]Improved demo data code * [IMP]Improved code as per commments * [IMP]Improved demo data * [IMP/ADD]Improved Code and Added Products Demo data for Resource lines * [IMP]Update noupdate = 1 * [IMP]Demo data improvements. * [IMP]Improved demo data * [IMP]Improved demo data as per comment * [IMP]Improved code * [IMP]Sale order on draft stage * [IMP]Improved code * [IMP]Modified Demo data file name * [IMP]Improved Identation

* [8.0][IMP]-Improved Origin field * [IMP]Improved field Type for Origin field [8.0]-IMP-Stages as clickable in BR (OCA#227) * [IMP]Added Stages as clickble removed buttons * [IMP]Improved code * [IMP]Improved code * [IMP]Improved code * [Added docstring in readgroup method]

moved to __manifest__.py

* [MIG]Migrated Business requirement module from 8.0 to 10.0 * [FIX]Fix Pylint * [IMP]Added new blankline in security file * [IMP]Added Test-Cases for Coverage * [IMP]Added report,improved fields in py and xml * [IMP]Improved code * [IMP] Removed default dimensions from pivot view * [FIX]Fixed Pylint * [IMP]Improved code * [IMP]Improved code * [FIX]Fixed Travis * [IMP]Test-cases Improved * [IMP]Improved view as per OCA standards * [IMP]Improved assert in test-cases * [IMP]-Added assertEqual in test-cases * [IMP]Improved Test-cases * [IMP]Improved Code as per OCA Standard in XML * [IMP/REM]Cover whole BR-code and removed unnecessary test-cases. * [IMP]Cover test-cases default_comany function

pedrobaeza · 2019-06-26T18:51:12Z

Please install locally first before proposing here, as the module doesn't install.

victormmtorres · 2019-06-27T10:58:44Z

@pedrobaeza sorry but that. Indeed I had to change and test quite before push force again

victormmtorres · 2019-06-27T13:09:47Z

@Tardo @pedrobaeza please review

Tardo · 2019-06-27T13:46:14Z

business_requirement/models/business.py

+            grps = self.env.user.groups_id.ids
+            date = fields.Datetime.now()
+            if vals['state'] == 'confirmed':
+                vals.update({'confirmed_user_id': user,


'user' is an model object, not a record.

business_requirement/models/business.py

Tardo · 2019-06-27T13:50:14Z

business_requirement/models/business.py

+        return super(BusinessRequirement, self).write(vals)
+
+    @api.model
+    def _selection_get_states(self):


I don't understand why need this having 'selection_add' on fields.Selection?

@Tardo I never used this. I tried and is not working. I checked where is used on others examples and always for inherited models so it's to add states as the name suggest.

The point of have a function is split states definition from field definition but no necessary to do it for sure

Please remove this method and put directly selection=[('draft', 'Draft'), ...]

victormmtorres · 2019-07-02T15:12:50Z

Changes done @Tardo

business_requirement/__init__.py

business_requirement/__manifest__.py

business_requirement/models/__init__.py

business_requirement/models/business.py

business_requirement/tests/__init__.py

business_requirement/models/business.py

victormmtorres · 2019-07-11T18:31:41Z

Changes done @Tardo

victormmtorres · 2019-07-12T07:58:55Z

@pedrobaeza Could you do a final review in order to merge?

business_requirement/__manifest__.py

business_requirement/data/business_requirement_demo.xml

pedrobaeza · 2019-07-13T16:13:52Z

business_requirement/models/business.py

+        return super(BusinessRequirement, self).write(vals)
+
+    @api.model
+    def _selection_get_states(self):


Please remove this method and put directly selection=[('draft', 'Draft'), ...]

business_requirement/models/business.py

business_requirement/security/security.xml

victormmtorres · 2019-07-19T10:38:08Z

Changes done @pedrobaeza

business_requirement/models/business.py

victormmtorres · 2019-07-22T14:01:23Z

Changes done @Tardo @pedrobaeza

victor and others added 30 commits June 26, 2019 19:23

Reduced outside margin of the icon

804a68f

Improved README and removed the part that is to be in repo README

added the module in the image path in README

28c3dc7

Update README to correct runbot address + figure (OCA#12)

4d74971

[FIX] business_requirement: Update README to correct runbot address + figure

[IMP]business_requirement: add test case field (OCA#28)

ccbd971

[FIX] fix the business_requirement message body empty issue

e8acc62

[FIX] fix the business_requirement super method message_post didnt pass parameters

[FIX] business_requirement

0b37c54

Need to add Stakeholder Group for this State Approval. modified: business_requirement/__openerp__.py modified: business_requirement/security/security.xml modified: business_requirement/views/business_view.xml

[UPD] fix website url in manifest

75b9390

[IMP] followers of master project to BR

4575f62

[FIX] Fixed travis

8a35d5a

[IMP] Changed Workflow.

OCA Transbot updated translations from Transifex

2a1d4cf

[FIX][8.0-i181-BR001028-T22316] BR ordering on Tree view (OCA#201)

3881d60

* [FIX] Fixed order in tree view. * [FIX] Fixed order

[8.0]-[BR1030]-[ADD/IMP][Reference field improvements] (OCA#208)

da0f607

* [8.0][BR1030][ADD][Reference field improvements] * [IMP]Improved code

[Issue-197][IMP]Improved String (OCA#214)

d242898

[8.0][I-215][BR1030]-Set Default Values (OCA#219)

2c0de1b

* [IMP][I215][BR1030]Set Default Values * [IMP]Improved test-cases

init branch 9.0

5fa6637

moved to __manifest__.py

victormmtorres mentioned this pull request Jun 26, 2019

[MIG] business_requirement_deliverable: Migration to v12 #316

Merged

victormmtorres force-pushed the 12.0-mig-business-requirement branch from dd4f519 to 5d5b98a Compare June 26, 2019 18:18

pedrobaeza added this to the 12.0 milestone Jun 26, 2019

victormmtorres force-pushed the 12.0-mig-business-requirement branch from 5d5b98a to fa609ae Compare June 27, 2019 10:56

victormmtorres force-pushed the 12.0-mig-business-requirement branch from fa609ae to e95d10f Compare June 27, 2019 11:54

Tardo suggested changes Jun 27, 2019

View reviewed changes

victormmtorres force-pushed the 12.0-mig-business-requirement branch from e95d10f to 9054fda Compare July 2, 2019 15:12

victormmtorres mentioned this pull request Jul 2, 2019

[FIX] business_requirement: Bug when modify state confirmed-approved #317

Merged

victormmtorres force-pushed the 12.0-mig-business-requirement branch from dc351c6 to db852a6 Compare July 2, 2019 15:54

Tardo suggested changes Jul 11, 2019

View reviewed changes

victormmtorres force-pushed the 12.0-mig-business-requirement branch from db852a6 to 720fcc0 Compare July 11, 2019 18:31

pedrobaeza reviewed Jul 13, 2019

View reviewed changes

business_requirement/__manifest__.py Show resolved Hide resolved

pedrobaeza requested changes Jul 13, 2019

View reviewed changes

victormmtorres force-pushed the 12.0-mig-business-requirement branch from 720fcc0 to 99b1cfd Compare July 19, 2019 09:40

Tardo suggested changes Jul 19, 2019

View reviewed changes

business_requirement/models/business.py Outdated Show resolved Hide resolved

business_requirement/models/business.py Outdated Show resolved Hide resolved

business_requirement/models/business.py Outdated Show resolved Hide resolved

[MIG] business_requirement: Migration to v12

a525304

victormmtorres force-pushed the 12.0-mig-business-requirement branch from 99b1cfd to a525304 Compare July 22, 2019 12:55

pedrobaeza approved these changes Jul 23, 2019

View reviewed changes

pedrobaeza merged commit 2098463 into OCA:12.0 Jul 23, 2019

pedrobaeza deleted the 12.0-mig-business-requirement branch July 23, 2019 17:51

OCA-git-bot mentioned this pull request Jul 23, 2019

Migration to version 12.0 #295

Closed

5 tasks

pedrobaeza mentioned this pull request Jul 23, 2019

[MIG] migration business_requirement from 10.0 to 12.0 #296

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] business_requirement: Migration to v12 #315

[MIG] business_requirement: Migration to v12 #315

victormmtorres commented Jun 26, 2019

pedrobaeza commented Jun 26, 2019

victormmtorres commented Jun 27, 2019

victormmtorres commented Jun 27, 2019

Tardo Jun 27, 2019

Tardo Jun 27, 2019

victormmtorres Jul 2, 2019

pedrobaeza Jul 13, 2019

victormmtorres commented Jul 2, 2019

victormmtorres commented Jul 11, 2019

victormmtorres commented Jul 12, 2019

pedrobaeza Jul 13, 2019

victormmtorres commented Jul 19, 2019

victormmtorres commented Jul 22, 2019

[MIG] business_requirement: Migration to v12 #315

[MIG] business_requirement: Migration to v12 #315

Conversation

victormmtorres commented Jun 26, 2019

pedrobaeza commented Jun 26, 2019

victormmtorres commented Jun 27, 2019

victormmtorres commented Jun 27, 2019

Tardo Jun 27, 2019

Choose a reason for hiding this comment

Tardo Jun 27, 2019

Choose a reason for hiding this comment

victormmtorres Jul 2, 2019

Choose a reason for hiding this comment

pedrobaeza Jul 13, 2019

Choose a reason for hiding this comment

victormmtorres commented Jul 2, 2019

victormmtorres commented Jul 11, 2019

victormmtorres commented Jul 12, 2019

pedrobaeza Jul 13, 2019

Choose a reason for hiding this comment

victormmtorres commented Jul 19, 2019

victormmtorres commented Jul 22, 2019