Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect quotation marks in German #4039

Closed
Wuzzy2 opened this issue Jul 10, 2016 · 4 comments
Closed

Incorrect quotation marks in German #4039

Wuzzy2 opened this issue Jul 10, 2016 · 4 comments
Labels
enhancement An improvement to an existing feature (no alteration).

Comments

@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Jul 10, 2016

OS: GNU/Linux (Arch Linux)
Version: 0.0.5-develop
Commit/Build: 59c3656

  • Bug present in RCT2? Yes.
  • Multiplayer? N/A

The quotation marks in the German localization are incorrect.

Like this:

“Reale” Parks

Where it should be:

„Reale“ Parks

I would normally post this to the localization repository but this can't be fixed by changing the German localization at the moment since this requires some characters which are not supported at the moment:

  • Opening double quotation mark: „ (U+201E) (not supported)
  • Closing double qutation mark: “ (U+201C) (supported)
  • Opening single quotation mark: ‚ (U+201A) (not supported)
  • Closing single quotation mark: ‘ (U+2018) (not supported)

Optional characters (optional in German in Germany, but used by a couple of other languages):

  • Left guillemet: « (U+00AB) (supported)
  • Right guillemet: » (U+00BB) (supported)
  • Left single guillemet: ‹ (U+2039) (not supported)
  • Right single guillemet: › (U+203A) (not supported)

So fixing this issue will involve adding support for the missing characters (step 1) and then update the localization files for German accordingly.
There are also a few other languages which use these characters, so it will be useful for these, too.
@Goddesen
Copy link
Contributor

I was under the impression reverse guillemets were the most used quotation scheme for digital text - why not use these?

@danidoedel
Copy link
Contributor

At least not in Germany ;) But they are used for printing (books etc.)

@Wuzzy2
Copy link
Contributor Author

Wuzzy2 commented Jul 10, 2016 •
edited
Loading

Guillemets are an accepted and valid alternative for quotation marks in Germany, but still OpenRCT2 should support all quotation marks, not just for German but all other languages out there.

And yes, using guillemets would solve this problem at least for German.

@Gymnasiast Gymnasiast added enhancement An improvement to an existing feature (no alteration). and removed requires full implementation labels Dec 23, 2016
Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this issue Jul 23, 2018
@Gymnasiast
Fix OpenRCT2#4039: Add sprite font glyph for German opening quotes
be412a9
Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this issue Jul 23, 2018
@Gymnasiast
Fix OpenRCT2#4039: Add sprite font glyph for German opening quotes
4de5333
Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this issue Jul 23, 2018
@Gymnasiast
Fix OpenRCT2#4039: Add sprite font glyph for German opening quotes
30b0cf8
Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this issue Jul 23, 2018
@Gymnasiast
Fix OpenRCT2#4039: Add sprite font glyph for German opening quotes
13a7867
@Gymnasiast
Copy link
Member

Gymnasiast commented Jul 23, 2018 •
edited
Loading

I have created #7811 to add support for the missing German quotes.
The German translation would still have to be modified, but replacing the double quotes should be easy.

@qqkookie qqkookie mentioned this issue Jul 25, 2018
Closed
qqkookie pushed a commit to qqkookie/OpenRCT2 that referenced this issue Jul 27, 2018
@Gymnasiast @qqkookie
Fix OpenRCT2#4039: Add sprite font glyph for German opening quotes (O…
946fa8b 
…penRCT2#7811)
vijfhoek pushed a commit to vijfhoek/OpenRCT2 that referenced this issue Aug 1, 2018
@Gymnasiast @vijfhoek
Fix OpenRCT2#4039: Add sprite font glyph for German opening quotes (O…
bf460ce 
…penRCT2#7811)
janisozaur added a commit that referenced this issue Aug 26, 2018
@janisozaur
Release 0.2.1
8ac731e 
- Feature: [#5993] Ride window prices can now be set via text input.
- Feature: [#6998] Guests now wait for passing vehicles before crossing railway tracks.
- Feature: [#7658] Add option to always use system file browsing window.
- Feature: [#7694] Debug option to visualize paths that the game detects as wide.
- Feature: [#7713] The virtual floor now takes land ownership rights into account.
- Feature: [#7771] Danish translation.
- Feature: [#7797, #7802, #7821, #7830] Add sprite font glyphs for Danish, Norwegian, Russian, Turkish, Catalan and Romanian.
- Feature: [#7848] Add a master volume slider to audio options screen.
- Feature: [#7868] Placing scenery while holding shift now scales appropriately with zoom levels.
- Feature: [#7882] Auto-detect Steam and GOG installations of RCT1.
- Feature: [#7885] Turkish translation.
- Fix: [#3177] Wrong keys displayed in shortcut menu.
- Fix: [#4039] No sprite font glyph for German opening quotation mark.
- Fix: [#5548] platform_get_locale_date_format is not implemented for Linux.
- Fix: [#7204] Object source filters do not work for RCT1, AA and LL.
- Fix: [#7440] Memory leak. All system memory used.
- Fix: [#7462] Guest window goes beyond the map edge on a spiral slide.
- Fix: [#7533] Screenshot is incorrectly named/file is not generated in CJK language.
- Fix: [#7628] Always-researched items can be modified in the inventory list.
- Fix: [#7643] No Money scenarios with funding set to zero.
- Fix: [#7653] Finances money spinner is too narrow for big loans.
- Fix: [#7673] Vehicle names are cut off in invention list.
- Fix: [#7674] Rides show up as random numbers in guest's ride list.
- Fix: [#7678] Crash when loading or starting a new game while having object selection window open.
- Fix: [#7683] 'Arbitrary ride type' dropdown state is shared between windows.
- Fix: [#7697] Some scenery groups in RCT1 saves are never invented.
- Fix: [#7711] Inverted Hairpin Coaster allows building invisible banked pieces.
- Fix: [#7734] Title sequence not included in macOS builds as of 0.2.0 release.
- Fix: [#7756] Steam RCT2 path not correctly checked on macOS and Linux.
- Fix: [#7765] Crash when opening ride list window on Windows Vista.
- Fix: [#7773] Once research has been completed, player is still charged for research.
- Fix: [#7786] Crash when importing a track design.
- Fix: [#7793] Duplicate private keys generated.
- Fix: [#7817] No sprite font glyph for interpunct.
- Fix: [#7823] You can build mazes in pause mode.
- Fix: [#7804] Russian ride descriptions are cut off.
- Fix: [#7872] CJK tooltips are often cut off.
- Fix: [#7895] Import of Mega Park and the RCT1 title music do not work on some RCT1 sources.
- Improved: [#7899] Timestamps in the load/save screen are now displayed using local timezone instead of GMT.
- Improved: [#7918] Better RCT2 detection if both disc and GOG/Steam versions are installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An improvement to an existing feature (no alteration).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Gymnasiast @Wuzzy2 @Goddesen @danidoedel