Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform_get_locale_date_format is not implemented for Linux. #5548

Closed
IntelOrca opened this issue Jun 5, 2017 · 1 comment
Closed

platform_get_locale_date_format is not implemented for Linux. #5548

IntelOrca opened this issue Jun 5, 2017 · 1 comment
Labels
enhancement An improvement to an existing feature (no alteration). good-first-issue Low hanging fruits good for people new to open source or OpenRCT2. Linux (OS) Related to the Linux version of OpenRCT2.

Comments

@IntelOrca
Copy link
Contributor

platform_get_locale_date_format is not implemented for Linux.

I did try to write an implementation using std::locale and date_order, but I could not get it to pick up the system locale or anything from the LANG or LC_* environment variables without throwing runtime exceptions.

@IntelOrca IntelOrca added the good-first-issue Low hanging fruits good for people new to open source or OpenRCT2. label Jun 5, 2017
@Gymnasiast Gymnasiast added enhancement An improvement to an existing feature (no alteration). Linux (OS) Related to the Linux version of OpenRCT2. labels Jun 6, 2017
@vijfhoek
Copy link
Contributor

vijfhoek commented Jul 22, 2018

I just looked into this, also with std::locale, but this does not seem to be implemented in the standard library yet. Looking at the documentation of std::locale, this is said about date_order:

       *  NOTE: The library always returns noorder at the moment.

However I honestly don't expect this to be implemented anytime soon, we could implement this anyway, defaulting to DMY, and it should just start working once it gets implemented.

vijfhoek added a commit to vijfhoek/OpenRCT2 that referenced this issue Aug 12, 2018
janisozaur added a commit that referenced this issue Aug 26, 2018
- Feature: [#5993] Ride window prices can now be set via text input.
- Feature: [#6998] Guests now wait for passing vehicles before crossing railway tracks.
- Feature: [#7658] Add option to always use system file browsing window.
- Feature: [#7694] Debug option to visualize paths that the game detects as wide.
- Feature: [#7713] The virtual floor now takes land ownership rights into account.
- Feature: [#7771] Danish translation.
- Feature: [#7797, #7802, #7821, #7830] Add sprite font glyphs for Danish, Norwegian, Russian, Turkish, Catalan and Romanian.
- Feature: [#7848] Add a master volume slider to audio options screen.
- Feature: [#7868] Placing scenery while holding shift now scales appropriately with zoom levels.
- Feature: [#7882] Auto-detect Steam and GOG installations of RCT1.
- Feature: [#7885] Turkish translation.
- Fix: [#3177] Wrong keys displayed in shortcut menu.
- Fix: [#4039] No sprite font glyph for German opening quotation mark.
- Fix: [#5548] platform_get_locale_date_format is not implemented for Linux.
- Fix: [#7204] Object source filters do not work for RCT1, AA and LL.
- Fix: [#7440] Memory leak. All system memory used.
- Fix: [#7462] Guest window goes beyond the map edge on a spiral slide.
- Fix: [#7533] Screenshot is incorrectly named/file is not generated in CJK language.
- Fix: [#7628] Always-researched items can be modified in the inventory list.
- Fix: [#7643] No Money scenarios with funding set to zero.
- Fix: [#7653] Finances money spinner is too narrow for big loans.
- Fix: [#7673] Vehicle names are cut off in invention list.
- Fix: [#7674] Rides show up as random numbers in guest's ride list.
- Fix: [#7678] Crash when loading or starting a new game while having object selection window open.
- Fix: [#7683] 'Arbitrary ride type' dropdown state is shared between windows.
- Fix: [#7697] Some scenery groups in RCT1 saves are never invented.
- Fix: [#7711] Inverted Hairpin Coaster allows building invisible banked pieces.
- Fix: [#7734] Title sequence not included in macOS builds as of 0.2.0 release.
- Fix: [#7756] Steam RCT2 path not correctly checked on macOS and Linux.
- Fix: [#7765] Crash when opening ride list window on Windows Vista.
- Fix: [#7773] Once research has been completed, player is still charged for research.
- Fix: [#7786] Crash when importing a track design.
- Fix: [#7793] Duplicate private keys generated.
- Fix: [#7817] No sprite font glyph for interpunct.
- Fix: [#7823] You can build mazes in pause mode.
- Fix: [#7804] Russian ride descriptions are cut off.
- Fix: [#7872] CJK tooltips are often cut off.
- Fix: [#7895] Import of Mega Park and the RCT1 title music do not work on some RCT1 sources.
- Improved: [#7899] Timestamps in the load/save screen are now displayed using local timezone instead of GMT.
- Improved: [#7918] Better RCT2 detection if both disc and GOG/Steam versions are installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature (no alteration). good-first-issue Low hanging fruits good for people new to open source or OpenRCT2. Linux (OS) Related to the Linux version of OpenRCT2.
Projects
None yet
Development

No branches or pull requests

3 participants