Crash when opening ride list window on Windows Vista #7765

jamtraks · 2018-07-08T00:47:09Z

OS: windows vista 32-bit
Version: 0.2.0-139
Commit/Build: 66bfd42 on develop

instantly after i press the rides/attractions in park icon (spiral slide icon) fifth from right going left in the upper right hand corner, my game freezes/crashes.

[no ] Reproducible in RCT2 (vanilla)?
[no ] Specific to multiplayer?

Steps to reproduce:

press rides/attractions in park icon during game happens in all parks i have tested (ne design parks and my own)

Dump file
none that i am aware of

The text was updated successfully, but these errors were encountered:

IntelOrca · 2018-07-08T09:43:28Z

You will need to provide us a dump file. To do this, when the game crashes, make sure you do not let the game close by clicking any buttons on the prompt that appears. Instead follow the instructions in this link.

https://support.kaspersky.com/3518 (select openrct2 in processes)

jamtraks · 2018-07-09T04:06:47Z

The dump file is 206,843kb and 79,338kb compressed. Github is not allowing me to upload a file this large.
I uploaded the dump file to mediafire.com it is here: http://www.mediafire.com/file/jx3gw5rgz6az41a/openrct2.zip

IntelOrca · 2018-07-09T07:05:57Z

The PDB for the specified commit will not load for the dump file. Not sure why.
The crash appears to be happening in ToUpper.

 	ntdll.dll!_KiFastSystemCallRet@0�()	Unknown
 	ntdll.dll!_ZwWaitForMultipleObjects@20�()	Unknown
 	kernel32.dll!_WaitForMultipleObjectsEx@20�()	Unknown
 	kernel32.dll!_WaitForMultipleObjects@16�()	Unknown
 	kernel32.dll!_WerpReportFaultInternal@8�()	Unknown
 	kernel32.dll!_WerpReportFault@8�()	Unknown
 	kernel32.dll!_UnhandledExceptionFilter@4�()	Unknown
 	ntdll.dll!___RtlUserThreadStart@8�()	Unknown
 	ntdll.dll!@_EH4_CallFilterFunc@8�()	Unknown
 	ntdll.dll!ExecuteHandler2@20�()	Unknown
 	ntdll.dll!ExecuteHandler@20�()	Unknown
 	ntdll.dll!_KiUserExceptionDispatcher@8�()	Unknown
 	kernel32.dll!_MapCase@24�()	Unknown
 	kernel32.dll!_LCMapStringWorker@36�()	Unknown
 	kernel32.dll!_LCMapStringEx@36�()	Unknown
 	openrct2.dll!62a0fddb()	Unknown
 	[Frames below may be incorrect and/or missing, no symbols loaded for openrct2.dll]	
>	openrct2.dll!6297b2a1()	Unknown
 	openrct2.dll!6296cbde()	Unknown
 	openrct2.dll!62a0e10c()	Unknown
 	openrct2.dll!62972bd3()	Unknown
 	openrct2.dll!629e3953()	Unknown
 	openrct2.dll!6297a605()	Unknown
 	openrct2.dll!6297351b()	Unknown
 	openrct2.dll!629e5f6a()	Unknown
 	openrct2.dll!629df4a3()	Unknown
 	openrct2.dll!629afe23()	Unknown
 	openrct2.dll!6295c26a()	Unknown
 	openrct2.dll!6295b00f()	Unknown
 	openrct2.dll!6295a709()	Unknown
 	openrct2.dll!629df04b()	Unknown
 	openrct2.dll!62a03dfa()	Unknown
 	openrct2.dll!629de411()	Unknown
 	openrct2.dll!629ddfc1()	Unknown
 	openrct2.dll!629dde5a()	Unknown
 	openrct2.dll!629dc26a()	Unknown
 	openrct2.dll!62953334()	Unknown
 	openrct2.dll!62952dc2()	Unknown
 	openrct2.exe!00fa100f()	Unknown
 	openrct2.exe!00fa11cc()	Unknown

IntelOrca · 2018-07-09T07:08:55Z

@jamtraks could you upload the saved game please?

jamtraks · 2018-07-09T09:04:45Z

This is the saved game that i happened to have open during this particular crash:
Crazy Castle By Josh Marsilio 4.07.sv6.zip
I'm pretty sure this is the park that was open while i created this particular dump file. But like i said, my game is crashing when i press the "rides/attractions in park" icon during almost any loaded save-game including those from "ne design".

I just tested for a crash during a "new" game, i selected "forest frontiers" from the start menu through "new game" button. Next I pressed the "rides/attractions in park" button immediately after starting a "new" forest frontiers game, and the game did not crash, and the "rides/attractions in park" menu opened.
After starting a new "africa-african diamond mine" game though, i do get the crash when pressing the "rides/attractions in park" button, but this is not so for most of the other wacky worlds/time twister new games....
I did do something "screwy" a while back while trying to install the expansion packs for free. I don't know if this has anything to do with my problem?
However i did not have this problem weeks ago or maybe a month or two ago.

IntelOrca · 2018-07-09T09:40:18Z

@jamtraks The crash is coming from a function that converts text to upper case. In particular this is used as a means for sorting the ride list case insensitive. We recently updated the function to convert to upper case so that it handles unicode.

I don't see anything wrong with the way we are calling LCMapStringEx so it is quite possible that there are bugs with it on Windows Vista even though MSDN says that it is supported.

jamtraks · 2018-07-09T12:27:28Z

Okay, well i do not know the technicalities associated with LCMapStringEx for example, but i do understand that you are saying that this is a problem specific to windows vista.
I often wish i could buy a newer computer, but i just cannot afford one right now.
Well thank you anyway... are you going to bother to attempt to fix this?

IntelOrca · 2018-07-09T12:30:17Z

I would like to, but I do not know what the problem is and I can not find any information on the internet about it.

jamtraks · 2018-07-09T12:34:34Z

Okay, well i am still able to do most things in the game and i can simply play without the rides/attractions feature for now at least.
i wish 'I could help but i am not yet, and may never be a "programmer".
Thank you anyway, i hope that this is not completely forgotten, and i hope that it can be solved at sometime for the sake of myself and any other "Vista" users ... if there are any...

qwertychouskie · 2018-07-09T20:49:49Z

@jamtraks Have you considered switching to Xubuntu (https://xubuntu.org/)? That way you get a supported OS, but it is still lightweight for older computers. In fact, it will almost certainly run a lot faster than Vista on the same hardware (speaking from personal experience).

IntelOrca · 2018-07-10T07:13:53Z

@jamtraks What locale is your OS set to? In other words the country / language Windows is in for you?

jamtraks · 2018-07-10T15:14:28Z

My os is definitely in english i'm in the u.s. and it's set to whatever default/standard settings there are. and qwertychouskie, i am reluctant to try any other os for this laptop i do not want to have issues/problems with any other software, so i think i will stick with vista for now.

I sometimes turn "user account control" on and off for this laptop. "user account control" being on, causes my computer to block and ask permission for certain software. It is a sort of double protection that my computer uses to block potential threats. Right now it is set to"off". I can't imagine though, how this being on would have caused any issue with the "rides/attractions" feature.

moTechPlz · 2018-07-12T21:01:18Z

I made a vista 32 installation on a spare computer and recreated this crash. Testing shows vista does not accept the LOCALE_NAME_INVARIANT value although msdn says it should. SYSTEM and USER_DEFAULT do work for me. Possibly vista tries to use the value as a pointer to a local name string.

IntelOrca · 2018-07-12T22:39:03Z

@moTechPlz That is helpful, thanks. I think we might be able to get away with using USER_DEFAULT then.

It has been reported that Windows Vista crashes in LCMapStringEx when using LOCALE_NAME_INVARIANT even though it is documented as supported. As a counter measure, use LOCALE_NAME_USER_DEFAULT for the time being.

IntelOrca · 2018-07-13T20:18:39Z

@jamtraks Could you test this build please and let me know if the issue is fixed?

https://ci.appveyor.com/api/buildjobs/u9ubqxq8vgt54goq/artifacts/artifacts%2Fopenrct2-portable-release-x64-f559ebc.zip

janisozaur · 2018-07-13T20:38:32Z

@IntelOrca it won't work.

OS: windows vista 32-bit

jamtraks · 2018-07-13T20:57:26Z

@IntelOrca, i use x86 (32-bit) this .exe will not open on my laptop.

IntelOrca · 2018-07-14T00:21:44Z

32-bit: https://ci.appveyor.com/api/buildjobs/rhscr2w61b119exl/artifacts/artifacts%2Fopenrct2-portable-release-win32.zip

jamtraks · 2018-07-14T01:19:11Z

i tested a few parks now with this build. the problem seems to be fixed.

jamtraks · 2018-08-20T15:11:01Z

Just to add a note: the crash is still occurring if i download "release", but it remains fixed and functional in "develop". This is good enough for me, but just letting you know.

AaronVanGeffen · 2018-08-20T15:12:59Z

That is to be expected, until we release v0.2.1.

- Feature: [#5993] Ride window prices can now be set via text input. - Feature: [#6998] Guests now wait for passing vehicles before crossing railway tracks. - Feature: [#7658] Add option to always use system file browsing window. - Feature: [#7694] Debug option to visualize paths that the game detects as wide. - Feature: [#7713] The virtual floor now takes land ownership rights into account. - Feature: [#7771] Danish translation. - Feature: [#7797, #7802, #7821, #7830] Add sprite font glyphs for Danish, Norwegian, Russian, Turkish, Catalan and Romanian. - Feature: [#7848] Add a master volume slider to audio options screen. - Feature: [#7868] Placing scenery while holding shift now scales appropriately with zoom levels. - Feature: [#7882] Auto-detect Steam and GOG installations of RCT1. - Feature: [#7885] Turkish translation. - Fix: [#3177] Wrong keys displayed in shortcut menu. - Fix: [#4039] No sprite font glyph for German opening quotation mark. - Fix: [#5548] platform_get_locale_date_format is not implemented for Linux. - Fix: [#7204] Object source filters do not work for RCT1, AA and LL. - Fix: [#7440] Memory leak. All system memory used. - Fix: [#7462] Guest window goes beyond the map edge on a spiral slide. - Fix: [#7533] Screenshot is incorrectly named/file is not generated in CJK language. - Fix: [#7628] Always-researched items can be modified in the inventory list. - Fix: [#7643] No Money scenarios with funding set to zero. - Fix: [#7653] Finances money spinner is too narrow for big loans. - Fix: [#7673] Vehicle names are cut off in invention list. - Fix: [#7674] Rides show up as random numbers in guest's ride list. - Fix: [#7678] Crash when loading or starting a new game while having object selection window open. - Fix: [#7683] 'Arbitrary ride type' dropdown state is shared between windows. - Fix: [#7697] Some scenery groups in RCT1 saves are never invented. - Fix: [#7711] Inverted Hairpin Coaster allows building invisible banked pieces. - Fix: [#7734] Title sequence not included in macOS builds as of 0.2.0 release. - Fix: [#7756] Steam RCT2 path not correctly checked on macOS and Linux. - Fix: [#7765] Crash when opening ride list window on Windows Vista. - Fix: [#7773] Once research has been completed, player is still charged for research. - Fix: [#7786] Crash when importing a track design. - Fix: [#7793] Duplicate private keys generated. - Fix: [#7817] No sprite font glyph for interpunct. - Fix: [#7823] You can build mazes in pause mode. - Fix: [#7804] Russian ride descriptions are cut off. - Fix: [#7872] CJK tooltips are often cut off. - Fix: [#7895] Import of Mega Park and the RCT1 title music do not work on some RCT1 sources. - Improved: [#7899] Timestamps in the load/save screen are now displayed using local timezone instead of GMT. - Improved: [#7918] Better RCT2 detection if both disc and GOG/Steam versions are installed.

IntelOrca added the crash Game exits suddenly. label Jul 8, 2018

IntelOrca changed the title ~~Game is crashing when i press rides/attractions in park icon~~ Crash when opening ride list window on Windows Vista Jul 13, 2018

IntelOrca added a commit to IntelOrca/OpenRCT2 that referenced this issue Jul 13, 2018

Fix OpenRCT2#7765: Crash when opening ride list window on Windows Vista

4ead722

IntelOrca closed this as completed in f728a50 Jul 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crash when opening ride list window on Windows Vista #7765

Crash when opening ride list window on Windows Vista #7765

jamtraks commented Jul 8, 2018

IntelOrca commented Jul 8, 2018 •

edited

Loading

jamtraks commented Jul 9, 2018 •

edited

Loading

IntelOrca commented Jul 9, 2018

IntelOrca commented Jul 9, 2018

jamtraks commented Jul 9, 2018 •

edited

Loading

IntelOrca commented Jul 9, 2018 •

edited

Loading

jamtraks commented Jul 9, 2018

IntelOrca commented Jul 9, 2018

jamtraks commented Jul 9, 2018 •

edited

Loading

qwertychouskie commented Jul 9, 2018

IntelOrca commented Jul 10, 2018

jamtraks commented Jul 10, 2018 •

edited

Loading

moTechPlz commented Jul 12, 2018

IntelOrca commented Jul 12, 2018

IntelOrca commented Jul 13, 2018

janisozaur commented Jul 13, 2018

jamtraks commented Jul 13, 2018 •

edited

Loading

IntelOrca commented Jul 14, 2018

jamtraks commented Jul 14, 2018 •

edited

Loading

jamtraks commented Aug 20, 2018

AaronVanGeffen commented Aug 20, 2018

Crash when opening ride list window on Windows Vista #7765

Crash when opening ride list window on Windows Vista #7765

Comments

jamtraks commented Jul 8, 2018

IntelOrca commented Jul 8, 2018 • edited Loading

jamtraks commented Jul 9, 2018 • edited Loading

IntelOrca commented Jul 9, 2018

IntelOrca commented Jul 9, 2018

jamtraks commented Jul 9, 2018 • edited Loading

IntelOrca commented Jul 9, 2018 • edited Loading

jamtraks commented Jul 9, 2018

IntelOrca commented Jul 9, 2018

jamtraks commented Jul 9, 2018 • edited Loading

qwertychouskie commented Jul 9, 2018

IntelOrca commented Jul 10, 2018

jamtraks commented Jul 10, 2018 • edited Loading

moTechPlz commented Jul 12, 2018

IntelOrca commented Jul 12, 2018

IntelOrca commented Jul 13, 2018

janisozaur commented Jul 13, 2018

jamtraks commented Jul 13, 2018 • edited Loading

IntelOrca commented Jul 14, 2018

jamtraks commented Jul 14, 2018 • edited Loading

jamtraks commented Aug 20, 2018

AaronVanGeffen commented Aug 20, 2018

IntelOrca commented Jul 8, 2018 •

edited

Loading

jamtraks commented Jul 9, 2018 •

edited

Loading

jamtraks commented Jul 9, 2018 •

edited

Loading

IntelOrca commented Jul 9, 2018 •

edited

Loading

jamtraks commented Jul 9, 2018 •

edited

Loading

jamtraks commented Jul 10, 2018 •

edited

Loading

jamtraks commented Jul 13, 2018 •

edited

Loading

jamtraks commented Jul 14, 2018 •

edited

Loading