Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot is incorrectly named/file is not generated in CJK language #7533

Closed
telk5093 opened this issue May 16, 2018 · 5 comments
Closed
Labels
bug Something went wrong. Windows (OS) Related to the Windows version of OpenRCT2.

Comments

@telk5093
Copy link
Contributor

OS: Windows 10
Version: 0.1.3
Commit/Build: 94f005a

If the scenario name is Korean(and maybe Japanese or chinese too), then screenshot file name is incorrectly named or file itself is not generated.

Steps to reproduce:

  1. Set the language to Korean
  2. Open any default scenario, such as Roaring Twenties - Skyscrapers (its korean translation is 광란의 20년대 - 마천루)
  3. Take any screenshot.
  4. Game generates the screenshot as this file name: 硫뷀듃濡쒗뤃由ъ뒪 2018-05-17 02-43-37
  5. Or game doesn't generate the screenshot file in certain scenarios.

Maybe related to #7415

@Gymnasiast Gymnasiast added the bug Something went wrong. label May 16, 2018
@Gymnasiast
Copy link
Member

I don't think it is related to #7415.

@AaronVanGeffen
Copy link
Member

I can't reproduce this on Linux; a screenshot of Crazy Castle is saved as 이상한 성 2018-05-24 11-55-31.png. However, for unicode support, Windows uses a very different code path… Does this still happen for you?

@AaronVanGeffen AaronVanGeffen added the Windows (OS) Related to the Windows version of OpenRCT2. label May 24, 2018
@telk5093
Copy link
Contributor Author

@AaronVanGeffen Yes.
When I (1)set in English, (2)open Crazy Castle, (3)set in Korean again, (4)take a screenshot,
then the scenario name is still Crazy Castle, not 이상한 성 so that screenshot file is generated correctly.

If scenario name is written/displayed in korean, then file is not generated or incorrectly named for me.

@AaronVanGeffen
Copy link
Member

AaronVanGeffen commented May 25, 2018

This might be due to #7502 refactoring the screenshot routines, then. Could you test whether the problem does occur on 3278fd5 (build), and not on 00278c6 (build)?

@AaronVanGeffen
Copy link
Member

With some help from a friend, I can confirm this was introduced to develop in 3278fd5 (build). The commit right before the shared_ptr mergers (d284bcc, build) saves screenshots with the correct filenames.

Unfortunately, the commit right before this, (00278c6, build) crashes while building the scenario list.

In short, this issue appears to have arisen in #7502, as I suspected. @IntelOrca, could you have a look?

janisozaur added a commit that referenced this issue Aug 26, 2018
- Feature: [#5993] Ride window prices can now be set via text input.
- Feature: [#6998] Guests now wait for passing vehicles before crossing railway tracks.
- Feature: [#7658] Add option to always use system file browsing window.
- Feature: [#7694] Debug option to visualize paths that the game detects as wide.
- Feature: [#7713] The virtual floor now takes land ownership rights into account.
- Feature: [#7771] Danish translation.
- Feature: [#7797, #7802, #7821, #7830] Add sprite font glyphs for Danish, Norwegian, Russian, Turkish, Catalan and Romanian.
- Feature: [#7848] Add a master volume slider to audio options screen.
- Feature: [#7868] Placing scenery while holding shift now scales appropriately with zoom levels.
- Feature: [#7882] Auto-detect Steam and GOG installations of RCT1.
- Feature: [#7885] Turkish translation.
- Fix: [#3177] Wrong keys displayed in shortcut menu.
- Fix: [#4039] No sprite font glyph for German opening quotation mark.
- Fix: [#5548] platform_get_locale_date_format is not implemented for Linux.
- Fix: [#7204] Object source filters do not work for RCT1, AA and LL.
- Fix: [#7440] Memory leak. All system memory used.
- Fix: [#7462] Guest window goes beyond the map edge on a spiral slide.
- Fix: [#7533] Screenshot is incorrectly named/file is not generated in CJK language.
- Fix: [#7628] Always-researched items can be modified in the inventory list.
- Fix: [#7643] No Money scenarios with funding set to zero.
- Fix: [#7653] Finances money spinner is too narrow for big loans.
- Fix: [#7673] Vehicle names are cut off in invention list.
- Fix: [#7674] Rides show up as random numbers in guest's ride list.
- Fix: [#7678] Crash when loading or starting a new game while having object selection window open.
- Fix: [#7683] 'Arbitrary ride type' dropdown state is shared between windows.
- Fix: [#7697] Some scenery groups in RCT1 saves are never invented.
- Fix: [#7711] Inverted Hairpin Coaster allows building invisible banked pieces.
- Fix: [#7734] Title sequence not included in macOS builds as of 0.2.0 release.
- Fix: [#7756] Steam RCT2 path not correctly checked on macOS and Linux.
- Fix: [#7765] Crash when opening ride list window on Windows Vista.
- Fix: [#7773] Once research has been completed, player is still charged for research.
- Fix: [#7786] Crash when importing a track design.
- Fix: [#7793] Duplicate private keys generated.
- Fix: [#7817] No sprite font glyph for interpunct.
- Fix: [#7823] You can build mazes in pause mode.
- Fix: [#7804] Russian ride descriptions are cut off.
- Fix: [#7872] CJK tooltips are often cut off.
- Fix: [#7895] Import of Mega Park and the RCT1 title music do not work on some RCT1 sources.
- Improved: [#7899] Timestamps in the load/save screen are now displayed using local timezone instead of GMT.
- Improved: [#7918] Better RCT2 detection if both disc and GOG/Steam versions are installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something went wrong. Windows (OS) Related to the Windows version of OpenRCT2.
Projects
None yet
Development

No branches or pull requests

3 participants