Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard layout wrong in keyboard shortcuts #3177

Closed
2 tasks
rvgr opened this issue Mar 26, 2016 · 2 comments
Closed
2 tasks

Keyboard layout wrong in keyboard shortcuts #3177

rvgr opened this issue Mar 26, 2016 · 2 comments
Labels
bug Something went wrong. user interface Has to do with user interfaces.

Comments

@rvgr
Copy link
Contributor

rvgr commented Mar 26, 2016

OS: MacOS 10.11.4
Version: 0.0.4

When settings keyboard shortcuts, if you have an AZERTY keyboard, it will display the QWERTY character.

For example, if you set a shortcut to A, it will be shown as Q. However it will work when pressing A.

  • Reproducable in RCT2 (vanilla)?
  • Multiplayer?
@IntelOrca IntelOrca added bug Something went wrong. user interface Has to do with user interfaces. labels Mar 26, 2016
@mrtnptrs
Copy link
Contributor

Does someone have an AZERTY keyboard and can reproduce this too?

@Goddesen
Copy link
Contributor

Goddesen commented Jun 18, 2016 •
edited
Loading

This holds true for any non-qwerty keyboard layout (tested with colemak).

edit: So this is obviously the cause of using hardcoded SDL_SCANCODE values. I'm assuming this is equivalent to what the original game did. Is there anythign stopping us from just rewriting the keyboard handling to using keycodes instead?

@Goddesen Goddesen mentioned this issue Jun 19, 2016
Closed
muemart added a commit to muemart/OpenRCT2 that referenced this issue Jul 1, 2018
@muemart
Fix OpenRCT2#3177: Wrong keys displayed in shortcut menu
860e4f5 
SDL_GetScancodeName doesn't actually translate the scancode to the physical key, so first we need to convert the scancode to a keycode and then turn the keycode into a string.
Gymnasiast pushed a commit to muemart/OpenRCT2 that referenced this issue Jul 3, 2018
@muemart @Gymnasiast
Fix OpenRCT2#3177: Wrong keys displayed in shortcut menu
0d107b6 
SDL_GetScancodeName doesn't actually translate the scancode to the physical key, so first we need to convert the scancode to a keycode and then turn the keycode into a string.
janisozaur added a commit that referenced this issue Aug 26, 2018
@janisozaur
Release 0.2.1
8ac731e 
- Feature: [#5993] Ride window prices can now be set via text input.
- Feature: [#6998] Guests now wait for passing vehicles before crossing railway tracks.
- Feature: [#7658] Add option to always use system file browsing window.
- Feature: [#7694] Debug option to visualize paths that the game detects as wide.
- Feature: [#7713] The virtual floor now takes land ownership rights into account.
- Feature: [#7771] Danish translation.
- Feature: [#7797, #7802, #7821, #7830] Add sprite font glyphs for Danish, Norwegian, Russian, Turkish, Catalan and Romanian.
- Feature: [#7848] Add a master volume slider to audio options screen.
- Feature: [#7868] Placing scenery while holding shift now scales appropriately with zoom levels.
- Feature: [#7882] Auto-detect Steam and GOG installations of RCT1.
- Feature: [#7885] Turkish translation.
- Fix: [#3177] Wrong keys displayed in shortcut menu.
- Fix: [#4039] No sprite font glyph for German opening quotation mark.
- Fix: [#5548] platform_get_locale_date_format is not implemented for Linux.
- Fix: [#7204] Object source filters do not work for RCT1, AA and LL.
- Fix: [#7440] Memory leak. All system memory used.
- Fix: [#7462] Guest window goes beyond the map edge on a spiral slide.
- Fix: [#7533] Screenshot is incorrectly named/file is not generated in CJK language.
- Fix: [#7628] Always-researched items can be modified in the inventory list.
- Fix: [#7643] No Money scenarios with funding set to zero.
- Fix: [#7653] Finances money spinner is too narrow for big loans.
- Fix: [#7673] Vehicle names are cut off in invention list.
- Fix: [#7674] Rides show up as random numbers in guest's ride list.
- Fix: [#7678] Crash when loading or starting a new game while having object selection window open.
- Fix: [#7683] 'Arbitrary ride type' dropdown state is shared between windows.
- Fix: [#7697] Some scenery groups in RCT1 saves are never invented.
- Fix: [#7711] Inverted Hairpin Coaster allows building invisible banked pieces.
- Fix: [#7734] Title sequence not included in macOS builds as of 0.2.0 release.
- Fix: [#7756] Steam RCT2 path not correctly checked on macOS and Linux.
- Fix: [#7765] Crash when opening ride list window on Windows Vista.
- Fix: [#7773] Once research has been completed, player is still charged for research.
- Fix: [#7786] Crash when importing a track design.
- Fix: [#7793] Duplicate private keys generated.
- Fix: [#7817] No sprite font glyph for interpunct.
- Fix: [#7823] You can build mazes in pause mode.
- Fix: [#7804] Russian ride descriptions are cut off.
- Fix: [#7872] CJK tooltips are often cut off.
- Fix: [#7895] Import of Mega Park and the RCT1 title music do not work on some RCT1 sources.
- Improved: [#7899] Timestamps in the load/save screen are now displayed using local timezone instead of GMT.
- Improved: [#7918] Better RCT2 detection if both disc and GOG/Steam versions are installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something went wrong. user interface Has to do with user interfaces.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework keyboard handling to use keycodes (allowing for non-qwerty layouts) Goddesen/OpenRCT2
4 participants
@IntelOrca @mrtnptrs @Goddesen @rvgr