Add sprite font glyphs for Æ and Ø #7797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gymnasiast
added
help wanted
| { 0, 0, 0, 255 }, | ||
| { 0, 0, 0, 255 }, | ||
| { 0, 0, 0, 255 }, | ||
| { 0, 0, 1, 255 }, |
There was a problem hiding this comment.
Why did you change these? The third octet represents red, not an index, right?
There was a problem hiding this comment.
Mostly to help distinguish the separate indices a bit. I can revert this bit if preferred.
There was a problem hiding this comment.
Why didn't you just use comments?
There was a problem hiding this comment.
I wanted it to help distinguish colours in image modifying programs. Comments don't help there.
Again, I can revert this bit.
There was a problem hiding this comment.
Oh I see. In that case shouldn't you do increments of 20 or perhaps different hues?
| @@ -840,6 +840,14 @@ enum { | |||
|
|
|||
| SPR_G2_EYEDROPPER = SPR_G2_BEGIN + 123, | |||
|
|
|||
| SPR_G2_CHAR_BEGIN = SPR_G2_BEGIN + 124, | |||
There was a problem hiding this comment.
I think we ought to make constants for each of the different fonts (small, normal, tiny).
src/openrct2/sprites.h
Outdated
| SPR_G2_O_STROKE_UPPER = SPR_G2_CHAR_BEGIN + 2, | ||
| SPR_G2_O_STROKE_LOWER = SPR_G2_CHAR_BEGIN + 3, | ||
|
|
||
| SPR_G2_GLYPH_COUNT = (SPR_G2_O_STROKE_LOWER - SPR_G2_CHAR_BEGIN) + 1, |
There was a problem hiding this comment.
This is off, I think, because you have only taken the small font into account.
There was a problem hiding this comment.
This is how the vanilla glyph count works as well. It's more useful like this anyway.
Gymnasiast
force-pushed
the
extra-letters
branch
from
6fc7429
to
54aac04
Compare
Gymnasiast
force-pushed
the
extra-letters
branch
from
54aac04
to
5fdc463
Compare
janisozaur
added a commit
that referenced
this pull request
Aug 26, 2018
- Feature: [#5993] Ride window prices can now be set via text input. - Feature: [#6998] Guests now wait for passing vehicles before crossing railway tracks. - Feature: [#7658] Add option to always use system file browsing window. - Feature: [#7694] Debug option to visualize paths that the game detects as wide. - Feature: [#7713] The virtual floor now takes land ownership rights into account. - Feature: [#7771] Danish translation. - Feature: [#7797, #7802, #7821, #7830] Add sprite font glyphs for Danish, Norwegian, Russian, Turkish, Catalan and Romanian. - Feature: [#7848] Add a master volume slider to audio options screen. - Feature: [#7868] Placing scenery while holding shift now scales appropriately with zoom levels. - Feature: [#7882] Auto-detect Steam and GOG installations of RCT1. - Feature: [#7885] Turkish translation. - Fix: [#3177] Wrong keys displayed in shortcut menu. - Fix: [#4039] No sprite font glyph for German opening quotation mark. - Fix: [#5548] platform_get_locale_date_format is not implemented for Linux. - Fix: [#7204] Object source filters do not work for RCT1, AA and LL. - Fix: [#7440] Memory leak. All system memory used. - Fix: [#7462] Guest window goes beyond the map edge on a spiral slide. - Fix: [#7533] Screenshot is incorrectly named/file is not generated in CJK language. - Fix: [#7628] Always-researched items can be modified in the inventory list. - Fix: [#7643] No Money scenarios with funding set to zero. - Fix: [#7653] Finances money spinner is too narrow for big loans. - Fix: [#7673] Vehicle names are cut off in invention list. - Fix: [#7674] Rides show up as random numbers in guest's ride list. - Fix: [#7678] Crash when loading or starting a new game while having object selection window open. - Fix: [#7683] 'Arbitrary ride type' dropdown state is shared between windows. - Fix: [#7697] Some scenery groups in RCT1 saves are never invented. - Fix: [#7711] Inverted Hairpin Coaster allows building invisible banked pieces. - Fix: [#7734] Title sequence not included in macOS builds as of 0.2.0 release. - Fix: [#7756] Steam RCT2 path not correctly checked on macOS and Linux. - Fix: [#7765] Crash when opening ride list window on Windows Vista. - Fix: [#7773] Once research has been completed, player is still charged for research. - Fix: [#7786] Crash when importing a track design. - Fix: [#7793] Duplicate private keys generated. - Fix: [#7817] No sprite font glyph for interpunct. - Fix: [#7823] You can build mazes in pause mode. - Fix: [#7804] Russian ride descriptions are cut off. - Fix: [#7872] CJK tooltips are often cut off. - Fix: [#7895] Import of Mega Park and the RCT1 title music do not work on some RCT1 sources. - Improved: [#7899] Timestamps in the load/save screen are now displayed using local timezone instead of GMT. - Improved: [#7918] Better RCT2 detection if both disc and GOG/Steam versions are installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glyphs are fine, but the code to detect the width does not work properly, and I have a feeling some things could be done better. I am opening this pull request to get advice/help with that.
Requires #7801 to be merged first.