The view of a peep in his window goes beyond the edge of the map when he's on a spiral slide.

[ocalhoun6]

OS: Windows 8
Version: e.g. 0.1.3
Commit/Build: 2512e49

If you have a window open to watch a particular peep, and that peep gets on a spiral slide, the view window will jump out beyond the edge of the map while that peep is on the slide, then jump back as soon as he's getting off it.

As far as I can tell, the spiral slide is the only ride that does this.

• [ ? ] Reproducible in RCT2 (vanilla)?
• [ No ] Specific to multiplayer?

Steps to reproduce:

1. Click on a peep in the queue line for a spiral slide.
2. Watch him through the small window while he rides the slide.

Screenshots / Video:

(In these screenshots, the main view is also way out on the edge of the map, but that's intentional and doesn't have anything to do with this bug.)

[Gymnasiast]

The spiral slide is a bit of an oddball when it comes to drawing, as all of the images are hardcoded - the .DAT only contains images for the New Ride window preview!

[duncanspumpkin]

Spiral slide has so much special code for it. When a peep enters the ride they are moved to null location. I'll have to have a look at how this works for normal rides as they also move the peep to null. Does this happen on vanilla?

[ArDee20p]

Vanilla treats the Spiral Slide the same as any other flatride for the peep viewport (centering view on the ride, like in the ride window viewport). I've spent enough hours in vanilla that I think I'd distinctly remember if it didn't, since that's a pretty noticeable visual bug.

[moTechPlz]

OS: Windows 10

[ ? ] Reproducible in RCT2 (vanilla)?

No, vanilla renders the spiral slide building when the guest is on the ride.

I have researched this and the spiral slide is one of or the only triggering the VIEWPORT_FOCUS_TYPE_COORDINATE code. Other similar rides use VIEWPORT_FOCUS_TYPE_SPRITE.

OpenRCT2/src/openrct2-ui/windows/Guest.cpp

Lines 690 to 693 in f963f96

	union{
	sprite_focus sprite;
	coordinate_focus coordinate;
	} focus = {}; // The focus will be either a sprite or a coordinate.

OpenRCT2/src/openrct2-ui/windows/Guest.cpp

Lines 721 to 731 in f963f96

	if (peep->x == LOCATION_NULL && final_check){
	Ride *ride = get_ride(peep->current_ride);
	int32_t x = ride->overall_view.x * 32 + 16;
	int32_t y = ride->overall_view.y * 32 + 16;
	int32_t height = tile_element_height(x, y);
	height += 32;
	focus.coordinate.x = x;
	focus.coordinate.y = y;
	focus.coordinate.z = height;
	focus.sprite.type |= VIEWPORT_FOCUS_TYPE_COORDINATE;
	}

This is a very weird bug. Took some time to figure out. Somehow this command

OpenRCT2/src/openrct2-ui/windows/Guest.cpp

Line 730 in f963f96

focus.sprite.type |= VIEWPORT_FOCUS_TYPE_COORDINATE;

overwrites the data in the coordinate struct of focus, specifically focus.coordinate.y. Data set just before this command.

OpenRCT2/src/openrct2-ui/windows/Guest.cpp

Lines 727 to 729 in f963f96

	focus.coordinate.x = x;
	focus.coordinate.y = y;
	focus.coordinate.z = height;

If i remove the offending command or split the focus struct in two the bug disappears.

[moTechPlz]

Ok figured it out.

A union is a special data type available in C that allows storing different data types in the same memory location.

Since the function tries to store and retrieve from both the coordinate and sprite data structs it cannot be a union,

this fixes the bug

 struct{ 
     sprite_focus sprite; 
     coordinate_focus coordinate; 
 } focus = {}; // The focus will be both a sprite and a coordinate. 

do you people want me to open pull requests for these bug fixes?

[IntelOrca]

do you people want me to open pull requests for these bug fixes?

Yes please!