Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Asian tooltip text is truncated. Option "Disable audio on focus loss" does not work on ride music. #7872

Closed
2 tasks
qqkookie opened this issue Aug 11, 2018 · 2 comments

Comments

@qqkookie
Copy link

qqkookie commented Aug 11, 2018

OS: Windows 10
Version: 0.2.0
Commit/Build:

The long tooltip text in some windows are truncated in Asian language like Korean. Here is example in Option screen >> Title screen music dropdown menu tooltip. Korean tooltip is truncated and error message is printed in debug version. It is due to the gCommonStringFormatBuffer[256] buffer is way too small. Note that one Asian character requires 3 bytes of UTF8 chars. Some tooltip text in Korean exceeds 425 bytes in UTF8 string. So the gCommonStringFormatBuffer buffer should be increase to 512 bytes. The source code for localisation/tooltip should be changed like below:
On "OpenRCT2\src\openrct2\localisation\Localisation.cpp" : line 38
char gCommonStringFormatBuffer[512];

On "OpenRCT2\src\openrct2\localisation\Localisation.cpp" : line 66
extern char gCommonStringFormatBuffer[512];

On "OpenRCT2\src\openrct2-ui\windows\Tooltip.cpp" : line 87
OLD:
format_string(buffer, 256, id, gCommonFormatArgs);
NEW:
`format_string(buffer, sizeof gCommonStringFormatBuffer, id, gCommonFormatArgs);


2nd error is that if Sound options are so that sound effect is disabled but ride music is enabled in Option , then the "Disable audio on focus loss:" does not work. The Ride music keeps playing even after focus loss. if ride music is enabled alone. To fix this error:

From "OpenRCT2\src\openrct2-ui\UiContext.cpp", line 357
Original wrong code:

                    if (gConfigSound.audio_focus && gConfigSound.sound_enabled)

Correct code:

                    if (gConfigSound.audio_focus &&
                        (gConfigSound.sound_enabled || gConfigSound.ride_music_enabled))

This will stop playing the ride music also on focus loss.

  • Reproducible in RCT2 (vanilla)?
  • Specific to multiplayer?
    Screenshots / Video:

option

@AaronVanGeffen
Copy link
Member

You've already suggested the code changes — again, feel free to open a PR. :)

@Gymnasiast
Copy link
Member

Please do not put two separate issues into one report.

Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this issue Aug 13, 2018
janisozaur added a commit that referenced this issue Aug 26, 2018
- Feature: [#5993] Ride window prices can now be set via text input.
- Feature: [#6998] Guests now wait for passing vehicles before crossing railway tracks.
- Feature: [#7658] Add option to always use system file browsing window.
- Feature: [#7694] Debug option to visualize paths that the game detects as wide.
- Feature: [#7713] The virtual floor now takes land ownership rights into account.
- Feature: [#7771] Danish translation.
- Feature: [#7797, #7802, #7821, #7830] Add sprite font glyphs for Danish, Norwegian, Russian, Turkish, Catalan and Romanian.
- Feature: [#7848] Add a master volume slider to audio options screen.
- Feature: [#7868] Placing scenery while holding shift now scales appropriately with zoom levels.
- Feature: [#7882] Auto-detect Steam and GOG installations of RCT1.
- Feature: [#7885] Turkish translation.
- Fix: [#3177] Wrong keys displayed in shortcut menu.
- Fix: [#4039] No sprite font glyph for German opening quotation mark.
- Fix: [#5548] platform_get_locale_date_format is not implemented for Linux.
- Fix: [#7204] Object source filters do not work for RCT1, AA and LL.
- Fix: [#7440] Memory leak. All system memory used.
- Fix: [#7462] Guest window goes beyond the map edge on a spiral slide.
- Fix: [#7533] Screenshot is incorrectly named/file is not generated in CJK language.
- Fix: [#7628] Always-researched items can be modified in the inventory list.
- Fix: [#7643] No Money scenarios with funding set to zero.
- Fix: [#7653] Finances money spinner is too narrow for big loans.
- Fix: [#7673] Vehicle names are cut off in invention list.
- Fix: [#7674] Rides show up as random numbers in guest's ride list.
- Fix: [#7678] Crash when loading or starting a new game while having object selection window open.
- Fix: [#7683] 'Arbitrary ride type' dropdown state is shared between windows.
- Fix: [#7697] Some scenery groups in RCT1 saves are never invented.
- Fix: [#7711] Inverted Hairpin Coaster allows building invisible banked pieces.
- Fix: [#7734] Title sequence not included in macOS builds as of 0.2.0 release.
- Fix: [#7756] Steam RCT2 path not correctly checked on macOS and Linux.
- Fix: [#7765] Crash when opening ride list window on Windows Vista.
- Fix: [#7773] Once research has been completed, player is still charged for research.
- Fix: [#7786] Crash when importing a track design.
- Fix: [#7793] Duplicate private keys generated.
- Fix: [#7817] No sprite font glyph for interpunct.
- Fix: [#7823] You can build mazes in pause mode.
- Fix: [#7804] Russian ride descriptions are cut off.
- Fix: [#7872] CJK tooltips are often cut off.
- Fix: [#7895] Import of Mega Park and the RCT1 title music do not work on some RCT1 sources.
- Improved: [#7899] Timestamps in the load/save screen are now displayed using local timezone instead of GMT.
- Improved: [#7918] Better RCT2 detection if both disc and GOG/Steam versions are installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants