Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to change research spending after unlocking all items #7773

Closed
ghost opened this issue Jul 10, 2018 · 2 comments
Closed

Unable to change research spending after unlocking all items #7773

ghost opened this issue Jul 10, 2018 · 2 comments
Labels
bug Something went wrong. good-first-issue Low hanging fruits good for people new to open source or OpenRCT2.

Comments

@ghost
Copy link

ghost commented Jul 10, 2018 •
edited by ghost
Loading

OS: Windows 10
Version: 0.2.0
Commit/Build: 3f8c3c3

Once research has been completed, player is still charged for research and unable to change research spending.

Steps to reproduce:

  • Unlock all rides/attractions in a level
  • Observe inability to change research finding
  • Observe continued research spending in financials

Screenshots / Video:
image

image

Save File:
Leafy_Lake.zip

(Reported via discord)
@AaronVanGeffen AaronVanGeffen added the bug Something went wrong. label Jul 10, 2018
@Gymnasiast Gymnasiast added the good-first-issue Low hanging fruits good for people new to open source or OpenRCT2. label Jul 11, 2018
@mattbeaudin mattbeaudin mentioned this issue Jul 17, 2018
Merged
mattbeaudin added a commit to mattbeaudin/OpenRCT2 that referenced this issue Jul 18, 2018
@mattbeaudin
Merge pull request #1 from OpenRCT2/develop
c8d1e20 
Fix OpenRCT2#7773: Once research has been completed, player is still charged …
janisozaur added a commit that referenced this issue Aug 26, 2018
@janisozaur
Release 0.2.1
8ac731e 
- Feature: [#5993] Ride window prices can now be set via text input.
- Feature: [#6998] Guests now wait for passing vehicles before crossing railway tracks.
- Feature: [#7658] Add option to always use system file browsing window.
- Feature: [#7694] Debug option to visualize paths that the game detects as wide.
- Feature: [#7713] The virtual floor now takes land ownership rights into account.
- Feature: [#7771] Danish translation.
- Feature: [#7797, #7802, #7821, #7830] Add sprite font glyphs for Danish, Norwegian, Russian, Turkish, Catalan and Romanian.
- Feature: [#7848] Add a master volume slider to audio options screen.
- Feature: [#7868] Placing scenery while holding shift now scales appropriately with zoom levels.
- Feature: [#7882] Auto-detect Steam and GOG installations of RCT1.
- Feature: [#7885] Turkish translation.
- Fix: [#3177] Wrong keys displayed in shortcut menu.
- Fix: [#4039] No sprite font glyph for German opening quotation mark.
- Fix: [#5548] platform_get_locale_date_format is not implemented for Linux.
- Fix: [#7204] Object source filters do not work for RCT1, AA and LL.
- Fix: [#7440] Memory leak. All system memory used.
- Fix: [#7462] Guest window goes beyond the map edge on a spiral slide.
- Fix: [#7533] Screenshot is incorrectly named/file is not generated in CJK language.
- Fix: [#7628] Always-researched items can be modified in the inventory list.
- Fix: [#7643] No Money scenarios with funding set to zero.
- Fix: [#7653] Finances money spinner is too narrow for big loans.
- Fix: [#7673] Vehicle names are cut off in invention list.
- Fix: [#7674] Rides show up as random numbers in guest's ride list.
- Fix: [#7678] Crash when loading or starting a new game while having object selection window open.
- Fix: [#7683] 'Arbitrary ride type' dropdown state is shared between windows.
- Fix: [#7697] Some scenery groups in RCT1 saves are never invented.
- Fix: [#7711] Inverted Hairpin Coaster allows building invisible banked pieces.
- Fix: [#7734] Title sequence not included in macOS builds as of 0.2.0 release.
- Fix: [#7756] Steam RCT2 path not correctly checked on macOS and Linux.
- Fix: [#7765] Crash when opening ride list window on Windows Vista.
- Fix: [#7773] Once research has been completed, player is still charged for research.
- Fix: [#7786] Crash when importing a track design.
- Fix: [#7793] Duplicate private keys generated.
- Fix: [#7817] No sprite font glyph for interpunct.
- Fix: [#7823] You can build mazes in pause mode.
- Fix: [#7804] Russian ride descriptions are cut off.
- Fix: [#7872] CJK tooltips are often cut off.
- Fix: [#7895] Import of Mega Park and the RCT1 title music do not work on some RCT1 sources.
- Improved: [#7899] Timestamps in the load/save screen are now displayed using local timezone instead of GMT.
- Improved: [#7918] Better RCT2 detection if both disc and GOG/Steam versions are installed.
@James103
Copy link
Contributor

James103 commented May 26, 2020 •
edited
Loading

In OpenRCT2 0.2.6 release (6c3c857), if a scenario starts the research at RESEARCH_STAGE_FINISHED_ALL† (meaning that no researchable items are present in the scenario from the start, all items are either researched or unloaded), you are still charged a (sometimes unavoidable) $100 research bill. This is because the game only kills the funding to the research after up to 2 weeks, instead at the start, if there are no items that are researchable at the start of the scenario.

†gResearchProgressStage is not actually initialized to RESEARCH_STAGE_FINISHED_ALL even though the game detected that there are no researchable items at the start of the scenario. Two in-game weeks pass, and then the research advances to the next stage. There, it checks that there actually are no researchable items, and so sets gResearchProgressStage == RESEARCH_STAGE_FINISHED_ALL and kills the funding.

@Gymnasiast
Copy link
Member

@James103 Please create a new issue for that.

@James103 James103 mentioned this issue May 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something went wrong. good-first-issue Low hanging fruits good for people new to open source or OpenRCT2.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AaronVanGeffen @Gymnasiast @James103