Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save file browser lists file time in GMT time. Local time is better. #7899

Closed
2 tasks
qqkookie opened this issue Aug 14, 2018 · 2 comments · Fixed by #7903
Closed
2 tasks

Save file browser lists file time in GMT time. Local time is better. #7899

qqkookie opened this issue Aug 14, 2018 · 2 comments · Fixed by #7903
Assignees
@AaronVanGeffen
Labels
enhancement An improvement to an existing feature (no alteration). user interface Has to do with user interfaces.

Comments

@qqkookie
Copy link

qqkookie commented Aug 14, 2018 •
edited
Loading

OS: Windows 10
Version: 0.2.0
Commit/Build:

The in-game file browser to load/save file lists file time in GMT file time. IMHO, it would be better to display these file time in local time, which is adjusted for local time zone offset.
And sometime in Korean language, last few digits of time field clipped away with ellipsis (...),. So the date field needs extra width of about 5 pixels or so.

  • Reproducible in RCT2 (vanilla)?
  • Specific to multiplayer?
@Broxzier
Copy link
Member

Broxzier commented Aug 14, 2018 •
edited
Loading

The in-game file browser to load/save file lists file time in GMT file time.

It doesn't. It lists file times as they are saved without modifying a thing.
Now I get what you're saying, and indeed that is the case. The time to be displayed should match the system.

And sometime in Korean language, last few digits of time field clipped away with ellipsis (...),. So the date field needs extra width of about 5 pixels or so.

That is an issue. Please report only one things at a time to make tracking easier.

@Broxzier Broxzier added enhancement An improvement to an existing feature (no alteration). user interface Has to do with user interfaces. labels Aug 14, 2018
@AaronVanGeffen
Copy link
Member

Just to add, this doesn't just happen on Windows. I can reproduce this on Linux as well. Odd, I thought I had implemented it to respect local time.

@AaronVanGeffen AaronVanGeffen self-assigned this Aug 14, 2018
@AaronVanGeffen AaronVanGeffen mentioned this issue Aug 14, 2018
Merged
janisozaur added a commit that referenced this issue Aug 26, 2018
@janisozaur
Release 0.2.1
8ac731e 
- Feature: [#5993] Ride window prices can now be set via text input.
- Feature: [#6998] Guests now wait for passing vehicles before crossing railway tracks.
- Feature: [#7658] Add option to always use system file browsing window.
- Feature: [#7694] Debug option to visualize paths that the game detects as wide.
- Feature: [#7713] The virtual floor now takes land ownership rights into account.
- Feature: [#7771] Danish translation.
- Feature: [#7797, #7802, #7821, #7830] Add sprite font glyphs for Danish, Norwegian, Russian, Turkish, Catalan and Romanian.
- Feature: [#7848] Add a master volume slider to audio options screen.
- Feature: [#7868] Placing scenery while holding shift now scales appropriately with zoom levels.
- Feature: [#7882] Auto-detect Steam and GOG installations of RCT1.
- Feature: [#7885] Turkish translation.
- Fix: [#3177] Wrong keys displayed in shortcut menu.
- Fix: [#4039] No sprite font glyph for German opening quotation mark.
- Fix: [#5548] platform_get_locale_date_format is not implemented for Linux.
- Fix: [#7204] Object source filters do not work for RCT1, AA and LL.
- Fix: [#7440] Memory leak. All system memory used.
- Fix: [#7462] Guest window goes beyond the map edge on a spiral slide.
- Fix: [#7533] Screenshot is incorrectly named/file is not generated in CJK language.
- Fix: [#7628] Always-researched items can be modified in the inventory list.
- Fix: [#7643] No Money scenarios with funding set to zero.
- Fix: [#7653] Finances money spinner is too narrow for big loans.
- Fix: [#7673] Vehicle names are cut off in invention list.
- Fix: [#7674] Rides show up as random numbers in guest's ride list.
- Fix: [#7678] Crash when loading or starting a new game while having object selection window open.
- Fix: [#7683] 'Arbitrary ride type' dropdown state is shared between windows.
- Fix: [#7697] Some scenery groups in RCT1 saves are never invented.
- Fix: [#7711] Inverted Hairpin Coaster allows building invisible banked pieces.
- Fix: [#7734] Title sequence not included in macOS builds as of 0.2.0 release.
- Fix: [#7756] Steam RCT2 path not correctly checked on macOS and Linux.
- Fix: [#7765] Crash when opening ride list window on Windows Vista.
- Fix: [#7773] Once research has been completed, player is still charged for research.
- Fix: [#7786] Crash when importing a track design.
- Fix: [#7793] Duplicate private keys generated.
- Fix: [#7817] No sprite font glyph for interpunct.
- Fix: [#7823] You can build mazes in pause mode.
- Fix: [#7804] Russian ride descriptions are cut off.
- Fix: [#7872] CJK tooltips are often cut off.
- Fix: [#7895] Import of Mega Park and the RCT1 title music do not work on some RCT1 sources.
- Improved: [#7899] Timestamps in the load/save screen are now displayed using local timezone instead of GMT.
- Improved: [#7918] Better RCT2 detection if both disc and GOG/Steam versions are installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AaronVanGeffen AaronVanGeffen

Labels
enhancement An improvement to an existing feature (no alteration). user interface Has to do with user interfaces.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use localtime instead of gmtime in file browser AaronVanGeffen/OpenRCT2
3 participants
@AaronVanGeffen @Broxzier @qqkookie