Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix No Money scenarios with funding set to 0 #7643

Closed
Gymnasiast opened this issue Jun 9, 2018 · 3 comments
Closed

Fix No Money scenarios with funding set to 0 #7643

Gymnasiast opened this issue Jun 9, 2018 · 3 comments
Labels
original bug This was an issue in the original game already.

Comments

@Gymnasiast
Copy link
Member

As seen in #7641 , 'No Money' scenarios can exist with the funding set to 0, which means that the user will not have any way to resolve it themselves, as it's impossible to change funding.

To fix this, funding should be set to Normal if:

  • it's set to 0.
  • it's a no money scenario
  • there are uninvented items left.
@Gymnasiast Gymnasiast added the original bug This was an issue in the original game already. label Jun 9, 2018
@IntelOrca
Copy link
Contributor

IntelOrca commented Jun 9, 2018 •
edited
Loading

Instead of setting the property, the fix should be to change research update to instead use normal funding instead of the value of the property if money is disabled.

@ocalhoun6
Copy link
Contributor

While having it set to 0 is obviously useless, I could see where it might be useful to scenario-builders to have the option to set it to min/normal/max, in order to make the no-money scenario more or less difficult, forcing players to make choices about what they want to research before the time limit expires.

Maybe on no-money scenarios, if it's set to 0 funding, have it default to minimum funding instead?

@Gymnasiast
Copy link
Member Author

Maybe on no-money scenarios, if it's set to 0 funding, have it default to minimum funding instead?

That is exactly what I proposed.

AndyTWF pushed a commit to AndyTWF/OpenRCT2 that referenced this issue Jun 13, 2018
Fix OpenRCT2#7643: No Money Scenarios Function Set To Zero
785347b 
If research funding is set to no funding and scenario money is turned
off, then update research at the normal rate.
janisozaur added a commit that referenced this issue Aug 26, 2018
@janisozaur
Release 0.2.1
8ac731e 
- Feature: [#5993] Ride window prices can now be set via text input.
- Feature: [#6998] Guests now wait for passing vehicles before crossing railway tracks.
- Feature: [#7658] Add option to always use system file browsing window.
- Feature: [#7694] Debug option to visualize paths that the game detects as wide.
- Feature: [#7713] The virtual floor now takes land ownership rights into account.
- Feature: [#7771] Danish translation.
- Feature: [#7797, #7802, #7821, #7830] Add sprite font glyphs for Danish, Norwegian, Russian, Turkish, Catalan and Romanian.
- Feature: [#7848] Add a master volume slider to audio options screen.
- Feature: [#7868] Placing scenery while holding shift now scales appropriately with zoom levels.
- Feature: [#7882] Auto-detect Steam and GOG installations of RCT1.
- Feature: [#7885] Turkish translation.
- Fix: [#3177] Wrong keys displayed in shortcut menu.
- Fix: [#4039] No sprite font glyph for German opening quotation mark.
- Fix: [#5548] platform_get_locale_date_format is not implemented for Linux.
- Fix: [#7204] Object source filters do not work for RCT1, AA and LL.
- Fix: [#7440] Memory leak. All system memory used.
- Fix: [#7462] Guest window goes beyond the map edge on a spiral slide.
- Fix: [#7533] Screenshot is incorrectly named/file is not generated in CJK language.
- Fix: [#7628] Always-researched items can be modified in the inventory list.
- Fix: [#7643] No Money scenarios with funding set to zero.
- Fix: [#7653] Finances money spinner is too narrow for big loans.
- Fix: [#7673] Vehicle names are cut off in invention list.
- Fix: [#7674] Rides show up as random numbers in guest's ride list.
- Fix: [#7678] Crash when loading or starting a new game while having object selection window open.
- Fix: [#7683] 'Arbitrary ride type' dropdown state is shared between windows.
- Fix: [#7697] Some scenery groups in RCT1 saves are never invented.
- Fix: [#7711] Inverted Hairpin Coaster allows building invisible banked pieces.
- Fix: [#7734] Title sequence not included in macOS builds as of 0.2.0 release.
- Fix: [#7756] Steam RCT2 path not correctly checked on macOS and Linux.
- Fix: [#7765] Crash when opening ride list window on Windows Vista.
- Fix: [#7773] Once research has been completed, player is still charged for research.
- Fix: [#7786] Crash when importing a track design.
- Fix: [#7793] Duplicate private keys generated.
- Fix: [#7817] No sprite font glyph for interpunct.
- Fix: [#7823] You can build mazes in pause mode.
- Fix: [#7804] Russian ride descriptions are cut off.
- Fix: [#7872] CJK tooltips are often cut off.
- Fix: [#7895] Import of Mega Park and the RCT1 title music do not work on some RCT1 sources.
- Improved: [#7899] Timestamps in the load/save screen are now displayed using local timezone instead of GMT.
- Improved: [#7918] Better RCT2 detection if both disc and GOG/Steam versions are installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
original bug This was an issue in the original game already.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Gymnasiast @IntelOrca @ocalhoun6