Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer Steam and GOG installs to disc during autodetection #7918

Merged
merged 2 commits into from
Aug 20, 2018

Conversation

Gymnasiast
Copy link
Member

Some people apparently have both a disc version and a Steam version of RCT2 installed. The problem is that the former does not always include the expansions, while the latter does. The same applies to RCT1.

By checking for Steam/GOG versions first, these problems can be avoided.

@IntelOrca
Copy link
Contributor

Would it be better to check for GOG first, it is probably unlikely players will have both Steam and GOG installed but GOG is the better version right?

@Gymnasiast
Copy link
Member Author

Hm, in what way?

@AaronVanGeffen
Copy link
Member

AaronVanGeffen commented Aug 20, 2018

The GOG version has more translations in its DAT files, right? We no longer use those, though... But that's all I can think of.

@IntelOrca
Copy link
Contributor

Never mind then, perhaps the organisation is better with the mega park and such.

@Gymnasiast
Copy link
Member Author

Gymnasiast commented Aug 20, 2018

Does the GOG version have those u(123).td4 files? Many people seem to hate those. If it hasn't, then it should be higher.

Mega Park works across all versions, as I recently tackled that.

AFAIK, all the Japanese translations (both objects and scenarios) have been extracted. I don't know if GOG contained these in the first place, but the Steam version did.

@Broxzier
Copy link
Member

Yes, for RCT1 Deluxe the Tracks folder has many files named u(1234).td46, but also files like Boomerang.TD4 and Boomerang.TP4.

@Gymnasiast
Copy link
Member Author

@Broxzier Are you talking about the GOG version?

@AaronVanGeffen
Copy link
Member

@Gymnasiast My GOG copy of RCT(1) Deluxe does have those u(1234).td4 files, yes.

@Gymnasiast Gymnasiast merged commit 7743d0e into develop Aug 20, 2018
@Gymnasiast Gymnasiast deleted the steam-gog-disc-order branch August 20, 2018 15:48
janisozaur added a commit that referenced this pull request Aug 26, 2018
- Feature: [#5993] Ride window prices can now be set via text input.
- Feature: [#6998] Guests now wait for passing vehicles before crossing railway tracks.
- Feature: [#7658] Add option to always use system file browsing window.
- Feature: [#7694] Debug option to visualize paths that the game detects as wide.
- Feature: [#7713] The virtual floor now takes land ownership rights into account.
- Feature: [#7771] Danish translation.
- Feature: [#7797, #7802, #7821, #7830] Add sprite font glyphs for Danish, Norwegian, Russian, Turkish, Catalan and Romanian.
- Feature: [#7848] Add a master volume slider to audio options screen.
- Feature: [#7868] Placing scenery while holding shift now scales appropriately with zoom levels.
- Feature: [#7882] Auto-detect Steam and GOG installations of RCT1.
- Feature: [#7885] Turkish translation.
- Fix: [#3177] Wrong keys displayed in shortcut menu.
- Fix: [#4039] No sprite font glyph for German opening quotation mark.
- Fix: [#5548] platform_get_locale_date_format is not implemented for Linux.
- Fix: [#7204] Object source filters do not work for RCT1, AA and LL.
- Fix: [#7440] Memory leak. All system memory used.
- Fix: [#7462] Guest window goes beyond the map edge on a spiral slide.
- Fix: [#7533] Screenshot is incorrectly named/file is not generated in CJK language.
- Fix: [#7628] Always-researched items can be modified in the inventory list.
- Fix: [#7643] No Money scenarios with funding set to zero.
- Fix: [#7653] Finances money spinner is too narrow for big loans.
- Fix: [#7673] Vehicle names are cut off in invention list.
- Fix: [#7674] Rides show up as random numbers in guest's ride list.
- Fix: [#7678] Crash when loading or starting a new game while having object selection window open.
- Fix: [#7683] 'Arbitrary ride type' dropdown state is shared between windows.
- Fix: [#7697] Some scenery groups in RCT1 saves are never invented.
- Fix: [#7711] Inverted Hairpin Coaster allows building invisible banked pieces.
- Fix: [#7734] Title sequence not included in macOS builds as of 0.2.0 release.
- Fix: [#7756] Steam RCT2 path not correctly checked on macOS and Linux.
- Fix: [#7765] Crash when opening ride list window on Windows Vista.
- Fix: [#7773] Once research has been completed, player is still charged for research.
- Fix: [#7786] Crash when importing a track design.
- Fix: [#7793] Duplicate private keys generated.
- Fix: [#7817] No sprite font glyph for interpunct.
- Fix: [#7823] You can build mazes in pause mode.
- Fix: [#7804] Russian ride descriptions are cut off.
- Fix: [#7872] CJK tooltips are often cut off.
- Fix: [#7895] Import of Mega Park and the RCT1 title music do not work on some RCT1 sources.
- Improved: [#7899] Timestamps in the load/save screen are now displayed using local timezone instead of GMT.
- Improved: [#7918] Better RCT2 detection if both disc and GOG/Steam versions are installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants