Skip to content

Dev master 27th march #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 27, 2024
Merged

Dev master 27th march #1147

merged 17 commits into from
Mar 27, 2024

Conversation

@rismehta
Copy link
Collaborator

@rismehta rismehta commented Mar 27, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

rajatofficial and others added 14 commits March 11, 2024 12:07
@rajatofficial @rajatkhurana-adobe
FORMS-13392 Role main check (#1112)
ca9cb59 
* FORMS-13392 role main check added

* FORMS-13392 role main check added I

---------

Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>
@ravise5
Constraint messages should work when type is integer for number-input (…
5134684 
…#1127)
@rismehta
Revert "Rich text support (#1077)" (#1129)
a249f93 
This reverts commit cbc3d4f.
@im-shiv
Revert "Revert "Rich text support (#1077)"" (#1131)
da93d69 
* Revert "Revert "Rich text support (#1077)" (#1129)"

This reverts commit a249f93.

* reverting enumNames spec change

* changes needed

* removing addon check not needed

---------

Co-authored-by: Shivam Agarwal <shivama@adobe.com>
@arunattri26
FORMS-11692: upgraded af2-web-runtime version and added rule editor t… (
0c9da93 
#1117)

* FORMS-11692: upgraded af2-web-runtime version and added rule editor tests

* FORMS-11692: upgraded af2-web-runtime version and added rule editor tests

* FORMS-11692: upgraded af2-web-runtime version and added rule editor tests

* FORMS-11692: upgraded af2-web-runtime version and added rule editor tests

* FORMS-11692: upgraded af2-web-runtime version and added rule editor tests

* FORMS-11692: updated getParentFormElementId method to check for form fieldType

* FORMS-11692: updated af2-runtime and remove authoring tests for rule editor.

* FORMS-11692: upgraded af2-web-runtime version and added rule editor tests

* FORMS-11692: upgraded af2-web-runtime version and added rule editor tests

* FORMS-11692: upgraded af2-web-runtime version and added rule editor tests

* FORMS-11692: updated getParentFormElementId method to check for form fieldType

* FORMS-11692: updated tests

* FORMS-11692: updated tests

* FORMS-11692: added test case for merged custom function list from two clientlibs

---------

Co-authored-by: Arun Kumar Attri <aattri@adobe.com>
@ravise5
Add support for displayValueExpression (#1126)
7f7b068 
* Add support for displayValueExpression
* Exposed displayValueExpression for telephone,text,email and date input

* Added e2e tests
* Add theme to datepicker tests as the date picker widget doesn't work without a theme

* RTC(done) specVersion updated in formContainer
* RTC Persisting spec Version in guideContainer node

* Saving specVersion when formContainer dialog is saved
@devgurjar
Fixes datepicker layout issues (#1134)
4ba5460 
Co-authored-by: dgurjar <dgurjar@adobe.com>
@rismehta
Revert "Fixes datepicker layout issues (#1134)"
19d526a 
This reverts commit 4ba5460.
@pavi41
initial commit (#1133)
fc59181 
Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>
@rismehta
Revert "Merge pull request #1141 from adobe/dev2master26March"
15251a6 
This reverts commit b0f07e5, reversing
changes made to ac1f567.
@rismehta
Revert "Merge pull request #1130 from adobe/devMaster1803"
44dc04a 
This reverts commit ea5bc19, reversing
changes made to 3860224.
@rismehta
Merge branch 'dev' into devM27March
463d31f
@rismehta
Aligning command.js to dev
b952b6e
@rismehta
Merge branch 'dev' into devM27March
d6fbfd0
@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

1 similar comment
@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.75%. Comparing base (9eccd28) to head (ceb4af9).

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1147   +/-   ##
=========================================
  Coverage     80.75%   80.75%           
  Complexity      773      773           
=========================================
  Files            91       91           
  Lines          2110     2110           
  Branches        285      285           
=========================================
  Hits           1704     1704           
  Misses          252      252           
  Partials        154      154

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rismehta rismehta changed the title Dev m27 march Dev master 27th march Mar 27, 2024
rismehta and others added 3 commits March 27, 2024 17:34
@rismehta
Enabling custom extension in view layer (#1148)
61b45f1 
* Enabling custom extension in view layer

* Adding test cases for custom component to support validation message on submit

* Fixing test case
@devgurjar
date picker layout issue (#1145)
c620390 
Co-authored-by: dgurjar <dgurjar@adobe.com>
@rismehta
Merge branch 'dev' into devM27March
ceb4af9
@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 90 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@rismehta rismehta merged commit 2144380 into master Mar 27, 2024
@rismehta rismehta deleted the devM27March branch March 27, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@rismehta @adobe-bot @rajatofficial @ravise5 @im-shiv @arunattri26 @devgurjar @pavi41