Add ABOUT page. #278
Add ABOUT page. #278
Conversation
|
Note to reviewers: we have two PRs right now for the ABOUT.md: See also #275 Both PRs have lots of really good content. Maybe we can merge one in and have the other person add some edits based on their PR? |
docs/ABOUT.md
Outdated
There was a problem hiding this comment.
This gets incorporated on a page that already has a header, so this first line can go away.
|
I believe that it would be easier for me if you merge #275. Then I can merge mine. |
|
I went ahead and merged #275 for you. |
Wording changes in ABOUT.md
accumulate: fix lambda usage (see #287)
series: fix pep8 compliance (see #287)
word-count: fix lambda usage (see #287)
luhn: fix lambda usage (see #287)
strain: fix lambda usage (see #287)
The original tests had tests for "" and 0. This is when both inputs are the boundary condition. Now we should also test when only one input is at the boundary. So we should test a non-empty string with 0, and "" with a nonzero span. These are consistent with the values defined in https://github.com/exercism/x-common/blob/master/largest-series-product.json
In these cases, the result should be 0 as well. This guards against solutions that assume the minimum is 1.
largest-series-product corner cases
Adds the exercise to the "exercises" key in the config.json (see #360).
…362) * hello-world: Add two new test functions to test blank and none names * binary-search: Add to exercises key in config
binary-search: Add to "exercises" key in config
Update flake8 and pyflakes to the latest version
...from exercism.io/ATTRIBUTION.md, noting the permission they gave us a step in fixing exercism/exercism#3112.
Add attribution for the track icon
this keeps it in line with the TOPICS list
…hello-world change if-statements to if-else statements
The **problems** key is deprecated in favour of **exercises** so it can be removed. We have confirmation from exercism/DEPRECATED.x-api#137 that it is safe to *delete* the problems key.
Remove deprecated problems key
|
I will close this abandoned pr for clarity. If you want to continue your work on this, we can reopen it. |
|
I am very sorry, I missed the message from @kytrinyx. Have just rebased my fork with upstream/master. Should I make a new pull request? |
|
You cold continue here. Opened it again. edit: It now looks quite messy with alle those commits. It's up to you, but maybe a new pr would make sense. |
|
I deleted my fork, created a new fork. Applied the changes to the About page and created a fresh new pull request. |
24 participants
No description provided.