Move editor viewport gizmos visibility logic out of process notification#102020
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 21, 2025
Conversation
ryevdokimov
force-pushed
the
move-viewport-gizmos-visibility-out-of-process
branch
from
329c11f to
9355a9b
Compare
Calinou
reviewed
Jan 27, 2025
Member
There was a problem hiding this comment.
Tested locally, it mostly works as expected.
Testing project: test-multiple-cameras.zip
However, the issue that #102014 addressed with the rotation gizmo appearing after restarting the editor is back, at least when previewing multiple cameras with multiple viewports:
It's possible that this also occurs with #102014 alone, as I didn't test multiple viewports back then.
ryevdokimov
force-pushed
the
move-viewport-gizmos-visibility-out-of-process
branch
from
9355a9b to
1a8c487
Compare
Contributor
Author
|
Fixed, and tested with multiple viewports. I'm not sure how I missed this. 😵💫 |
ryevdokimov
force-pushed
the
move-viewport-gizmos-visibility-out-of-process
branch
from
1a8c487 to
36d737d
Compare
Contributor
Author
|
Rebased since #102014 was merged. |
ryevdokimov
force-pushed
the
move-viewport-gizmos-visibility-out-of-process
branch
from
36d737d to
072ee10
Compare
Calinou
approved these changes
Jul 8, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Works great now 🙂
I can confirm the gizmos are gone on previewed viewports, even after a restart:
It also works with Cinematic Preview.
Contributor
|
Thanks! |
ryevdokimov
deleted the
move-viewport-gizmos-visibility-out-of-process
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires and includes: #102014
Related: godotengine/godot-proposals#11424 (comment)
It doesn't make much sense to do this every frame, also prevents plugins from toggling visibility since it's constantly being overwritten.