Skip to content

Create EditorHelpHighlighter in Project Manager#116014

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
cdemirer:create-editor-help-highlighter-in-project-manager
Feb 25, 2026
Merged

Create EditorHelpHighlighter in Project Manager#116014
Repiteo merged 1 commit into
godotengine:masterfrom
cdemirer:create-editor-help-highlighter-in-project-manager

Conversation

@cdemirer
Copy link
Copy Markdown
Contributor

@cdemirer cdemirer commented Feb 7, 2026

so that it works in Editor Settings opened without loading a project.

Fixes #115892.

I'm not sure if this is the right place to initialize it. If it's not, please advise.

so that it works in Editor Settings opened without loading a project.
Copy link
Copy Markdown
Contributor

@mxtherfxcker mxtherfxcker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Copy Markdown
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected (including when changing the editor theme, which forces EditorHelpHighlighter to be recreated).

Code looks good to me.

As an aside, I noticed switching editor color presets won't update the syntax highlighting colors until the project manager is restarted:

Image

This issue is also present in the editor, so it's not exclusive to the project manager anyway.

PS: This editor setting is not meant to use syntax highlighting, as it displays file paths, not code. I fixed this in #116743.

@akien-mga akien-mga added the cherrypick:4.6 Considered for cherry-picking into a future 4.6.x release label Feb 25, 2026
@Repiteo Repiteo merged commit f5a4757 into godotengine:master Feb 25, 2026
20 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented Feb 25, 2026

Thanks!

@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented Mar 5, 2026

Cherry-picked for 4.6.2.

@Repiteo Repiteo removed the cherrypick:4.6 Considered for cherry-picking into a future 4.6.x release label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Godot 4.6 crashes when mousing over on Blender Path in Editor Settings

6 participants