Wayland: Only handle the current output mode#116236
Merged
Merged
Conversation
Some compositors (e.g. COSMIC) can report *all* supported output modes, not just the current mode. This is valid, albeit deprecated, so let's add a check and ignore any non-current output events.
bruvzg
approved these changes
Feb 13, 2026
akien-mga
added
the
cherrypick:4.6
Contributor
|
Thanks! |
Contributor
|
Cherry-picked for 4.6.2. |
Repiteo
removed
the
cherrypick:4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115369.
Some compositors (e.g. COSMIC) can report all supported output modes, not just the current mode. This is valid, albeit deprecated, so let's add a check and ignore any non-current output events.
This meant that, on certain compositors,
screen_get_sizecould return the wrong size, even really tiny stuff like 640x480. That said, even with this fix, the way we handle screens is still a hack and we should not depend on them in the long term.